Skip to contentSkip to conversation

drm/amdkfd: Rename create_cp_queue() to init_user_queue()

PATCH In review Zhao, Yong 2 participants 3 messages Nov 1, 2019 – Nov 11, 2019 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

Zhao, Yong

author
#0 lore raw

PATCH 1/1 drm/amdkfd: Rename create_cp_queue() to init_user_queue()

create_cp_queue() could also work with SDMA queues, so we should rename it.

Change-Id I76cbaed8fa95dd9062d786cbc1dd037ff041da9d
---
 drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c +3 -3
index 48185d2957e9..ebb2f69b438c 100644
@@ -162,7 +162,7 @@ void pqm_uninit(struct process_queue_manager *pqm)
 	pqm->queue_slot_bitmap = NULL;
 }
 
-static int create_cp_queue(struct process_queue_manager *pqm,
+static int init_user_queue(struct process_queue_manager *pqm,
 				struct kfd_dev *dev, struct queue **q,
 				struct queue_properties *q_properties,
 				struct file *f, unsigned int qid)
@@ -251,7 +251,7 @@ int pqm_create_queue(struct process_queue_manager *pqm,
 			goto err_create_queue;
 		}
 
-		retval = create_cp_queue(pqm, dev, &q, properties, f, *qid);
+		retval = init_user_queue(pqm, dev, &q, properties, f, *qid);
 		if (retval != 0)
 			goto err_create_queue;
 		pqn->q = q;
@@ -272,7 +272,7 @@ int pqm_create_queue(struct process_queue_manager *pqm,
 			goto err_create_queue;
 		}
 
-		retval = create_cp_queue(pqm, dev, &q, properties, f, *qid);
+		retval = init_user_queue(pqm, dev, &q, properties, f, *qid);
 		if (retval != 0)
 			goto err_create_queue;
 		pqn->q = q;
Signature · 6 lines
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#2 lore raw

ping

Quoted 32 lines · Yong

create_cp_queue() could also work with SDMA queues, so we should rename it.

Change-Id I76cbaed8fa95dd9062d786cbc1dd037ff041da9d
---
  drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c +2 -2
index 48185d2957e9..ebb2f69b438c 100644
@@ -162,7 +162,7 @@ void pqm_uninit(struct process_queue_manager *pqm)
  	pqm->queue_slot_bitmap = NULL;
  }
 
-static int create_cp_queue(struct process_queue_manager *pqm,
+static int init_user_queue(struct process_queue_manager *pqm,
  				struct kfd_dev *dev, struct queue **q,
  				struct queue_properties *q_properties,
  				struct file *f, unsigned int qid)
@@ -251,7 +251,7 @@ int pqm_create_queue(struct process_queue_manager *pqm,
  			goto err_create_queue;
  		}
 
-		retval = create_cp_queue(pqm, dev, &q, properties, f, *qid);
+		retval = init_user_queue(pqm, dev, &q, properties, f, *qid);
  		if (retval != 0)
  			goto err_create_queue;
  		pqn->q = q;

drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c int pqm_create_queue(struct process_queue_manager *pqm, · line 278

Quoted 8 lines
drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c +1 -1
@@ -272,7 +272,7 @@ int pqm_create_queue(struct process_queue_manager *pqm,
  			goto err_create_queue;
  		}
 
-		retval = create_cp_queue(pqm, dev, &q, properties, f, *qid);
+		retval = init_user_queue(pqm, dev, &q, properties, f, *qid);
  		if (retval != 0)
  			goto err_create_queue;
  		pqn->q = q;

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reviewed-by
#3 lore raw
In reply to a message not in the archive
Quoted 5 lines · Yong

create_cp_queue() could also work with SDMA queues, so we should rename it.

Change-Id I76cbaed8fa95dd9062d786cbc1dd037ff041da9d

The name change makes sense. This patch is

Quoted 27 lines
---
  drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c +2 -2
index 48185d2957e9..ebb2f69b438c 100644
@@ -162,7 +162,7 @@ void pqm_uninit(struct process_queue_manager *pqm)
  	pqm->queue_slot_bitmap = NULL;
  }
 
-static int create_cp_queue(struct process_queue_manager *pqm,
+static int init_user_queue(struct process_queue_manager *pqm,
  				struct kfd_dev *dev, struct queue **q,
  				struct queue_properties *q_properties,
  				struct file *f, unsigned int qid)
@@ -251,7 +251,7 @@ int pqm_create_queue(struct process_queue_manager *pqm,
  			goto err_create_queue;
  		}
 
-		retval = create_cp_queue(pqm, dev, &q, properties, f, *qid);
+		retval = init_user_queue(pqm, dev, &q, properties, f, *qid);
  		if (retval != 0)
  			goto err_create_queue;
  		pqn->q = q;

drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c int pqm_create_queue(struct process_queue_manager *pqm, · line 278

Quoted 8 lines
drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c +1 -1
@@ -272,7 +272,7 @@ int pqm_create_queue(struct process_queue_manager *pqm,
  			goto err_create_queue;
  		}
 
-		retval = create_cp_queue(pqm, dev, &q, properties, f, *qid);
+		retval = init_user_queue(pqm, dev, &q, properties, f, *qid);
  		if (retval != 0)
  			goto err_create_queue;
  		pqn->q = q;

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx