drm/i915: Program SHPD_FILTER_CNT on CNP+
Subsystems (2)
PATCH 1/1 drm/i915: Program SHPD_FILTER_CNT on CNP+
The bspec tells us 'Program SHPD_FILTER_CNT with the "500 microseconds adjusted" value before enabling hotplug detection' on CNP+. We haven't been touching this register at all thus far, but we should probably follow the bspec's guidance.
The register also exists on LPT and SPT, but there isn't any specific guidance I can find on how we should be programming it there so let's leave it be for now.
Bspec: 4342
Bspec: 31297
Bspec: 8407
Bspec: 49305
Bspec: 50473
--- drivers/gpu/drm/i915/i915_irq.c | 5 +++++ drivers/gpu/drm/i915/i915_reg.h | 4 ++++ 2 files changed, 9 insertions(+)
drivers/gpu/drm/i915/i915_irq.c +5 -0
@@ -2976,6 +2976,8 @@ static void icp_hpd_irq_setup(struct drm_i915_private *dev_priv, hotplug_irqs = sde_ddi_mask | sde_tc_mask; enabled_irqs =intel_hpd_enabled_irqs (dev_priv, pins); +I915_WRITE (SHPD_FILTER_CNT ,SHPD_FILTER_CNT_500_ADJ ); +ibx_display_interrupt_update (dev_priv, hotplug_irqs, enabled_irqs);icp_hpd_detection_setup (dev_priv, ddi_enable_mask, tc_enable_mask);
@@ -3081,6 +3083,9 @@ static void spt_hpd_irq_setup(struct drm_i915_private *dev_priv) {u32 hotplug_irqs, enabled_irqs; +if (INTEL_PCH_TYPE (dev_priv) >=PCH_CNP ) +I915_WRITE (SHPD_FILTER_CNT ,SHPD_FILTER_CNT_500_ADJ ); + hotplug_irqs =SDE_HOTPLUG_MASK_SPT ; enabled_irqs =intel_hpd_enabled_irqs (dev_priv, hpd_spt);
drivers/gpu/drm/i915/i915_reg.h +4 -0
@@ -8083,6 +8083,10 @@ enum {#define SHOTPLUG_CTL_TC _MMIO(0xc4034)#define ICP_TC_HPD_ENABLE (tc_port) (8 << (tc_port) * 4) + +#define SHPD_FILTER_CNT _MMIO(0xc4038) +#define SHPD_FILTER_CNT_500_ADJ 0x001D9 +/* Icelake DSC Rate Control Range Parameter Registers */ #define DSCA_RC_RANGE_PARAMETERS_0 _MMIO(0x6B240)#define DSCA_RC_RANGE_PARAMETERS_0_UDW _MMIO(0x6B240 + 4)
Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Program SHPD_FILTER_CNT on CNP+
== Series Details ==
== Series Details ==
Series: drm/i915: Program SHPD_FILTER_CNT on CNP+
URL : https://patchwork.freedesktop.org/series/68892/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7243 -> Patchwork_15114
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15114/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15114:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* {igt@i915_selftest@live_gt_pm}:
- {fi-icl-guc}: NOTRUN -> [DMESG-FAIL][1] +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15114/fi-icl-guc/igt@i915_selftest@live_gt_pm.html
* igt@i915_selftest@live_hugepages:
- {fi-icl-guc}: NOTRUN -> [DMESG-WARN][2] +16 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15114/fi-icl-guc/igt@i915_selftest@live_hugepages.html
Known issues
------------
Here are the changes found in Patchwork_15114 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_mmap_gtt@basic-read-write-distinct:
- fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7243/fi-icl-u3/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15114/fi-icl-u3/igt@[email protected]
#### Possible fixes ####
* igt@gem_ctx_create@basic-files:
- {fi-icl-u4}: [INCOMPLETE][5] ([fdo#107713] / [fdo#109100]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7243/fi-icl-u4/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15114/fi-icl-u4/igt@[email protected]
- {fi-icl-guc}: [INCOMPLETE][7] ([fdo#107713] / [fdo#109100]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7243/fi-icl-guc/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15114/fi-icl-guc/igt@[email protected]
* igt@gem_ctx_switch@legacy-render:
- fi-apl-guc: [INCOMPLETE][9] ([fdo#103927]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7243/fi-apl-guc/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15114/fi-apl-guc/igt@[email protected]
* igt@gem_exec_create@basic:
- {fi-icl-y}: [INCOMPLETE][11] ([fdo#107713]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7243/fi-icl-y/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15114/fi-icl-y/igt@[email protected]
* igt@gem_mmap@basic-small-bo:
- fi-icl-u3: [DMESG-WARN][13] ([fdo#107724]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7243/fi-icl-u3/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15114/fi-icl-u3/igt@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- {fi-tgl-y}: [FAIL][15] ([fdo# 112163] / [fdo#103167]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7243/fi-tgl-y/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15114/fi-tgl-y/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo# 112163]: https://bugs.freedesktop.org/show_bug.cgi?id= 112163 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#111880]: https://bugs.freedesktop.org/show_bug.cgi?id=111880
Participating hosts (51 -> 43)
------------------------------
Additional (1): fi-kbl-7500u
Missing (9): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-bwr-2160 fi-ctg-p8600 fi-gdg-551 fi-pnv-d510 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7243 -> Patchwork_15114
CI-20190529: 20190529
CI_DRM_7243: 1b175df1a7543eff5cd4dadc1589145064db5b12 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5258: c8a88b614ac057b01809a17b9e87a197195b44ad @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15114: 86547974126e2a794974fb448e5282a36c5dc067 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
86547974126e drm/i915: Program SHPD_FILTER_CNT on CNP+
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15114/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx