Skip to contentSkip to conversation

staging: wfx: fix warning of assignment of 0/1 to bool variable

PATCH In review Jules Irenge 2 participants 3 messages Nov 2, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: wfx: fix warning of assignment of 0/1 to bool variable

Fix warning of assignment of 0/1 to bool variable. Issue reported by coccinelle tool.

---
 drivers/staging/wfx/sta.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wfx/sta.c +1 -1
index 688586e823c0..ea5707ff8847 100644
@@ -291,7 +291,7 @@ u64 wfx_prepare_multicast(struct ieee80211_hw *hw, struct netdev_hw_addr_list *m
 			ether_addr_copy(wvif->mcast_filter.address_list[i], ha->addr);
 			i++;
 		}
-		wvif->mcast_filter.enable = 1;
+		wvif->mcast_filter.enable = true;
 		wvif->mcast_filter.num_addresses = count;
 	}
 
Signature · 1 line
2.21.0
#1 lore raw
Quoted 2 lines · Jules Irenge

Fix warning of assignment of 0/1 to bool variable. Issue reported by coccinelle tool.

Please fix the subject line and log message as suggested for the other patch.

julia

Quoted 27 lines
---
 drivers/staging/wfx/sta.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wfx/sta.c +1 -2
index 688586e823c0..ea5707ff8847 100644
@@ -291,7 +291,7 @@ u64 wfx_prepare_multicast(struct ieee80211_hw *hw, struct netdev_hw_addr_list *m
 			ether_addr_copy(wvif->mcast_filter.address_list[i], ha->addr);
 			i++;
 		}
-		wvif->mcast_filter.enable = 1;
+		wvif->mcast_filter.enable = true;
 		wvif->mcast_filter.num_addresses = count;
 	}
 
--

2.21.0

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191102010908.30269-1-jbi.octave%40gmail.com.

#2 lore raw
In reply to Jules Irenge
Quoted 2 lines · Jules Irenge

Fix warning of assignment of 0/1 to bool variable. Issue reported by coccinelle tool.

You seem to also have several patches with the same subject line, which is not allowed. Either describe the affected files in a more specific way or merge the patches. If you merge the patches, it would still be a v2, even if the number of patches is different.

julia

Quoted 27 lines
---
 drivers/staging/wfx/sta.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wfx/sta.c +1 -2
index 688586e823c0..ea5707ff8847 100644
@@ -291,7 +291,7 @@ u64 wfx_prepare_multicast(struct ieee80211_hw *hw, struct netdev_hw_addr_list *m
 			ether_addr_copy(wvif->mcast_filter.address_list[i], ha->addr);
 			i++;
 		}
-		wvif->mcast_filter.enable = 1;
+		wvif->mcast_filter.enable = true;
 		wvif->mcast_filter.num_addresses = count;
 	}
 
--

2.21.0

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191102010908.30269-1-jbi.octave%40gmail.com.