Skip to contentSkip to conversation

staging: wfx: fix warning of assignment of 0/1 to bool variable

PATCH In review Jules Irenge 2 participants 2 messages Nov 2, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: wfx: fix warning of assignment of 0/1 to bool variable

Fix warning of assignment of 0/1 to bool variable. Issue reported by coccinelle tool.

---
 drivers/staging/wfx/queue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wfx/queue.c +1 -1
index 5d29bce65f71..71e92744fed0 100644
@@ -550,7 +550,7 @@ struct hif_msg *wfx_tx_queues_get(struct wfx_dev *wdev)
 			spin_unlock_bh(&wvif->ps_state_lock);
 
 			if (vif_more) {
-				more = 1;
+				more = true;
 				tx_allowed_mask = vif_tx_allowed_mask;
 				queue = vif_queue;
 				ret = 0;
Signature · 1 line
2.21.0
#1 lore raw
Quoted 1 line · Jules Irenge

Fix warning of assignment of 0/1 to bool variable.

Please rewrite the log message to start with something other than fix. Explain what you did and why.

The subject line could also be more concise.

julia

Quoted 28 lines

Issue reported by coccinelle tool.

---
 drivers/staging/wfx/queue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wfx/queue.c +1 -2
index 5d29bce65f71..71e92744fed0 100644
@@ -550,7 +550,7 @@ struct hif_msg *wfx_tx_queues_get(struct wfx_dev *wdev)
 			spin_unlock_bh(&wvif->ps_state_lock);
 
 			if (vif_more) {
-				more = 1;
+				more = true;
 				tx_allowed_mask = vif_tx_allowed_mask;
 				queue = vif_queue;
 				ret = 0;
--

2.21.0

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191102011144.30586-1-jbi.octave%40gmail.com.