Skip to contentSkip to conversation

configs: Rename roc-rk3399-pc -> roc-pc-rk3399 defconfig

PATCH Superseded Jagan Teki 6 participants 6 messages Nov 2, 2019 – Nov 18, 2019 1 message not in the archive Arm Rockchip

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Jagan Teki

author
#0 lore raw

PATCH 1/1 configs: Rename roc-rk3399-pc -> roc-pc-rk3399 defconfig

roc-rk3399-pc_defconfig is committed in below

commit <8a681f4c5aa15db51ad0209734859c9fe7c29cfd> ("rockchip: rk3399:
Add ROC-RK3399-PC support")

which doesn't follow the existing defconfigs on rk3399.

So, rename as followed with other rk3399 defconfigs.

---
 board/rockchip/evb_rk3399/MAINTAINERS                        | 2 +-
 configs/{roc-rk3399-pc_defconfig => roc-pc-rk3399_defconfig} | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename configs/{roc-rk3399-pc_defconfig => roc-pc-rk3399_defconfig} (100%)
board/rockchip/evb_rk3399/MAINTAINERS +1 -1
index f8299d9460..17dfafb743 100644
@@ -52,7 +52,7 @@ F:	arch/arm/dts/rk3399-orangepi-u-boot.dtsi
 ROC-RK3399-PC
 M:	Levin Du <[email protected]>
 S:	Maintained
-F:	configs/roc-rk3399-pc_defconfig
+F:	configs/roc-pc-rk3399_defconfig
 F:	arch/arm/dts/rk3399-roc-pc-u-boot.dtsi
 
 ROCK-PI-4
configs/roc-pc-rk3399_defconfig renamed from configs/roc-rk3399-pc_defconfig +0 -0
similarity index 100%
rename from configs/roc-rk3399-pc_defconfig
rename to configs/roc-pc-rk3399_defconfig
Signature · 6 lines
2.18.0.321.gffc6fa0e3

_______________________________________________
U-Boot mailing list
[email protected]
https://lists.denx.de/listinfo/u-boot
#1 lore raw
Quoted 5 lines · Jagan Teki

roc-rk3399-pc_defconfig is committed in below

commit <8a681f4c5aa15db51ad0209734859c9fe7c29cfd> ("rockchip: rk3399:
Add ROC-RK3399-PC support")

Quoted 7 lines

which doesn't follow the existing defconfigs on rk3399.

So, rename as followed with other rk3399 defconfigs.

---

This strikes me as wrong, as the existing name is the actual name of the board.

https://libre.computer/products/boards/roc-rk3399-pc/

Jonathan Kollasch
_______________________________________________
U-Boot mailing list
[email protected]
https://lists.denx.de/listinfo/u-boot

#2 lore raw

Re: [PATCH] configs: Rename roc-rk3399-pc -> roc-pc-rk3399 defconfig【请注意,邮件由[email protected]代发】

The mainline uses 'rk3399-*', so there're rk3399-firefly.dts, rk3399-roc-pc.dts, rk3399-khadas-edge.dts, etc. Shall we follow the kernel convention, or add another roc-pc-rk3399 to the matrix? I prefer to keep it as it is.

Quoted 25 lines · Jonathan A. Kollasch
Quoted 6 lines · Jagan Teki

roc-rk3399-pc_defconfig is committed in below

commit <8a681f4c5aa15db51ad0209734859c9fe7c29cfd> ("rockchip: rk3399:

Add ROC-RK3399-PC support")

Quoted 7 lines

which doesn't follow the existing defconfigs on rk3399.

So, rename as followed with other rk3399 defconfigs.

---

This strikes me as wrong, as the existing name is the actual name of the board.

https://libre.computer/products/boards/roc-rk3399-pc/

Jonathan Kollasch
_______________________________________________
U-Boot mailing list
[email protected]
https://lists.denx.de/listinfo/u-boot

Signature · 7 lines
Levin Du


_______________________________________________
U-Boot mailing list
[email protected]
https://lists.denx.de/listinfo/u-boot
Reviewed-by on v1 1/1
#4 lore raw

Re: [PATCH] configs: Rename roc-rk3399-pc -> roc-pc-rk3399 defconfig【请注意,邮件由linux-rockchip-bounces+kever.yang=rock-chips.com@lists.infradead.org代发】

In reply to Jagan Teki
Quoted 11 lines · Jagan Teki

roc-rk3399-pc_defconfig is committed in below

commit <8a681f4c5aa15db51ad0209734859c9fe7c29cfd> ("rockchip: rk3399:
Add ROC-RK3399-PC support")

which doesn't follow the existing defconfigs on rk3399.

So, rename as followed with other rk3399 defconfigs.

The board name is roc-rk3399-pc, but we do update this in dts as {soc}-{board}.dts

and {board}-{soc}_defconfig  for all boards already have, so

Thanks,
- Kever

configs/roc-pc-rk3399_defconfig

Quoted 23 lines
---
  board/rockchip/evb_rk3399/MAINTAINERS                        | 2 +-
  configs/{roc-rk3399-pc_defconfig => roc-pc-rk3399_defconfig} | 0
  2 files changed, 1 insertion(+), 1 deletion(-)

rename configs/{roc-rk3399-pc_defconfig => roc-pc-rk3399_defconfig} (100%)

board/rockchip/evb_rk3399/MAINTAINERS +1 -1
index f8299d9460..17dfafb743 100644
@@ -52,7 +52,7 @@ F:	arch/arm/dts/rk3399-orangepi-u-boot.dtsi
  ROC-RK3399-PC
  M:	Levin Du <[email protected]>
  S:	Maintained
-F:	configs/roc-rk3399-pc_defconfig
+F:	configs/roc-pc-rk3399_defconfig
  F:	arch/arm/dts/rk3399-roc-pc-u-boot.dtsi
 
  ROCK-PI-4
configs/roc-pc-rk3399_defconfig renamed from configs/roc-rk3399-pc_defconfig +0 -0
similarity index 100%
rename from configs/roc-rk3399-pc_defconfig
rename to configs/roc-pc-rk3399_defconfig

_______________________________________________
U-Boot mailing list
[email protected]
https://lists.denx.de/listinfo/u-boot

A message that is not in the archive (sent off-list or not yet received): fd21fa79-142f-00b9-f3df-8dc43372cb20-TNX95d0MmH7DzftRWevZcw@public.gmane.org

#6 lore raw

Re: [PATCH] configs: Rename roc-rk3399-pc -> roc-pc-rk3399 defconfig【请注意,邮件由linux-rockchip-bounces+kever.yang=rock-chips.com@lists.infradead.org代发】

Quoted 15 lines · Kever Yang
Quoted 11 lines · Jagan Teki

roc-rk3399-pc_defconfig is committed in below

commit <8a681f4c5aa15db51ad0209734859c9fe7c29cfd> ("rockchip: rk3399:
Add ROC-RK3399-PC support")

which doesn't follow the existing defconfigs on rk3399.

So, rename as followed with other rk3399 defconfigs.

Quoted 6 lines

The board name is roc-rk3399-pc, but we do update this in dts as {soc}-{board}.dts

and {board}-{soc}_defconfig  for all boards already have, so

Applied to u-boot-rockchip master.

Thanks,
- Kever

Quoted 24 lines

Thanks,
- Kever

Quoted 21 lines

---
  board/rockchip/evb_rk3399/MAINTAINERS                        | 2 +- configs/{roc-rk3399-pc_defconfig => roc-pc-rk3399_defconfig} | 0

  2 files changed, 1 insertion(+), 1 deletion(-)

  rename configs/{roc-rk3399-pc_defconfig => roc-pc-rk3399_defconfig} (100%)

board/rockchip/evb_rk3399/MAINTAINERS +0 -0
index f8299d9460..17dfafb743 100644
@@ -52,7 +52,7 @@ F:    arch/arm/dts/rk3399-orangepi-u-boot.dtsi

  ROC-RK3399-PC
  M:    Levin Du <[email protected]>
  S:    Maintained

board/rockchip/evb_rk3399/MAINTAINERS +1 -1
-F:    configs/roc-rk3399-pc_defconfig
+F:    configs/roc-pc-rk3399_defconfig

  F:    arch/arm/dts/rk3399-roc-pc-u-boot.dtsi
    ROCK-PI-4

configs/roc-pc-rk3399_defconfig renamed from configs/roc-rk3399-pc_defconfig +0 -0
similarity index 100%
rename from configs/roc-rk3399-pc_defconfig
Quoted 8 lines
Quoted 1 line

rename to configs/roc-pc-rk3399_defconfig

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip