Skip to contentSkip to conversation

Makefile: install bios-microvm like other binary blobs

PATCH Applied Philippe Mathieu-Daudé 4 participants 4 messages Nov 2, 2019 – Nov 12, 2019 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Makefile: install bios-microvm like other binary blobs

From: Bruce Rogers <[email protected]>

Commit 0d5fae3e52e introduced bios-microvm.bin but forgot to add it to the list of blobs being installed.
Add it to the list of BLOBS that get installed.

Fixes 0d5fae3e52e "roms: add microvm-bios (qboot) as binary"
[PMD: Reworded description]
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index bd6376d295..755aa6c5f5 100644
@@ -770,7 +770,7 @@ de-ch  es     fo  fr-ca  hu     ja  mk  pt  sl     tr \
 bepo    cz
 
 ifdef INSTALL_BLOBS
-BLOBS=bios.bin bios-256k.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \
+BLOBS=bios.bin bios-256k.bin bios-microvm.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \
 vgabios-stdvga.bin vgabios-vmware.bin vgabios-qxl.bin vgabios-virtio.bin \
 vgabios-ramfb.bin vgabios-bochs-display.bin vgabios-ati.bin \
 ppc_rom.bin openbios-sparc32 openbios-sparc64 openbios-ppc QEMU,tcx.bin QEMU,cgthree.bin \
Signature · 1 line
2.21.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Philippe Mathieu-Daudé

From: Bruce Rogers <[email protected]>

Commit 0d5fae3e52e introduced bios-microvm.bin but forgot to add it to the list of blobs being installed.
Add it to the list of BLOBS that get installed.

Quoted 7 lines
Fixes 0d5fae3e52e "roms: add microvm-bios (qboot) as binary"
[PMD: Reworded description]
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

The patch LGTM:

Thanks,
Stefano

Quoted 17 lines
Makefile +1 -2
index bd6376d295..755aa6c5f5 100644
@@ -770,7 +770,7 @@ de-ch  es     fo  fr-ca  hu     ja  mk  pt  sl     tr \
 bepo    cz
 
 ifdef INSTALL_BLOBS
-BLOBS=bios.bin bios-256k.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \
+BLOBS=bios.bin bios-256k.bin bios-microvm.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \
 vgabios-stdvga.bin vgabios-vmware.bin vgabios-qxl.bin vgabios-virtio.bin \
 vgabios-ramfb.bin vgabios-bochs-display.bin vgabios-ati.bin \
 ppc_rom.bin openbios-sparc32 openbios-sparc64 openbios-ppc QEMU,tcx.bin QEMU,cgthree.bin \
--

2.21.0

Reviewed-by on v1 1/1
#2 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 19 lines · Philippe Mathieu-Daudé

From: Bruce Rogers <[email protected]>

Commit 0d5fae3e52e introduced bios-microvm.bin but forgot to add it to the list of blobs being installed.
Add it to the list of BLOBS that get installed.

Fixes 0d5fae3e52e "roms: add microvm-bios (qboot) as binary"
[PMD: Reworded description]
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +0 -0
index bd6376d295..755aa6c5f5 100644

Makefile de-ch es fo fr-ca hu ja mk pt sl tr \ · line 776

Quoted 8 lines
Makefile +1 -1
@@ -770,7 +770,7 @@ de-ch  es     fo  fr-ca  hu     ja  mk  pt  sl     tr \
 bepo    cz
 
 ifdef INSTALL_BLOBS
-BLOBS=bios.bin bios-256k.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \
+BLOBS=bios.bin bios-256k.bin bios-microvm.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \
 vgabios-stdvga.bin vgabios-vmware.bin vgabios-qxl.bin vgabios-virtio.bin \
 vgabios-ramfb.bin vgabios-bochs-display.bin vgabios-ati.bin \
 ppc_rom.bin openbios-sparc32 openbios-sparc64 openbios-ppc QEMU,tcx.bin QEMU,cgthree.bin \

Thanks.

#3 lore raw
In reply to Philippe Mathieu-Daudé

Le 02/11/2019 à 12:43, Philippe Mathieu-Daudé a écrit :

Quoted 20 lines

From: Bruce Rogers <[email protected]>

Commit 0d5fae3e52e introduced bios-microvm.bin but forgot to add it to the list of blobs being installed.
Add it to the list of BLOBS that get installed.

Fixes 0d5fae3e52e "roms: add microvm-bios (qboot) as binary"
[PMD: Reworded description]
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +0 -0
index bd6376d295..755aa6c5f5 100644

Makefile de-ch es fo fr-ca hu ja mk pt sl tr \ · line 776

Quoted 8 lines
Makefile +1 -1
@@ -770,7 +770,7 @@ de-ch  es     fo  fr-ca  hu     ja  mk  pt  sl     tr \
 bepo    cz
 
 ifdef INSTALL_BLOBS
-BLOBS=bios.bin bios-256k.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \
+BLOBS=bios.bin bios-256k.bin bios-microvm.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \
 vgabios-stdvga.bin vgabios-vmware.bin vgabios-qxl.bin vgabios-virtio.bin \
 vgabios-ramfb.bin vgabios-bochs-display.bin vgabios-ati.bin \
 ppc_rom.bin openbios-sparc32 openbios-sparc64 openbios-ppc QEMU,tcx.bin QEMU,cgthree.bin \

Applied to my trivial-patches branch.

Thanks,
Laurent