Skip to contentSkip to conversation

package/dtc: do not install headers for the target version

PATCH New unixmania at gmail.com 2 participants 2 messages Nov 2, 2019 – Nov 3, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/dtc: do not install headers for the target version

From: Carlos Santos <[email protected]>

They are not required on the target and installing them is just a waste of time.

---
 package/dtc/dtc.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/dtc/dtc.mk +1 -1
index 35ac0b332b..1e5ab992a6 100644
@@ -37,7 +37,7 @@ endef
 ifeq ($(BR2_PACKAGE_DTC_PROGRAMS),y)
 
 DTC_LICENSE += , GPL-2.0+ (programs)
-DTC_INSTALL_GOAL = install
+DTC_INSTALL_GOAL = install-bin install-lib
 ifeq ($(BR2_PACKAGE_BASH),)
 DTC_POST_INSTALL_TARGET_HOOKS += DTC_POST_INSTALL_TARGET_RM_DTDIFF
 endif
Signature · 1 line
2.18.1
#1 lore raw

PATCH 1/1 package/dtc: do not install headers for the target version

Carlos, All,

On 2019-11-02 09:30 -0300, unixmania at gmail.com spake thusly:

Quoted 3 lines

From: Carlos Santos <[email protected]>

They are not required on the targeti

Which is why we have them already trashed away as part of the generic target-finalize step.:

    Makefile:
    741     rm -rf $(TARGET_DIR)/usr/include [...]
Quoted 2 lines

and installing them is just a waste
of time.

Before the patch, dtc takes 1.5s. After the patch, it takes 1.5s. I haven't noticed any meaningful improvement.

The only interesting reason to go that route would have been something along the lines of:

    DTC_INSTALL_GOAL = install-lib

    ifeq ($(BR2_PACKAGE_DTC_PROGRAMS),y)
    DTC_INSTALL_GOAL += install-bin
    [...]
    endif

But even then, I don't see the point (even since check-package does not report the variable as being assigned twice, as it is in a conditional).

Regards,
Yann E. MORIN.

Quoted 25 lines
---
 package/dtc/dtc.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/dtc/dtc.mk +1 -1
index 35ac0b332b..1e5ab992a6 100644
@@ -37,7 +37,7 @@ endef
 ifeq ($(BR2_PACKAGE_DTC_PROGRAMS),y)
 
 DTC_LICENSE += , GPL-2.0+ (programs)
-DTC_INSTALL_GOAL = install
+DTC_INSTALL_GOAL = install-bin install-lib
 ifeq ($(BR2_PACKAGE_BASH),)
 DTC_POST_INSTALL_TARGET_HOOKS += DTC_POST_INSTALL_TARGET_RM_DTDIFF
 endif
Signature · 6 lines
2.18.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'