staging: wfx: cleanups
v3 cover staging: wfx: cleanups
Jules Irenge (2):
staging: wfx: replace 0 by NULL as the return value of a
pointer-returning function
staging: wfx: replace 1 by true when stored in a boolean variable
drivers/staging/wfx/queue.c | 4 ++-- drivers/staging/wfx/sta.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
Signature · 1 line
2.21.0
PATCH v3 1/2 staging: wfx: replace 0 by NULL as the return value of a pointer-returning function
Replace 0 by NULL as the return value of a pointer-returning function. Issue detected by sparse tool.
--- drivers/staging/wfx/queue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wfx/queue.c +1 -1
@@ -565,7 +565,7 @@ struct hif_msg *wfx_tx_queues_get(struct wfx_dev *wdev) }if (ret) -return 0 ; +return NULL ; queue_num = queue - wdev->tx_queue;
Signature · 1 line
2.21.0
Greg KH
maintainerRe: [PATCH v3 1/2] staging: wfx: replace 0 by NULL as the return value of a pointer-returning function
Quoted 7 lines · Jules Irenge
Replace 0 by NULL as the return value of a pointer-returning function. Issue detected by sparse tool.
Signed-off-by Jules Irenge <[email protected]>--- drivers/staging/wfx/queue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
What changed from v1 and v2?
Always put that below the --- line.
Please fix up and send a v4 series.
thanks,
greg k-h
PATCH v3 2/2 staging: wfx: replace 1 by true when stored in a boolean variable
In reply to Jules IrengeReplace 1 by true when it is stored in a boolean variable. Recommended by coccinelle tool.
--- drivers/staging/wfx/queue.c | 2 +- drivers/staging/wfx/sta.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/wfx/queue.c +1 -1
@@ -550,7 +550,7 @@ struct hif_msg *wfx_tx_queues_get(struct wfx_dev *wdev)spin_unlock_bh (&wvif->ps_state_lock);if (vif_more) { - more =1 ; + more = true; tx_allowed_mask = vif_tx_allowed_mask; queue = vif_queue; ret =0 ;
drivers/staging/wfx/sta.c +1 -1
@@ -291,7 +291,7 @@ u64 wfx_prepare_multicast(struct ieee80211_hw *hw, struct netdev_hw_addr_list *mether_addr_copy (wvif->mcast_filter.address_list[i], ha->addr); i++; } - wvif->mcast_filter.enable =1 ; + wvif->mcast_filter.enable = true; wvif->mcast_filter.num_addresses = count; }
Signature · 1 line
2.21.0