drm/i915: update rawclk also on resume
Subsystems (3)
PATCH v2 1/1 drm/i915: update rawclk also on resume
Since CNP it's possible for rawclk to have two different values, 19.2 and 24 MHz. If the value indicated by SFUSE_STRAP register is different from the power on default for PCH_RAWCLK_FREQ, we'll end up having a mismatch between the rawclk hardware and software states after suspend/resume. On previous platforms this used to work by accident, because the power on defaults worked just fine.
Update the rawclk also on resume. The natural place to do this would be intel_modeset_init_hw(), however VLV/CHV need it done before intel_power_domains_init_hw(). Thus put it there even if it feels slightly out of place.
v2: Call intel_update_rawclck() in intel_power_domains_init_hw() for all
platforms (Ville).
--- drivers/gpu/drm/i915/display/intel_display_power.c | 3 +++ drivers/gpu/drm/i915/i915_drv.c | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power.c +3 -0
@@ -5015,6 +5015,9 @@ void intel_power_domains_init_hw(struct drm_i915_private *i915, bool resume) power_domains->initializing = true; +/* Must happen before power domain init on VLV/CHV */ +intel_update_rawclk (i915); +if (INTEL_GEN (i915) >=11 ) {icl_display_core_init (i915, resume); }else if (IS_CANNONLAKE (i915)) {
drivers/gpu/drm/i915/i915_drv.c +0 -3
@@ -296,9 +296,6 @@ static int i915_driver_modeset_probe(struct drm_i915_private *i915)if (ret) goto cleanup_vga_client; -/* must happen before intel_power_domains_init_hw() on VLV/CHV */ -intel_update_rawclk (i915); -intel_power_domains_init_hw (i915, false);intel_csr_ucode_init (i915);
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: update rawclk also on resume (rev4)
== Series Details ==
== Series Details ==
Series: drm/i915: update rawclk also on resume (rev4)
URL : https://patchwork.freedesktop.org/series/68817/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7242 -> Patchwork_15110
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/index.html
Known issues
------------
Here are the changes found in Patchwork_15110 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_mmap_gtt@basic-short:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/fi-icl-u3/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/fi-icl-u3/igt@[email protected]
* igt@i915_selftest@live_gem_contexts:
- fi-icl-u2: [PASS][3] -> [INCOMPLETE][4] ([fdo#107713])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/fi-icl-u2/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/fi-icl-u2/igt@i915_selftest@live_gem_contexts.html
* igt@kms_flip@basic-flip-vs-wf_vblank:
- fi-blb-e6850: [PASS][5] -> [FAIL][6] ([fdo#100368])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/fi-blb-e6850/igt@kms_flip@basic-flip-vs-wf_vblank.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/fi-blb-e6850/igt@kms_flip@basic-flip-vs-wf_vblank.html
#### Possible fixes ####
* igt@gem_ctx_switch@rcs0:
- {fi-icl-y}: [INCOMPLETE][7] ([fdo#107713]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/fi-icl-y/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/fi-icl-y/igt@[email protected]
* igt@gem_sync@basic-many-each:
- {fi-tgl-u}: [INCOMPLETE][9] ([fdo#111880] / [fdo#111998]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/fi-tgl-u/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/fi-tgl-u/igt@[email protected]
* igt@prime_vgem@basic-fence-flip:
- fi-icl-u3: [DMESG-WARN][11] ([fdo#107724]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/fi-icl-u3/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/fi-icl-u3/igt@[email protected]
#### Warnings ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][13] ([fdo#111407]) -> [FAIL][14] ([fdo#111045] / [fdo#111096])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/fi-kbl-7500u/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/fi-kbl-7500u/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111880]: https://bugs.freedesktop.org/show_bug.cgi?id=111880
[fdo#111998]: https://bugs.freedesktop.org/show_bug.cgi?id=111998
Participating hosts (51 -> 44)
------------------------------
Additional (1): fi-skl-6600u
Missing (8): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-bwr-2160 fi-ctg-p8600 fi-gdg-551 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7242 -> Patchwork_15110
CI-20190529: 20190529
CI_DRM_7242: 6cc1e34e4202cb6cfd4994e37414a34939eae4a3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5258: c8a88b614ac057b01809a17b9e87a197195b44ad @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15110: 8c459ea52e0957dd99e0d49736a36de452c5051f @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
8c459ea52e09 drm/i915: update rawclk also on resume
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915: update rawclk also on resume (rev4)
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915: update rawclk also on resume (rev4)
URL : https://patchwork.freedesktop.org/series/68817/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7242_full -> Patchwork_15110_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15110_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render:
- {shard-tglb}: [PASS][1] -> [INCOMPLETE][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-tglb3/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-tglb5/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render.html
* igt@kms_rotation_crc@multiplane-rotation:
- {shard-tglb}: NOTRUN -> [FAIL][3] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-tglb2/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_15110_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@vcs1-clean:
- shard-iclb: [PASS][4] -> [SKIP][5] ([fdo#109276] / [fdo#112080]) +2 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb1/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-iclb3/igt@[email protected]
* igt@gem_exec_schedule@independent-bsd2:
- shard-iclb: [PASS][6] -> [SKIP][7] ([fdo#109276]) +15 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb1/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-iclb7/igt@[email protected]
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [PASS][8] -> [SKIP][9] ([fdo#112146]) +5 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb5/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-iclb2/igt@[email protected]
* igt@gem_persistent_relocs@forked-thrashing:
- shard-skl: [PASS][10] -> [DMESG-WARN][11] ([fdo#111626])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-skl4/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-skl2/igt@[email protected]
* igt@gem_softpin@noreloc-s3:
- shard-apl: [PASS][12] -> [DMESG-WARN][13] ([fdo#108566]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-apl4/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-apl6/igt@[email protected]
- shard-skl: [PASS][14] -> [INCOMPLETE][15] ([fdo#104108]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-skl9/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-skl7/igt@[email protected]
* igt@gem_userptr_blits@sync-unmap:
- shard-snb: [PASS][16] -> [DMESG-WARN][17] ([fdo#111870])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-snb1/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-snb6/igt@[email protected]
* igt@gem_userptr_blits@sync-unmap-after-close:
- shard-hsw: [PASS][18] -> [DMESG-WARN][19] ([fdo#111870])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-hsw1/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-hsw4/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt:
- shard-iclb: [PASS][20] -> [FAIL][21] ([fdo#103167]) +4 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb2/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-iclb6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][22] -> [DMESG-WARN][23] ([fdo#108566]) +7 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-kbl3/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-kbl3/igt@[email protected]
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][24] -> [FAIL][25] ([fdo#103166])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb8/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-iclb1/igt@[email protected]
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][26] -> [SKIP][27] ([fdo#109441]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-iclb6/igt@kms_psr@psr2_sprite_plane_move.html
* igt@perf_pmu@busy-no-semaphores-vcs1:
- shard-iclb: [PASS][28] -> [SKIP][29] ([fdo#112080]) +8 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb4/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-iclb6/igt@[email protected]
#### Possible fixes ####
* igt@gem_ctx_exec@basic-invalid-context-vcs1:
- shard-iclb: [SKIP][30] ([fdo#112080]) -> [PASS][31] +13 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb7/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-iclb1/igt@[email protected]
* igt@gem_ctx_isolation@bcs0-s3:
- {shard-tglb}: [INCOMPLETE][32] ([fdo#111832]) -> [PASS][33] +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-tglb2/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-tglb5/igt@[email protected]
* igt@gem_ctx_isolation@vecs0-reset:
- {shard-tglb}: [TIMEOUT][34] ([fdo#112126]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-tglb5/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-tglb4/igt@[email protected]
* {igt@gem_ctx_persistence@vcs1-queued}:
- shard-iclb: [SKIP][36] ([fdo#109276] / [fdo#112080]) -> [PASS][37] +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb5/igt@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-iclb2/igt@[email protected]
* igt@gem_ctx_switch@queue-light:
- {shard-tglb}: [INCOMPLETE][38] ([fdo#111672]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-tglb6/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-tglb4/igt@[email protected]
* igt@gem_eio@in-flight-suspend:
- {shard-tglb}: [INCOMPLETE][40] ([fdo#111832] / [fdo#111850] / [fdo#112081]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-tglb2/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-tglb6/igt@[email protected]
* igt@gem_eio@unwedge-stress:
- shard-snb: [FAIL][42] ([fdo#109661]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-snb5/igt@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-snb1/igt@[email protected]
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][44] ([fdo#110854]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb3/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-iclb4/igt@[email protected]
* igt@gem_exec_schedule@wide-bsd:
- shard-iclb: [SKIP][46] ([fdo#112146]) -> [PASS][47] +10 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb1/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-iclb5/igt@[email protected]
* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-iclb: [TIMEOUT][48] ([fdo#112068 ]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb3/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-iclb8/igt@[email protected]
* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
- shard-snb: [FAIL][50] ([fdo#112037]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-snb5/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-snb4/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-hsw: [DMESG-WARN][52] ([fdo#111870]) -> [PASS][53] +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-hsw2/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-hsw6/igt@[email protected]
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-snb: [DMESG-WARN][54] ([fdo#111870]) -> [PASS][55] +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-snb7/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-snb6/igt@[email protected]
* igt@i915_selftest@mock_requests:
- shard-skl: [INCOMPLETE][56] -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-skl8/igt@i915_selftest@mock_requests.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-skl4/igt@i915_selftest@mock_requests.html
* igt@i915_suspend@debugfs-reader:
- {shard-tglb}: [INCOMPLETE][58] ([fdo#111850]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-tglb8/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-tglb2/igt@[email protected]
* igt@i915_suspend@fence-restore-tiled2untiled:
- {shard-tglb}: [INCOMPLETE][60] ([fdo#111832] / [fdo#111850]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-tglb1/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-tglb8/igt@[email protected]
* igt@i915_suspend@sysfs-reader:
- shard-apl: [DMESG-WARN][62] ([fdo#108566]) -> [PASS][63] +5 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-apl6/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-apl8/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
- shard-iclb: [FAIL][64] ([fdo#103167]) -> [PASS][65] +2 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render:
- {shard-tglb}: [FAIL][66] ([fdo#103167]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render.html
* igt@kms_lease@setcrtc_implicit_plane:
- {shard-tglb}: [TIMEOUT][68] ([fdo#112168]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-tglb5/igt@kms_lease@setcrtc_implicit_plane.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-tglb4/igt@kms_lease@setcrtc_implicit_plane.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-kbl: [DMESG-FAIL][70] ([fdo#103375] / [fdo#108566]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-kbl2/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-kbl3/igt@[email protected]
* igt@kms_psr@psr2_basic:
- shard-iclb: [SKIP][72] ([fdo#109441]) -> [PASS][73] +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb5/igt@kms_psr@psr2_basic.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-iclb2/igt@kms_psr@psr2_basic.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][74] ([fdo#108566]) -> [PASS][75] +4 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-kbl3/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-kbl3/igt@[email protected]
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][76] ([fdo#109276]) -> [PASS][77] +11 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb5/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-iclb2/igt@[email protected]
* igt@tools_test@tools_test:
- shard-apl: [SKIP][78] ([fdo#109271]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-apl4/igt@tools_test@tools_test.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-apl4/igt@tools_test@tools_test.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [FAIL][80] ([fdo#111329]) -> [SKIP][81] ([fdo#109276] / [fdo#112080])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb4/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-iclb5/igt@[email protected]
* igt@gem_mocs_settings@mocs-reset-bsd2:
- shard-iclb: [SKIP][82] ([fdo#109276]) -> [FAIL][83] ([fdo#111330]) +2 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb5/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-iclb2/igt@[email protected]
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-hsw: [DMESG-WARN][84] ([fdo#111870]) -> [DMESG-WARN][85] ([fdo#110789] / [fdo#111870])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-hsw1/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-hsw6/igt@[email protected]
* igt@kms_color@pipe-b-ctm-0-75:
- shard-iclb: [FAIL][86] ([fdo#110920]) -> [INCOMPLETE][87] ([fdo#107713])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb3/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-iclb7/igt@[email protected]
* igt@kms_flip@flip-vs-suspend:
- shard-kbl: [DMESG-WARN][88] ([fdo#108566]) -> [DMESG-WARN][89] ([fdo#108566] / [fdo#111538])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-kbl2/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/shard-kbl7/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#110920]: https://bugs.freedesktop.org/show_bug.cgi?id=110920
[fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
[fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
[fdo#111538]: https://bugs.freedesktop.org/show_bug.cgi?id=111538
[fdo#111626]: https://bugs.freedesktop.org/show_bug.cgi?id=111626
[fdo#111646]: https://bugs.freedesktop.org/show_bug.cgi?id=111646
[fdo#111647]: https://bugs.freedesktop.org/show_bug.cgi?id=111647
[fdo#111671]: https://bugs.freedesktop.org/show_bug.cgi?id=111671
[fdo#111672]: https://bugs.freedesktop.org/show_bug.cgi?id=111672
[fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
[fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747
[fdo#111827 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
[fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#111884]: https://bugs.freedesktop.org/show_bug.cgi?id=111884
[fdo#112037]: https://bugs.freedesktop.org/show_bug.cgi?id=112037
[fdo#112068 ]: https://bugs.freedesktop.org/show_bug.cgi?id=112068
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112081]: https://bugs.freedesktop.org/show_bug.cgi?id=112081
[fdo#112126]: https://bugs.freedesktop.org/show_bug.cgi?id=112126
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#112168]: https://bugs.freedesktop.org/show_bug.cgi?id=112168
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7242 -> Patchwork_15110
CI-20190529: 20190529
CI_DRM_7242: 6cc1e34e4202cb6cfd4994e37414a34
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15110/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 12 lines · Jani Nikula
Since CNP it's possible for rawclk to have two different values, 19.2 and 24 MHz. If the value indicated by
SFUSE_STRAPregister is different from the power on default forPCH_RAWCLK_FREQ, we'll end up having a mismatch between the rawclk hardware and software states after suspend/resume. On previous platforms this used to work by accident, because the power on defaults worked just fine.Update the rawclk also on resume. The natural place to do this would be
intel_modeset_init_hw(), however VLV/CHV need it done beforeintel_power_domains_init_hw(). Thus put it there even if it feels slightly out of place.
Quoted 7 lines
v2: Call
intel_update_rawclck()inintel_power_domains_init_hw()for all
platforms (Ville).Reported-by Shawn Lee <[email protected]>Cc Shawn Lee <[email protected]>Cc Ville Syrjala <[email protected]>Signed-off-by Jani Nikula <[email protected]>
Quoted 35 lines
--- drivers/gpu/drm/i915/display/intel_display_power.c | 3 +++ drivers/gpu/drm/i915/i915_drv.c | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/display/intel_display_power.c +3
-0@@ -5015,6 +5015,9 @@ void intel_power_domains_init_hw(struct drm_i915_private *i915, bool resume) power_domains->initializing = true; +/* Must happen before power domain init on VLV/CHV */ +intel_update_rawclk (i915); +if (INTEL_GEN (i915) >=11 ) {icl_display_core_init (i915, resume); }else if (IS_CANNONLAKE (i915)) {drivers/gpu/drm/i915/i915_drv.c +0
-3@@ -296,9 +296,6 @@ static int i915_driver_modeset_probe(struct drm_i915_private *i915)if (ret) goto cleanup_vga_client; -/* must happen before intel_power_domains_init_hw() on VLV/CHV */ -intel_update_rawclk (i915); -intel_power_domains_init_hw (i915, false);intel_csr_ucode_init (i915);Signature · 1 line
2.20.1
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 16 lines · Ville Syrjälä
Quoted 15 lines · Jani Nikula
Since CNP it's possible for rawclk to have two different values, 19.2 and 24 MHz. If the value indicated by
SFUSE_STRAPregister is different from the power on default forPCH_RAWCLK_FREQ, we'll end up having a mismatch between the rawclk hardware and software states after suspend/resume. On previous platforms this used to work by accident, because the power on defaults worked just fine.Update the rawclk also on resume. The natural place to do this would be
intel_modeset_init_hw(), however VLV/CHV need it done beforeintel_power_domains_init_hw(). Thus put it there even if it feels slightly out of place.v2: Call
intel_update_rawclck()inintel_power_domains_init_hw()for all
platforms (Ville).
Quoted 6 lines
Quoted 4 lines
Reported-by Shawn Lee <[email protected]>Cc Shawn Lee <[email protected]>Cc Ville Syrjala <[email protected]>Signed-off-by Jani Nikula <[email protected]>Reviewed-by Ville Syrjälä <[email protected]>
Thanks for the testing and review, pushed to dinq.
BR,
Jani.
Quoted 36 lines
Quoted 36 lines
--- drivers/gpu/drm/i915/display/intel_display_power.c | 3 +++ drivers/gpu/drm/i915/i915_drv.c | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/display/intel_display_power.c +3
-0@@ -5015,6 +5015,9 @@ void intel_power_domains_init_hw(struct drm_i915_private *i915, bool resume) power_domains->initializing = true; +/* Must happen before power domain init on VLV/CHV */ +intel_update_rawclk (i915); +if (INTEL_GEN (i915) >=11 ) {icl_display_core_init (i915, resume); }else if (IS_CANNONLAKE (i915)) {drivers/gpu/drm/i915/i915_drv.c +0
-3@@ -296,9 +296,6 @@ static int i915_driver_modeset_probe(struct drm_i915_private *i915)if (ret) goto cleanup_vga_client; -/* must happen before intel_power_domains_init_hw() on VLV/CHV */ -intel_update_rawclk (i915); -intel_power_domains_init_hw (i915, false);intel_csr_ucode_init (i915);Signature · 1 line
2.20.1
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx