Skip to contentSkip to conversation

drivers/staging/exfat: Ensure we unlock upon error in ffsReadFile

PATCH In review Davidlohr Bueso 2 participants 2 messages Nov 3, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/staging/exfat: Ensure we unlock upon error in ffsReadFile

The call was not releasing the mutex upon error.

---
 drivers/staging/exfat/exfat_super.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/exfat/exfat_super.c +4 -2
index e9e9868cae85..02dcfe06fc4f 100644
@@ -742,8 +742,10 @@ static int ffsReadFile(struct inode *inode, struct file_id_t *fid, void *buffer,
 
 			while (clu_offset > 0) {
 				/* clu = FAT_read(sb, clu); */
-				if (FAT_read(sb, clu, &clu) == -1)
-					return FFS_MEDIAERR;
+				if (FAT_read(sb, clu, &clu) == -1) {
+					ret = FFS_MEDIAERR;
+					goto out;
+				}
 
 				clu_offset--;
 			}
Signature · 1 line
2.16.4