Coverity: pn532_dev_up(): Error handling issues
Hello!
This is an experimental automated report about issues detected by Coverity from a scan of next-20191031 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified lines of code (noted below) that were touched by recent commits:
c656aa4c27b1 ("nfc: pn533: add UART phy driver")
Coverity reported the following:
*** CID 1487395: Error handling issues (CHECKED_RETURN) /drivers/nfc/pn533/uart.c: 107 in pn532_dev_up()
101 }
102
103 static void pn532_dev_up(struct pn533 *dev)
104 {
105 struct pn532_uart_phy *pn532 = dev->phy;
106
vvv CID 1487395: Error handling issues (CHECKED_RETURN)
vvv Calling "serdev_device_open" without checking return value (as is done elsewhere 10 out of 11 times).
107 serdev_device_open(pn532->serdev);
108 pn532->send_wakeup = PN532_SEND_LAST_WAKEUP;
109 }110
111 static void pn532_dev_down(struct pn533 *dev)
112 {
If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first):
Addresses-Coverity-ID: 1487395 ("Error handling issues")
Thanks for your attention!
Signature · 1 line
Coverity-bot