package/rng-tools: needs NPTL
PATCH 1/1 package/rng-tools: needs NPTL
Fixes:
http://autobuild.buildroot.net/results/e18/e1815b96997fb7def688e0aeb5d342fc64dbb64d/
--- package/rng-tools/Config.in | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
package/rng-tools/Config.in +4 -3
@@ -1,7 +1,8 @@ config BR2_PACKAGE_RNG_TOOLS bool "rng-tools" depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS || !(BR2_i386 || BR2_x86_64 || BR2_powerpc64le) # libgcrypt - depends on BR2_TOOLCHAIN_HAS_THREADS + # pthread_setaffinity_np + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL select BR2_PACKAGE_JITTERENTROPY_LIBRARY # For rdrand & darn ligcrypt is required and it's not obvious to users
@@ -12,5 +13,5 @@ config BR2_PACKAGE_RNG_TOOLS http://sourceforge.net/projects/gkernel/ -comment "rng-tools needs a toolchain w/ threads" - depends on !BR2_TOOLCHAIN_HAS_THREADS +comment "rng-tools needs a toolchain w/ NPTL" + depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
Signature · 1 line
2.20.1
PATCH 1/1 package/rng-tools: needs NPTL
Bernd,
Quoted 5 lines · Bernd Kuhls
Fixes:
http://autobuild.buildroot.net/results/e18/e1815b96997fb7def688e0aeb5d342fc64dbb64d/Signed-off-by Bernd Kuhls <[email protected]>
$ ./utils/check-package package/rng-tools/* 99 lines processed 0 warnings generated
PATCH 1/1 package/rng-tools: needs NPTL
Bernd,
Quoted 9 lines · Matthew Weber
Bernd,
Quoted 4 lines · Bernd Kuhls
Fixes:
http://autobuild.buildroot.net/results/e18/e1815b96997fb7def688e0aeb5d342fc64dbb64d/
Quoted 7 lines
Quoted 1 line
Signed-off-by Bernd Kuhls <[email protected]>$ ./utils/check-package package/rng-tools/* 99 lines processed 0 warnings generatedReviewed-by Matt Weber <[email protected]>
Looks like the next thread related build failure will be musl related.
./utils/test-pkg -p rng-tools -d testbuild
br-arm-full [1/6]: OK
br-arm-cortex-a9-glibc [2/6]: OK
br-arm-cortex-m4-full [3/6]: SKIPPED
br-x86-64-musl [4/6]: FAILED
br-arm-full-static [5/6]: OK
sourcery-arm [6/6]: OKrngd_jitter.c:(.text+0x7da): undefined reference to `pthread_yield'
PATCH 1/1 package/rng-tools: needs NPTL
Quoted 32 lines · Matthew Weber
Bernd,
Quoted 9 lines · Matthew Weber
Bernd,
Quoted 4 lines · Bernd Kuhls
Fixes:
http://autobuild.buildroot.net/results/e18/e1815b96997fb7def688e0aeb5d342fc64dbb64d/Quoted 7 lines
Quoted 1 line
Signed-off-by Bernd Kuhls <[email protected]>$ ./utils/check-package package/rng-tools/* 99 lines processed 0 warnings generatedReviewed-by Matt Weber <[email protected]>Looks like the next thread related build failure will be musl related.
./utils/test-pkg -p rng-tools -d testbuild
br-arm-full [1/6]: OK br-arm-cortex-a9-glibc [2/6]: OK br-arm-cortex-m4-full [3/6]: SKIPPED br-x86-64-musl [4/6]: FAILED br-arm-full-static [5/6]: OK sourcery-arm [6/6]: OK
Quoted 1 line
rngd_jitter.c:(.text+0x7da): undefined reference to `pthread_yield'
man pthread_yield:
This call is nonstandard, but present on several other systems. Use the standardized sched_yield(2) instead.
Should be simple enough to patch.
Regards,
Arnout
Quoted 5 lines
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
PATCH 1/1 package/rng-tools: needs NPTL
Arnout,
Quoted 36 lines · Arnout Vandecappelle
Quoted 32 lines · Matthew Weber
Bernd,
Quoted 9 lines · Matthew Weber
Bernd,
Quoted 4 lines · Bernd Kuhls
Fixes:
http://autobuild.buildroot.net/results/e18/e1815b96997fb7def688e0aeb5d342fc64dbb64d/Quoted 7 lines
Quoted 1 line
Signed-off-by Bernd Kuhls <[email protected]>$ ./utils/check-package package/rng-tools/* 99 lines processed 0 warnings generatedReviewed-by Matt Weber <[email protected]>Looks like the next thread related build failure will be musl related.
./utils/test-pkg -p rng-tools -d testbuild
br-arm-full [1/6]: OK br-arm-cortex-a9-glibc [2/6]: OK br-arm-cortex-m4-full [3/6]: SKIPPED br-x86-64-musl [4/6]: FAILED br-arm-full-static [5/6]: OK sourcery-arm [6/6]: OK
Quoted 8 lines
Quoted 1 line
rngd_jitter.c:(.text+0x7da): undefined reference to `pthread_yield'
man
pthread_yield:This call is nonstandard, but present on several other systems. Use the standardized
sched_yield(2)instead.Should be simple enough to patch.
Looks like upstream had a commit
http://patchwork.ozlabs.org/patch/1187237/
Thomas Petazzoni
AppliedPATCH 1/1 package/rng-tools: needs NPTL
In reply to Bernd KuhlsQuoted 7 lines · On Wed, 30 Oct 2019 06:58:50 +0100 Bernd Kuhls <[email protected]> wrote:
Fixes:
http://autobuild.buildroot.net/results/e18/e1815b96997fb7def688e0aeb5d342fc64dbb64d/Signed-off-by Bernd Kuhls <[email protected]>--- package/rng-tools/Config.in | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com