Skip to contentSkip to conversation

package/mesa3d: VDPAU needs x11

PATCH New Fabrice Fontaine 2 participants 2 messages Nov 4, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/mesa3d: VDPAU needs x11

Commit c898f95c275a105caacbb31adf92ef94bd4530c4 added support for Gallium VDPAU state tracker by updating Config.in to add a dependency on XORG7. However, mesa3d.mk was not updated to reflect this dependency.

XORG7 dependences is already managed under the ifeq BR2_PACKAGE_MESA3D_OPENGL_GLX block so reuse this block by making ifeq depends on a new BR2_PACKAGE_MESA3D_NEEDS_X11 hidden option

Fixes:
- http://autobuild.buildroot.org/results/bbd102d59bbdca35fd1b5401df2790dd197d1e5f

---
Changes v1 -> v2:
- Add BR2_PACKAGE_MESA3D_NEEDS_X11 option

 package/mesa3d/Config.in | 23 +++++++++++++++--------
 package/mesa3d/mesa3d.mk |  2 +-
 2 files changed, 16 insertions(+), 9 deletions(-)
package/mesa3d/Config.in +15 -8
index d247f57846..455091eb9d 100644
@@ -82,6 +82,19 @@ config BR2_PACKAGE_MESA3D_NEEDS_XA
 config BR2_PACKAGE_MESA3D_GALLIUM_KMSRO
 	bool
 
+# OpenGL GLX and Gallium VDPAU both needs X11
+config BR2_PACKAGE_MESA3D_NEEDS_X11
+	bool
+	depends on BR2_PACKAGE_XORG7
+	select BR2_PACKAGE_LIBXCB
+	select BR2_PACKAGE_XLIB_LIBX11
+	select BR2_PACKAGE_XLIB_LIBXDAMAGE
+	select BR2_PACKAGE_XLIB_LIBXEXT
+	select BR2_PACKAGE_XLIB_LIBXFIXES
+	select BR2_PACKAGE_XLIB_LIBXRANDR
+	select BR2_PACKAGE_XLIB_LIBXXF86VM
+	select BR2_PACKAGE_XORGPROTO
+
 comment "Gallium drivers"
 
 config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV
@@ -229,6 +242,7 @@ config BR2_PACKAGE_MESA3D_VDPAU
 	depends on BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_NOUVEAU \
 		|| BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600 \
 		|| BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_RADEONSI
+	select BR2_PACKAGE_MESA3D_NEEDS_X11
 	select BR2_PACKAGE_LIBVDPAU
 	help
 	  VDPAU state tracker (needs r600, radeonsi or nouveau gallium
@@ -338,14 +352,7 @@ config BR2_PACKAGE_MESA3D_OPENGL_GLX
 	bool "OpenGL GLX"
 	depends on BR2_PACKAGE_XORG7
 	select BR2_PACKAGE_HAS_LIBGL
-	select BR2_PACKAGE_LIBXCB
-	select BR2_PACKAGE_XLIB_LIBX11
-	select BR2_PACKAGE_XLIB_LIBXDAMAGE
-	select BR2_PACKAGE_XLIB_LIBXEXT
-	select BR2_PACKAGE_XLIB_LIBXFIXES
-	select BR2_PACKAGE_XLIB_LIBXRANDR
-	select BR2_PACKAGE_XLIB_LIBXXF86VM
-	select BR2_PACKAGE_XORGPROTO
+	select BR2_PACKAGE_MESA3D_NEEDS_X11
 	help
 	  Enable GLX graphic acceleration (OpenGL + X11).
 
package/mesa3d/mesa3d.mk +1 -1
index 9a7e0c9952..3f61253348 100644
@@ -183,7 +183,7 @@ MESA3D_DEPENDENCIES += wayland wayland-protocols
 MESA3D_PLATFORMS += wayland
 MESA3D_CONF_OPTS += -Dwayland-scanner-path=$(HOST_DIR)/bin/wayland-scanner
 endif
-ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_GLX),y)
+ifeq ($(BR2_PACKAGE_MESA3D_NEEDS_X11),y)
 MESA3D_DEPENDENCIES += \
 	xlib_libX11 \
 	xlib_libXext \
Signature · 1 line
2.23.0
#1 lore raw

PATCH v2 1/1 package/mesa3d: VDPAU needs x11

Quoted 8 lines · On Mon, 4 Nov 2019 19:16:09 +0100 Fabrice Fontaine…

Commit c898f95c275a105caacbb31adf92ef94bd4530c4 added support for Gallium VDPAU state tracker by updating Config.in to add a dependency on XORG7. However, mesa3d.mk was not updated to reflect this dependency.

XORG7 dependences is already managed under the ifeq BR2_PACKAGE_MESA3D_OPENGL_GLX block so reuse this block by making ifeq depends on a new BR2_PACKAGE_MESA3D_NEEDS_X11 hidden option

Quoted 7 lines

Fixes:
- http://autobuild.buildroot.org/results/bbd102d59bbdca35fd1b5401df2790dd197d1e5f

---
Changes v1 -> v2:
- Add BR2_PACKAGE_MESA3D_NEEDS_X11 option

Applied to master, thanks. The dependencies of this mesa3d package are really complicated :-/

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com