bnxt patchset with bug fixes
v2 cover bnxt patchset with bug fixes
From: Kalesh AP <[email protected]>
Please apply.
Ajit Khaparde (1):
net/bnxt: fix incorrect COS queue mapping
Kalesh AP (2):
net/bnxt: fix L4 checksum error indication in non-vector mode rx net/bnxt: fix a failure case during initialization
Santoshkumar Karanappa Rastapur (1):
net/bnxt: fix vnic allocation failure on port toggle
Venkat Duvvuru (1):
net/bnxt: fix redundant mac addr check
drivers/net/bnxt/bnxt_ethdev.c | 126 +++++++++++++---------------------------- drivers/net/bnxt/bnxt_filter.c | 4 +- drivers/net/bnxt/bnxt_filter.h | 8 ++- drivers/net/bnxt/bnxt_hwrm.c | 14 ++--- drivers/net/bnxt/bnxt_ring.c | 5 +- drivers/net/bnxt/bnxt_ring.h | 1 - drivers/net/bnxt/bnxt_rxq.c | 2 + drivers/net/bnxt/bnxt_rxr.c | 18 +++--- drivers/net/bnxt/bnxt_vnic.c | 5 +- drivers/net/bnxt/bnxt_vnic.h | 1 - 10 files changed, 73 insertions(+), 111 deletions(-)
v1->v2: updated commit log of patch2
Signature · 1 line
2.10.1
PATCH v2 1/5 net/bnxt: fix L4 checksum error indication in non-vector mode rx
From: Kalesh AP <[email protected]>
Update "mbuf->ol_flags" correctly for inner and ourter ip checksum errors in case of tunnel and non-tunnel packets.
--- drivers/net/bnxt/bnxt_rxr.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-)
drivers/net/bnxt/bnxt_rxr.c +11 -7
@@ -512,15 +512,19 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt, flags2_f =flags2_0xf (rxcmp1);/* IP Checksum */ -if (unlikely (((IS_IP_NONTUNNEL_PKT (flags2_f)) && - (RX_CMP_IP_CS_ERROR (rxcmp1))) || - (IS_IP_TUNNEL_PKT (flags2_f) && - (RX_CMP_IP_OUTER_CS_ERROR (rxcmp1))))) { - mbuf->ol_flags |=PKT_RX_IP_CKSUM_BAD ; +if (likely (IS_IP_NONTUNNEL_PKT (flags2_f))) { +if (unlikely (RX_CMP_IP_CS_ERROR (rxcmp1))) + mbuf->ol_flags |=PKT_RX_IP_CKSUM_BAD ; +else + mbuf->ol_flags |=PKT_RX_IP_CKSUM_GOOD ; + }else if (IS_IP_TUNNEL_PKT (flags2_f)) { +if (unlikely (RX_CMP_IP_OUTER_CS_ERROR (rxcmp1) || +RX_CMP_IP_CS_ERROR (rxcmp1))) + mbuf->ol_flags |=PKT_RX_IP_CKSUM_BAD ; +else + mbuf->ol_flags |=PKT_RX_IP_CKSUM_GOOD ; }else if (unlikely (RX_CMP_IP_CS_UNKNOWN (rxcmp1))) { mbuf->ol_flags |=PKT_RX_IP_CKSUM_UNKNOWN ; - }else { - mbuf->ol_flags |=PKT_RX_IP_CKSUM_GOOD ; }/* L4 Checksum */
Signature · 1 line
2.10.1
PATCH v2 2/5 net/bnxt: fix redundant mac addr check
In reply to Kalesh A PFrom: Venkat Duvvuru <[email protected]>
filter->mac_index is used to check, if a same mac is already programmed. Hence, filter->dflt member is not needed which is also used for mac addr redundancy check.
This patch fixes it by moving mac_index based redundant check from bnxt_mac_addr_add_op to bnxt_add_mac_filter
--- drivers/net/bnxt/bnxt_ethdev.c | 107 +++++++++++++++-------------------------- drivers/net/bnxt/bnxt_filter.c | 1 + drivers/net/bnxt/bnxt_filter.h | 7 ++- drivers/net/bnxt/bnxt_hwrm.c | 9 ++-- drivers/net/bnxt/bnxt_rxq.c | 2 + 5 files changed, 51 insertions(+), 75 deletions(-)
drivers/net/bnxt/bnxt_ethdev.c +39 -68
@@ -1018,8 +1018,7 @@ static void bnxt_mac_addr_remove_op(struct rte_eth_dev *eth_dev,bnxt_hwrm_clear_l2_filter (bp, filter); filter->mac_index =INVALID_MAC_INDEX ;memset (&filter->l2_addr,0 ,RTE_ETHER_ADDR_LEN ); -STAILQ_INSERT_TAIL (&bp->free_filter_list, - filter, next); +bnxt_free_filter (bp, filter); } filter = temp_filter; }
@@ -1027,19 +1026,21 @@ static void bnxt_mac_addr_remove_op(struct rte_eth_dev *eth_dev, }static int bnxt_add_mac_filter (struct bnxt *bp,struct bnxt_vnic_info *vnic, -struct rte_ether_addr *mac_addr,uint32_t index) +struct rte_ether_addr *mac_addr,uint32_t index, +uint32_t pool) {struct bnxt_filter_info *filter;int rc =0 ; - filter =STAILQ_FIRST (&vnic->filter); -/* During bnxt_mac_addr_add_op, default MAC is -* already programmed, so skip it. But, when -* hw-vlan-filter is turned OFF from ON, default -* MAC filter should be restored -*/ -if (index ==0 && filter->dflt) -return 0 ; +/* Attach requested MAC address to the new l2_filter */ + STAILQ_FOREACH(filter, &vnic->filter, next) { +if (filter->mac_index == index) { +PMD_DRV_LOG (ERR , +"MAC addr already existed for pool %d\n" , + pool); +return 0 ; + } + } filter =bnxt_alloc_filter (bp);if (!filter) {
@@ -1047,7 +1048,6 @@ static int bnxt_add_mac_filter(struct bnxt *bp, struct bnxt_vnic_info *vnic,return -ENODEV ; } - filter->mac_index = index;/* bnxt_alloc_filter copies default MAC to filter->l2_addr. So, * if the MAC that's been programmed now is a different one, then, * copy that addr to filter->l2_addr
@@ -1058,14 +1058,12 @@ static int bnxt_add_mac_filter(struct bnxt *bp, struct bnxt_vnic_info *vnic, rc =bnxt_hwrm_set_l2_filter (bp, vnic->fw_vnic_id, filter);if (!rc) { -if (filter->mac_index ==0 ) { - filter->dflt = true; + filter->mac_index = index; +if (filter->mac_index ==0 )STAILQ_INSERT_HEAD (&vnic->filter, filter, next); - }else { +else STAILQ_INSERT_TAIL (&vnic->filter, filter, next); - } }else { - filter->mac_index =INVALID_MAC_INDEX ;memset (&filter->l2_addr,0 ,RTE_ETHER_ADDR_LEN );bnxt_free_filter (bp, filter); }
@@ -1079,7 +1077,6 @@ static int bnxt_mac_addr_add_op(struct rte_eth_dev *eth_dev, {struct bnxt *bp = eth_dev->data->dev_private;struct bnxt_vnic_info *vnic = &bp->vnic_info[pool]; -struct bnxt_filter_info *filter;int rc =0 ; rc =is_bnxt_in_error (bp);
@@ -1095,16 +1092,8 @@ static int bnxt_mac_addr_add_op(struct rte_eth_dev *eth_dev,PMD_DRV_LOG (ERR ,"VNIC not found for pool %d!\n" , pool);return -EINVAL ; } -/* Attach requested MAC address to the new l2_filter */ - STAILQ_FOREACH(filter, &vnic->filter, next) { -if (filter->mac_index == index) { -PMD_DRV_LOG (ERR , -"MAC addr already existed for pool %d\n" , pool); -return 0 ; - } - } - rc =bnxt_add_mac_filter (bp, vnic, mac_addr, index); + rc =bnxt_add_mac_filter (bp, vnic, mac_addr, index, pool);return rc; }
@@ -1726,33 +1715,22 @@ static int bnxt_del_vlan_filter(struct bnxt *bp, uint16_t vlan_id)int rc =0 ;uint32_t chk =HWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_IVLAN ; -/* if VLAN exists && VLAN matches vlan_id -* remove the MAC+VLAN filter -* add a new MAC only filter -* else -* VLAN filter doesn't exist, just skip and continue -*/ vnic =BNXT_GET_DEFAULT_VNIC (bp); filter =STAILQ_FIRST (&vnic->filter);while (filter) {/* Search for this matching MAC+VLAN filter */ -if ((filter->enables & chk) && - (filter->l2_ivlan == vlan_id && - filter->l2_ivlan_mask !=0 ) && - !memcmp (filter->l2_addr, bp->mac_addr, -RTE_ETHER_ADDR_LEN )) { +if (bnxt_vlan_filter_exists (bp, filter, chk, vlan_id)) {/* Delete the filter */ rc =bnxt_hwrm_clear_l2_filter (bp, filter);if (rc)return rc;STAILQ_REMOVE (&vnic->filter, filter, bnxt_filter_info, next); -STAILQ_INSERT_TAIL (&bp->free_filter_list, filter, next); - +bnxt_free_filter (bp, filter);PMD_DRV_LOG (INFO , -"Del Vlan filter for %d\n" , +"Deleted vlan filter for %d\n" , vlan_id); -return rc; +return 0 ; } filter =STAILQ_NEXT (filter, next); }
@@ -1780,11 +1758,7 @@ static int bnxt_add_vlan_filter(struct bnxt *bp, uint16_t vlan_id) filter =STAILQ_FIRST (&vnic->filter);/* Check if the VLAN has already been added */ while (filter) { -if ((filter->enables & chk) && - (filter->l2_ivlan == vlan_id && - filter->l2_ivlan_mask ==0x0FFF ) && - !memcmp (filter->l2_addr, bp->mac_addr, -RTE_ETHER_ADDR_LEN )) +if (bnxt_vlan_filter_exists (bp, filter, chk, vlan_id))return -EEXIST ; filter =STAILQ_NEXT (filter, next);
@@ -1817,18 +1791,17 @@ static int bnxt_add_vlan_filter(struct bnxt *bp, uint16_t vlan_id)* not able to create the filter in hardware. */ filter->fw_l2_filter_id =UINT64_MAX ; -STAILQ_INSERT_TAIL (&bp->free_filter_list, filter, next); +bnxt_free_filter (bp, filter);return rc; - }else { -/* Add this new filter to the list */ -if (vlan_id ==0 ) { - filter->dflt = true; -STAILQ_INSERT_HEAD (&vnic->filter, filter, next); - }else { -STAILQ_INSERT_TAIL (&vnic->filter, filter, next); - } } + filter->mac_index =0 ; +/* Add this new filter to the list */ +if (vlan_id ==0 ) +STAILQ_INSERT_HEAD (&vnic->filter, filter, next); +else +STAILQ_INSERT_TAIL (&vnic->filter, filter, next); +PMD_DRV_LOG (INFO ,"Added Vlan filter for %d\n" , vlan_id);return rc;
@@ -1859,19 +1832,17 @@ static int bnxt_del_dflt_mac_filter(struct bnxt *bp, filter =STAILQ_FIRST (&vnic->filter);while (filter) { -if (filter->dflt && +if (filter->mac_index ==0 && !memcmp (filter->l2_addr, bp->mac_addr,RTE_ETHER_ADDR_LEN )) { rc =bnxt_hwrm_clear_l2_filter (bp, filter); -if (rc) -return rc; - filter->dflt = false; -STAILQ_REMOVE (&vnic->filter, filter, - bnxt_filter_info, next); -STAILQ_INSERT_TAIL (&bp->free_filter_list, - filter, next); - filter->fw_l2_filter_id =-1 ; -break ; +if (!rc) { +STAILQ_REMOVE (&vnic->filter, filter, + bnxt_filter_info, next); +bnxt_free_filter (bp, filter); + filter->fw_l2_filter_id =UINT64_MAX ; + } +return rc; } filter =STAILQ_NEXT (filter, next); }
@@ -1894,10 +1865,10 @@ bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask) vnic =BNXT_GET_DEFAULT_VNIC (bp);if (!(rx_offloads &DEV_RX_OFFLOAD_VLAN_FILTER )) {/* Remove any VLAN filters programmed */ -for (i =0 ; i <4095 ; i++) +for (i =0 ; i <RTE_ETHER_MAX_VLAN_ID ; i++)bnxt_del_vlan_filter (bp, i); - rc =bnxt_add_mac_filter (bp, vnic,NULL ,0 ); + rc =bnxt_add_mac_filter (bp, vnic,NULL ,0 ,0 );if (rc)return rc; }else {
drivers/net/bnxt/bnxt_filter.c +1 -0
@@ -34,6 +34,7 @@ struct bnxt_filter_info *bnxt_alloc_filter(struct bnxt *bp) }STAILQ_REMOVE_HEAD (&bp->free_filter_list, next); + filter->mac_index =INVALID_MAC_INDEX ;/* Default to L2 MAC Addr filter */ filter->flags =HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_PATH_RX ; filter->enables = HWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_ADDR |
drivers/net/bnxt/bnxt_filter.h +6 -1
@@ -8,6 +8,12 @@#include <rte_ether.h> +#define bnxt_vlan_filter_exists (bp, filter, chk, vlan_id) \ + (((filter)->enables & (chk)) && \ + ((filter)->l2_ivlan == (vlan_id) && \ + (filter)->l2_ivlan_mask == 0x0FFF) && \ + !memcmp((filter)->l2_addr, (bp)->mac_addr, \ + RTE_ETHER_ADDR_LEN))struct bnxt ;#define BNXT_FLOW_L2_VALID_FLAG BIT(0)
@@ -71,7 +77,6 @@ struct bnxt_filter_info {uint16_t ip_addr_type;uint16_t ethertype;uint32_t priority; -uint8_t dflt; };struct bnxt_filter_info *bnxt_alloc_filter (struct bnxt *bp);
drivers/net/bnxt/bnxt_hwrm.c +3 -6
@@ -2468,18 +2468,15 @@ int bnxt_set_hwrm_vnic_filters(struct bnxt *bp, struct bnxt_vnic_info *vnic)int rc =0 ; STAILQ_FOREACH(filter, &vnic->filter, next) { -if (filter->filter_type ==HWRM_CFA_EM_FILTER ) { +if (filter->filter_type ==HWRM_CFA_EM_FILTER ) rc =bnxt_hwrm_set_em_filter (bp, filter->dst_id, filter); - }else if (filter->filter_type ==HWRM_CFA_NTUPLE_FILTER ) { +else if (filter->filter_type ==HWRM_CFA_NTUPLE_FILTER ) rc =bnxt_hwrm_set_ntuple_filter (bp, filter->dst_id, filter); - }else { +else rc =bnxt_hwrm_set_l2_filter (bp, vnic->fw_vnic_id, filter); -if (!rc) - filter->dflt =1 ; - }if (rc)break ; }
drivers/net/bnxt/bnxt_rxq.c +2 -0
@@ -63,6 +63,7 @@ int bnxt_mq_rx_configure(struct bnxt *bp) rc = -ENOMEM ; goto err_out; } + filter->mac_index =0 ; filter->flags |=HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST ;STAILQ_INSERT_TAIL (&vnic->filter, filter, next); goto out;
@@ -146,6 +147,7 @@ int bnxt_mq_rx_configure(struct bnxt *bp) rc = -ENOMEM ; goto err_out; } + filter->mac_index =0 ; filter->flags |=HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST ;/* * TODO: Configure & associate CFA rule for
Signature · 1 line
2.10.1
PATCH v2 3/5 net/bnxt: fix vnic allocation failure on port toggle
In reply to Kalesh A PFrom: Santoshkumar Karanappa Rastapur <[email protected]>
bnxt_init_chip called on port start keeps incrementing rx_cosq_cnt. Hence more vnics are allocated with less number of rings on each port stop/start operation. Eventually vnic allocation fails due to incorrect ring group as no ring gets allocated to the vnic.
--- drivers/net/bnxt/bnxt_ethdev.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/bnxt/bnxt_ethdev.c +1 -0
@@ -967,6 +967,7 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)bnxt_shutdown_nic (bp);bnxt_hwrm_if_change (bp,0 ); bp->dev_stopped =1 ; + bp->rx_cosq_cnt =0 ; }static void bnxt_dev_close_op (struct rte_eth_dev *eth_dev)
Signature · 1 line
2.10.1
PATCH v2 4/5 net/bnxt: fix a failure case during initialization
In reply to Kalesh A PFrom: Kalesh AP <[email protected]>
During initialization sequence in bnxt_alloc_mem()
if bnxt_alloc_async_cp_ring() fails, driver invokes bnxt_free_mem() which in turn call bnxt_free_vnic_mem() which causes the error logs "bnxt_free_vnic_mem(): VNIC is not freed yet!". This is because vnic memory is allocated but not initialized yet.
Fix this by moving bnxt_init_vnics() from bnxt_init_nic() to bnxt_alloc_vnic_mem(). Also get rid of bnxt_init_nic() as the initialization is done in respective functions now.
--- drivers/net/bnxt/bnxt_ethdev.c | 18 ------------------ drivers/net/bnxt/bnxt_filter.c | 3 ++- drivers/net/bnxt/bnxt_filter.h | 1 - drivers/net/bnxt/bnxt_ring.c | 5 ++--- drivers/net/bnxt/bnxt_ring.h | 1 - drivers/net/bnxt/bnxt_vnic.c | 5 +++-- drivers/net/bnxt/bnxt_vnic.h | 1 - 7 files changed, 7 insertions(+), 27 deletions(-)
drivers/net/bnxt/bnxt_ethdev.c +0 -18
@@ -479,22 +479,6 @@ static int bnxt_shutdown_nic(struct bnxt *bp)return 0 ; } -static int bnxt_init_nic (struct bnxt *bp) -{ -int rc; - -if (BNXT_HAS_RING_GRPS (bp)) { - rc =bnxt_init_ring_grps (bp); -if (rc) -return rc; - } - -bnxt_init_vnics (bp); -bnxt_init_filters (bp); - -return 0 ; -} -/* * Device configuration and status function */
@@ -4665,8 +4649,6 @@ static int bnxt_init_resources(struct bnxt *bp, bool reconfig_dev)if (rc)return rc; -bnxt_init_nic (bp); - rc =bnxt_request_int (bp);if (rc)return rc;
drivers/net/bnxt/bnxt_filter.c +2 -1
@@ -61,7 +61,7 @@ struct bnxt_filter_info *bnxt_alloc_vf_filter(struct bnxt *bp, uint16_t vf)return filter; } -void bnxt_init_filters (struct bnxt *bp) +static void bnxt_init_filters (struct bnxt *bp) {struct bnxt_filter_info *filter;int i, max_filters;
@@ -171,6 +171,7 @@ int bnxt_alloc_filter_mem(struct bnxt *bp)return -ENOMEM ; } bp->filter_info = filter_mem; +bnxt_init_filters (bp);return 0 ; }
drivers/net/bnxt/bnxt_filter.h +0 -1
@@ -81,7 +81,6 @@ struct bnxt_filter_info {struct bnxt_filter_info *bnxt_alloc_filter (struct bnxt *bp);struct bnxt_filter_info *bnxt_alloc_vf_filter (struct bnxt *bp,uint16_t vf); -void bnxt_init_filters (struct bnxt *bp);void bnxt_free_all_filters (struct bnxt *bp);void bnxt_free_filter_mem (struct bnxt *bp);int bnxt_alloc_filter_mem (struct bnxt *bp);
drivers/net/bnxt/bnxt_ring.c +2 -3
@@ -38,15 +38,13 @@ void bnxt_free_ring(struct bnxt_ring *ring)* Ring groups */ -int bnxt_init_ring_grps (struct bnxt *bp) +static void bnxt_init_ring_grps (struct bnxt *bp) {unsigned int i;for (i =0 ; i < bp->max_ring_grps; i++)memset (&bp->grp_info[i], (uint8_t )HWRM_NA_SIGNATURE ,sizeof (struct bnxt_ring_grp_info )); - -return 0 ; }int bnxt_alloc_ring_grps (struct bnxt *bp)
@@ -76,6 +74,7 @@ int bnxt_alloc_ring_grps(struct bnxt *bp) "Failed to alloc grp info tbl.\n");return -ENOMEM ; } +bnxt_init_ring_grps (bp); }return 0 ;
drivers/net/bnxt/bnxt_ring.h +0 -1
@@ -65,7 +65,6 @@ struct bnxt_tx_ring_info;struct bnxt_rx_ring_info ;struct bnxt_cp_ring_info ;void bnxt_free_ring (struct bnxt_ring *ring); -int bnxt_init_ring_grps (struct bnxt *bp);int bnxt_alloc_ring_grps (struct bnxt *bp); int bnxt_alloc_rings(struct bnxt *bp, uint16_t qidx, struct bnxt_tx_queue *txq,
drivers/net/bnxt/bnxt_vnic.c +3 -2
@@ -35,7 +35,7 @@ void prandom_bytes(void *dest_ptr, size_t len) } } -void bnxt_init_vnics (struct bnxt *bp) +static void bnxt_init_vnics (struct bnxt *bp) {struct bnxt_vnic_info *vnic;uint16_t max_vnics;
@@ -52,7 +52,6 @@ void bnxt_init_vnics(struct bnxt *bp) vnic->hash_mode =HWRM_VNIC_RSS_CFG_INPUT_HASH_MODE_FLAGS_DEFAULT ; -prandom_bytes (vnic->rss_hash_key,HW_HASH_KEY_SIZE );STAILQ_INIT (&vnic->filter);STAILQ_INIT (&vnic->flow_list);STAILQ_INSERT_TAIL (&bp->free_vnic_list, vnic, next);
@@ -179,6 +178,7 @@ int bnxt_alloc_vnic_attributes(struct bnxt *bp) HW_HASH_KEY_SIZE); vnic->mc_list_dma_addr = vnic->rss_hash_key_dma_addr +HW_HASH_KEY_SIZE ; +prandom_bytes (vnic->rss_hash_key,HW_HASH_KEY_SIZE ); }return 0 ;
@@ -220,6 +220,7 @@ int bnxt_alloc_vnic_mem(struct bnxt *bp)return -ENOMEM ; } bp->vnic_info = vnic_mem; +bnxt_init_vnics (bp);return 0 ; }
drivers/net/bnxt/bnxt_vnic.h +0 -1
@@ -58,7 +58,6 @@ struct bnxt_vnic_info { };struct bnxt ; -void bnxt_init_vnics (struct bnxt *bp);int bnxt_free_vnic (struct bnxt *bp,struct bnxt_vnic_info *vnic,int pool);struct bnxt_vnic_info *bnxt_alloc_vnic (struct bnxt *bp);
Signature · 1 line
2.10.1
PATCH v2 5/5 net/bnxt: fix incorrect COS queue mapping
In reply to Kalesh A PFrom: Ajit Khaparde <[email protected]>
While issuing hwrm_queue_qportcfg command, we are setting the drv_qmap_cap bit which is causing the firmware to return incorrect COS queue mapping. This bit is not required when COS classification is enabled.
--- drivers/net/bnxt/bnxt_hwrm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/bnxt/bnxt_hwrm.c +3 -2
@@ -1217,8 +1217,9 @@ int bnxt_hwrm_queue_qportcfg(struct bnxt *bp)HWRM_PREP (req,QUEUE_QPORTCFG ,BNXT_USE_CHIMP_MB ); req.flags =rte_cpu_to_le_32 (dir); -/* HWRM Version >= 1.9.1 */ -if (bp->hwrm_spec_code >=HWRM_VERSION_1_9_1 ) +/* HWRM Version >= 1.9.1 only if COS Classification is not required. */ +if (bp->hwrm_spec_code >=HWRM_VERSION_1_9_1 && + !(bp->vnic_cap_flags &BNXT_VNIC_CAP_COS_CLASSIFY )) req.drv_qmap_cap =HWRM_QUEUE_QPORTCFG_INPUT_DRV_QMAP_CAP_ENABLED ; rc =bnxt_hwrm_send_message (bp, &req,sizeof (req),BNXT_USE_CHIMP_MB );
Signature · 1 line
2.10.1
v3 cover bnxt patchset with bug fixes
In reply to Kalesh A Pv2->v3:
Sending with updated the commit logs for patch 1 & 2
Ajit Khaparde (1):
net/bnxt: fix incorrect COS queue mapping
Kalesh AP (2):
net/bnxt: fix L4 checksum indication in non-vector Rx net/bnxt: fix a failure case during initialization
Santoshkumar Karanappa Rastapur (1):
net/bnxt: fix vnic allocation failure on port toggle
Venkat Duvvuru (1):
net/bnxt: fix redundant MAC address check
drivers/net/bnxt/bnxt_ethdev.c | 126 +++++++++++---------------------- drivers/net/bnxt/bnxt_filter.c | 4 +- drivers/net/bnxt/bnxt_filter.h | 8 ++- drivers/net/bnxt/bnxt_hwrm.c | 14 ++-- drivers/net/bnxt/bnxt_ring.c | 5 +- drivers/net/bnxt/bnxt_ring.h | 1 - drivers/net/bnxt/bnxt_rxq.c | 2 + drivers/net/bnxt/bnxt_rxr.c | 18 +++-- drivers/net/bnxt/bnxt_vnic.c | 5 +- drivers/net/bnxt/bnxt_vnic.h | 1 - 10 files changed, 73 insertions(+), 111 deletions(-)
Signature · 1 line
2.21.0 (Apple Git-122)
PATCH v3 1/5 net/bnxt: fix L4 checksum indication in non-vector Rx
From: Kalesh AP <[email protected]>
Update "mbuf->ol_flags" correctly for inner and ourter ip checksum errors in case of tunnel and non-tunnel packets.
--- drivers/net/bnxt/bnxt_rxr.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-)
drivers/net/bnxt/bnxt_rxr.c +11 -7
@@ -512,15 +512,19 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt, flags2_f =flags2_0xf (rxcmp1);/* IP Checksum */ -if (unlikely (((IS_IP_NONTUNNEL_PKT (flags2_f)) && - (RX_CMP_IP_CS_ERROR (rxcmp1))) || - (IS_IP_TUNNEL_PKT (flags2_f) && - (RX_CMP_IP_OUTER_CS_ERROR (rxcmp1))))) { - mbuf->ol_flags |=PKT_RX_IP_CKSUM_BAD ; +if (likely (IS_IP_NONTUNNEL_PKT (flags2_f))) { +if (unlikely (RX_CMP_IP_CS_ERROR (rxcmp1))) + mbuf->ol_flags |=PKT_RX_IP_CKSUM_BAD ; +else + mbuf->ol_flags |=PKT_RX_IP_CKSUM_GOOD ; + }else if (IS_IP_TUNNEL_PKT (flags2_f)) { +if (unlikely (RX_CMP_IP_OUTER_CS_ERROR (rxcmp1) || +RX_CMP_IP_CS_ERROR (rxcmp1))) + mbuf->ol_flags |=PKT_RX_IP_CKSUM_BAD ; +else + mbuf->ol_flags |=PKT_RX_IP_CKSUM_GOOD ; }else if (unlikely (RX_CMP_IP_CS_UNKNOWN (rxcmp1))) { mbuf->ol_flags |=PKT_RX_IP_CKSUM_UNKNOWN ; - }else { - mbuf->ol_flags |=PKT_RX_IP_CKSUM_GOOD ; }/* L4 Checksum */
Signature · 1 line
2.21.0 (Apple Git-122)
PATCH v3 2/5 net/bnxt: fix redundant MAC address check
In reply to Ajit KhapardeFrom: Venkat Duvvuru <[email protected]>
filter->mac_index is used to check, if a same mac is already programmed. Hence, filter->dflt member is not needed which is also used for mac addr redundancy check.
This patch fixes it by moving mac_index based redundant check from bnxt_mac_addr_add_op to bnxt_add_mac_filter
--- drivers/net/bnxt/bnxt_ethdev.c | 107 ++++++++++++--------------------- drivers/net/bnxt/bnxt_filter.c | 1 + drivers/net/bnxt/bnxt_filter.h | 7 ++- drivers/net/bnxt/bnxt_hwrm.c | 9 +-- drivers/net/bnxt/bnxt_rxq.c | 2 + 5 files changed, 51 insertions(+), 75 deletions(-)
drivers/net/bnxt/bnxt_ethdev.c +39 -68
@@ -1018,8 +1018,7 @@ static void bnxt_mac_addr_remove_op(struct rte_eth_dev *eth_dev,bnxt_hwrm_clear_l2_filter (bp, filter); filter->mac_index =INVALID_MAC_INDEX ;memset (&filter->l2_addr,0 ,RTE_ETHER_ADDR_LEN ); -STAILQ_INSERT_TAIL (&bp->free_filter_list, - filter, next); +bnxt_free_filter (bp, filter); } filter = temp_filter; }
@@ -1027,19 +1026,21 @@ static void bnxt_mac_addr_remove_op(struct rte_eth_dev *eth_dev, }static int bnxt_add_mac_filter (struct bnxt *bp,struct bnxt_vnic_info *vnic, -struct rte_ether_addr *mac_addr,uint32_t index) +struct rte_ether_addr *mac_addr,uint32_t index, +uint32_t pool) {struct bnxt_filter_info *filter;int rc =0 ; - filter =STAILQ_FIRST (&vnic->filter); -/* During bnxt_mac_addr_add_op, default MAC is -* already programmed, so skip it. But, when -* hw-vlan-filter is turned OFF from ON, default -* MAC filter should be restored -*/ -if (index ==0 && filter->dflt) -return 0 ; +/* Attach requested MAC address to the new l2_filter */ + STAILQ_FOREACH(filter, &vnic->filter, next) { +if (filter->mac_index == index) { +PMD_DRV_LOG (ERR , +"MAC addr already existed for pool %d\n" , + pool); +return 0 ; + } + } filter =bnxt_alloc_filter (bp);if (!filter) {
@@ -1047,7 +1048,6 @@ static int bnxt_add_mac_filter(struct bnxt *bp, struct bnxt_vnic_info *vnic,return -ENODEV ; } - filter->mac_index = index;/* bnxt_alloc_filter copies default MAC to filter->l2_addr. So, * if the MAC that's been programmed now is a different one, then, * copy that addr to filter->l2_addr
@@ -1058,14 +1058,12 @@ static int bnxt_add_mac_filter(struct bnxt *bp, struct bnxt_vnic_info *vnic, rc =bnxt_hwrm_set_l2_filter (bp, vnic->fw_vnic_id, filter);if (!rc) { -if (filter->mac_index ==0 ) { - filter->dflt = true; + filter->mac_index = index; +if (filter->mac_index ==0 )STAILQ_INSERT_HEAD (&vnic->filter, filter, next); - }else { +else STAILQ_INSERT_TAIL (&vnic->filter, filter, next); - } }else { - filter->mac_index =INVALID_MAC_INDEX ;memset (&filter->l2_addr,0 ,RTE_ETHER_ADDR_LEN );bnxt_free_filter (bp, filter); }
@@ -1079,7 +1077,6 @@ static int bnxt_mac_addr_add_op(struct rte_eth_dev *eth_dev, {struct bnxt *bp = eth_dev->data->dev_private;struct bnxt_vnic_info *vnic = &bp->vnic_info[pool]; -struct bnxt_filter_info *filter;int rc =0 ; rc =is_bnxt_in_error (bp);
@@ -1095,16 +1092,8 @@ static int bnxt_mac_addr_add_op(struct rte_eth_dev *eth_dev,PMD_DRV_LOG (ERR ,"VNIC not found for pool %d!\n" , pool);return -EINVAL ; } -/* Attach requested MAC address to the new l2_filter */ - STAILQ_FOREACH(filter, &vnic->filter, next) { -if (filter->mac_index == index) { -PMD_DRV_LOG (ERR , -"MAC addr already existed for pool %d\n" , pool); -return 0 ; - } - } - rc =bnxt_add_mac_filter (bp, vnic, mac_addr, index); + rc =bnxt_add_mac_filter (bp, vnic, mac_addr, index, pool);return rc; }
@@ -1726,33 +1715,22 @@ static int bnxt_del_vlan_filter(struct bnxt *bp, uint16_t vlan_id)int rc =0 ;uint32_t chk =HWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_IVLAN ; -/* if VLAN exists && VLAN matches vlan_id -* remove the MAC+VLAN filter -* add a new MAC only filter -* else -* VLAN filter doesn't exist, just skip and continue -*/ vnic =BNXT_GET_DEFAULT_VNIC (bp); filter =STAILQ_FIRST (&vnic->filter);while (filter) {/* Search for this matching MAC+VLAN filter */ -if ((filter->enables & chk) && - (filter->l2_ivlan == vlan_id && - filter->l2_ivlan_mask !=0 ) && - !memcmp (filter->l2_addr, bp->mac_addr, -RTE_ETHER_ADDR_LEN )) { +if (bnxt_vlan_filter_exists (bp, filter, chk, vlan_id)) {/* Delete the filter */ rc =bnxt_hwrm_clear_l2_filter (bp, filter);if (rc)return rc;STAILQ_REMOVE (&vnic->filter, filter, bnxt_filter_info, next); -STAILQ_INSERT_TAIL (&bp->free_filter_list, filter, next); - +bnxt_free_filter (bp, filter);PMD_DRV_LOG (INFO , -"Del Vlan filter for %d\n" , +"Deleted vlan filter for %d\n" , vlan_id); -return rc; +return 0 ; } filter =STAILQ_NEXT (filter, next); }
@@ -1780,11 +1758,7 @@ static int bnxt_add_vlan_filter(struct bnxt *bp, uint16_t vlan_id) filter =STAILQ_FIRST (&vnic->filter);/* Check if the VLAN has already been added */ while (filter) { -if ((filter->enables & chk) && - (filter->l2_ivlan == vlan_id && - filter->l2_ivlan_mask ==0x0FFF ) && - !memcmp (filter->l2_addr, bp->mac_addr, -RTE_ETHER_ADDR_LEN )) +if (bnxt_vlan_filter_exists (bp, filter, chk, vlan_id))return -EEXIST ; filter =STAILQ_NEXT (filter, next);
@@ -1817,18 +1791,17 @@ static int bnxt_add_vlan_filter(struct bnxt *bp, uint16_t vlan_id)* not able to create the filter in hardware. */ filter->fw_l2_filter_id =UINT64_MAX ; -STAILQ_INSERT_TAIL (&bp->free_filter_list, filter, next); +bnxt_free_filter (bp, filter);return rc; - }else { -/* Add this new filter to the list */ -if (vlan_id ==0 ) { - filter->dflt = true; -STAILQ_INSERT_HEAD (&vnic->filter, filter, next); - }else { -STAILQ_INSERT_TAIL (&vnic->filter, filter, next); - } } + filter->mac_index =0 ; +/* Add this new filter to the list */ +if (vlan_id ==0 ) +STAILQ_INSERT_HEAD (&vnic->filter, filter, next); +else +STAILQ_INSERT_TAIL (&vnic->filter, filter, next); +PMD_DRV_LOG (INFO ,"Added Vlan filter for %d\n" , vlan_id);return rc;
@@ -1859,19 +1832,17 @@ static int bnxt_del_dflt_mac_filter(struct bnxt *bp, filter =STAILQ_FIRST (&vnic->filter);while (filter) { -if (filter->dflt && +if (filter->mac_index ==0 && !memcmp (filter->l2_addr, bp->mac_addr,RTE_ETHER_ADDR_LEN )) { rc =bnxt_hwrm_clear_l2_filter (bp, filter); -if (rc) -return rc; - filter->dflt = false; -STAILQ_REMOVE (&vnic->filter, filter, - bnxt_filter_info, next); -STAILQ_INSERT_TAIL (&bp->free_filter_list, - filter, next); - filter->fw_l2_filter_id =-1 ; -break ; +if (!rc) { +STAILQ_REMOVE (&vnic->filter, filter, + bnxt_filter_info, next); +bnxt_free_filter (bp, filter); + filter->fw_l2_filter_id =UINT64_MAX ; + } +return rc; } filter =STAILQ_NEXT (filter, next); }
@@ -1894,10 +1865,10 @@ bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask) vnic =BNXT_GET_DEFAULT_VNIC (bp);if (!(rx_offloads &DEV_RX_OFFLOAD_VLAN_FILTER )) {/* Remove any VLAN filters programmed */ -for (i =0 ; i <4095 ; i++) +for (i =0 ; i <RTE_ETHER_MAX_VLAN_ID ; i++)bnxt_del_vlan_filter (bp, i); - rc =bnxt_add_mac_filter (bp, vnic,NULL ,0 ); + rc =bnxt_add_mac_filter (bp, vnic,NULL ,0 ,0 );if (rc)return rc; }else {
drivers/net/bnxt/bnxt_filter.c +1 -0
@@ -34,6 +34,7 @@ struct bnxt_filter_info *bnxt_alloc_filter(struct bnxt *bp) }STAILQ_REMOVE_HEAD (&bp->free_filter_list, next); + filter->mac_index =INVALID_MAC_INDEX ;/* Default to L2 MAC Addr filter */ filter->flags =HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_PATH_RX ; filter->enables = HWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_ADDR |
drivers/net/bnxt/bnxt_filter.h +6 -1
@@ -8,6 +8,12 @@#include <rte_ether.h> +#define bnxt_vlan_filter_exists (bp, filter, chk, vlan_id) \ + (((filter)->enables & (chk)) && \ + ((filter)->l2_ivlan == (vlan_id) && \ + (filter)->l2_ivlan_mask == 0x0FFF) && \ + !memcmp((filter)->l2_addr, (bp)->mac_addr, \ + RTE_ETHER_ADDR_LEN))struct bnxt ;#define BNXT_FLOW_L2_VALID_FLAG BIT(0)
@@ -71,7 +77,6 @@ struct bnxt_filter_info {uint16_t ip_addr_type;uint16_t ethertype;uint32_t priority; -uint8_t dflt; };struct bnxt_filter_info *bnxt_alloc_filter (struct bnxt *bp);
drivers/net/bnxt/bnxt_hwrm.c +3 -6
@@ -2468,18 +2468,15 @@ int bnxt_set_hwrm_vnic_filters(struct bnxt *bp, struct bnxt_vnic_info *vnic)int rc =0 ; STAILQ_FOREACH(filter, &vnic->filter, next) { -if (filter->filter_type ==HWRM_CFA_EM_FILTER ) { +if (filter->filter_type ==HWRM_CFA_EM_FILTER ) rc =bnxt_hwrm_set_em_filter (bp, filter->dst_id, filter); - }else if (filter->filter_type ==HWRM_CFA_NTUPLE_FILTER ) { +else if (filter->filter_type ==HWRM_CFA_NTUPLE_FILTER ) rc =bnxt_hwrm_set_ntuple_filter (bp, filter->dst_id, filter); - }else { +else rc =bnxt_hwrm_set_l2_filter (bp, vnic->fw_vnic_id, filter); -if (!rc) - filter->dflt =1 ; - }if (rc)break ; }
drivers/net/bnxt/bnxt_rxq.c +2 -0
@@ -63,6 +63,7 @@ int bnxt_mq_rx_configure(struct bnxt *bp) rc = -ENOMEM ; goto err_out; } + filter->mac_index =0 ; filter->flags |=HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST ;STAILQ_INSERT_TAIL (&vnic->filter, filter, next); goto out;
@@ -146,6 +147,7 @@ int bnxt_mq_rx_configure(struct bnxt *bp) rc = -ENOMEM ; goto err_out; } + filter->mac_index =0 ; filter->flags |=HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST ;/* * TODO: Configure & associate CFA rule for
Signature · 1 line
2.21.0 (Apple Git-122)
PATCH v3 3/5 net/bnxt: fix vnic allocation failure on port toggle
In reply to Ajit KhapardeFrom: Santoshkumar Karanappa Rastapur <[email protected]>
bnxt_init_chip called on port start keeps incrementing rx_cosq_cnt. Hence more vnics are allocated with less number of rings on each port stop/start operation. Eventually vnic allocation fails due to incorrect ring group as no ring gets allocated to the vnic.
--- drivers/net/bnxt/bnxt_ethdev.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/bnxt/bnxt_ethdev.c +1 -0
@@ -967,6 +967,7 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)bnxt_shutdown_nic (bp);bnxt_hwrm_if_change (bp,0 ); bp->dev_stopped =1 ; + bp->rx_cosq_cnt =0 ; }static void bnxt_dev_close_op (struct rte_eth_dev *eth_dev)
Signature · 1 line
2.21.0 (Apple Git-122)
PATCH v3 4/5 net/bnxt: fix a failure case during initialization
In reply to Ajit KhapardeFrom: Kalesh AP <[email protected]>
During initialization sequence in bnxt_alloc_mem()
if bnxt_alloc_async_cp_ring() fails, driver invokes bnxt_free_mem() which in turn call bnxt_free_vnic_mem() which causes the error logs "bnxt_free_vnic_mem(): VNIC is not freed yet!". This is because vnic memory is allocated but not initialized yet.
Fix this by moving bnxt_init_vnics() from bnxt_init_nic() to bnxt_alloc_vnic_mem(). Also get rid of bnxt_init_nic() as the initialization is done in respective functions now.
--- drivers/net/bnxt/bnxt_ethdev.c | 18 ------------------ drivers/net/bnxt/bnxt_filter.c | 3 ++- drivers/net/bnxt/bnxt_filter.h | 1 - drivers/net/bnxt/bnxt_ring.c | 5 ++--- drivers/net/bnxt/bnxt_ring.h | 1 - drivers/net/bnxt/bnxt_vnic.c | 5 +++-- drivers/net/bnxt/bnxt_vnic.h | 1 - 7 files changed, 7 insertions(+), 27 deletions(-)
drivers/net/bnxt/bnxt_ethdev.c +0 -18
@@ -479,22 +479,6 @@ static int bnxt_shutdown_nic(struct bnxt *bp)return 0 ; } -static int bnxt_init_nic (struct bnxt *bp) -{ -int rc; - -if (BNXT_HAS_RING_GRPS (bp)) { - rc =bnxt_init_ring_grps (bp); -if (rc) -return rc; - } - -bnxt_init_vnics (bp); -bnxt_init_filters (bp); - -return 0 ; -} -/* * Device configuration and status function */
@@ -4665,8 +4649,6 @@ static int bnxt_init_resources(struct bnxt *bp, bool reconfig_dev)if (rc)return rc; -bnxt_init_nic (bp); - rc =bnxt_request_int (bp);if (rc)return rc;
drivers/net/bnxt/bnxt_filter.c +2 -1
@@ -61,7 +61,7 @@ struct bnxt_filter_info *bnxt_alloc_vf_filter(struct bnxt *bp, uint16_t vf)return filter; } -void bnxt_init_filters (struct bnxt *bp) +static void bnxt_init_filters (struct bnxt *bp) {struct bnxt_filter_info *filter;int i, max_filters;
@@ -171,6 +171,7 @@ int bnxt_alloc_filter_mem(struct bnxt *bp)return -ENOMEM ; } bp->filter_info = filter_mem; +bnxt_init_filters (bp);return 0 ; }
drivers/net/bnxt/bnxt_filter.h +0 -1
@@ -81,7 +81,6 @@ struct bnxt_filter_info {struct bnxt_filter_info *bnxt_alloc_filter (struct bnxt *bp);struct bnxt_filter_info *bnxt_alloc_vf_filter (struct bnxt *bp,uint16_t vf); -void bnxt_init_filters (struct bnxt *bp);void bnxt_free_all_filters (struct bnxt *bp);void bnxt_free_filter_mem (struct bnxt *bp);int bnxt_alloc_filter_mem (struct bnxt *bp);
drivers/net/bnxt/bnxt_ring.c +2 -3
@@ -38,15 +38,13 @@ void bnxt_free_ring(struct bnxt_ring *ring)* Ring groups */ -int bnxt_init_ring_grps (struct bnxt *bp) +static void bnxt_init_ring_grps (struct bnxt *bp) {unsigned int i;for (i =0 ; i < bp->max_ring_grps; i++)memset (&bp->grp_info[i], (uint8_t )HWRM_NA_SIGNATURE ,sizeof (struct bnxt_ring_grp_info )); - -return 0 ; }int bnxt_alloc_ring_grps (struct bnxt *bp)
@@ -76,6 +74,7 @@ int bnxt_alloc_ring_grps(struct bnxt *bp) "Failed to alloc grp info tbl.\n");return -ENOMEM ; } +bnxt_init_ring_grps (bp); }return 0 ;
drivers/net/bnxt/bnxt_ring.h +0 -1
@@ -65,7 +65,6 @@ struct bnxt_tx_ring_info;struct bnxt_rx_ring_info ;struct bnxt_cp_ring_info ;void bnxt_free_ring (struct bnxt_ring *ring); -int bnxt_init_ring_grps (struct bnxt *bp);int bnxt_alloc_ring_grps (struct bnxt *bp); int bnxt_alloc_rings(struct bnxt *bp, uint16_t qidx, struct bnxt_tx_queue *txq,
drivers/net/bnxt/bnxt_vnic.c +3 -2
@@ -35,7 +35,7 @@ void prandom_bytes(void *dest_ptr, size_t len) } } -void bnxt_init_vnics (struct bnxt *bp) +static void bnxt_init_vnics (struct bnxt *bp) {struct bnxt_vnic_info *vnic;uint16_t max_vnics;
@@ -52,7 +52,6 @@ void bnxt_init_vnics(struct bnxt *bp) vnic->hash_mode =HWRM_VNIC_RSS_CFG_INPUT_HASH_MODE_FLAGS_DEFAULT ; -prandom_bytes (vnic->rss_hash_key,HW_HASH_KEY_SIZE );STAILQ_INIT (&vnic->filter);STAILQ_INIT (&vnic->flow_list);STAILQ_INSERT_TAIL (&bp->free_vnic_list, vnic, next);
@@ -179,6 +178,7 @@ int bnxt_alloc_vnic_attributes(struct bnxt *bp) HW_HASH_KEY_SIZE); vnic->mc_list_dma_addr = vnic->rss_hash_key_dma_addr +HW_HASH_KEY_SIZE ; +prandom_bytes (vnic->rss_hash_key,HW_HASH_KEY_SIZE ); }return 0 ;
@@ -220,6 +220,7 @@ int bnxt_alloc_vnic_mem(struct bnxt *bp)return -ENOMEM ; } bp->vnic_info = vnic_mem; +bnxt_init_vnics (bp);return 0 ; }
drivers/net/bnxt/bnxt_vnic.h +0 -1
@@ -58,7 +58,6 @@ struct bnxt_vnic_info { };struct bnxt ; -void bnxt_init_vnics (struct bnxt *bp);int bnxt_free_vnic (struct bnxt *bp,struct bnxt_vnic_info *vnic,int pool);struct bnxt_vnic_info *bnxt_alloc_vnic (struct bnxt *bp);
Signature · 1 line
2.21.0 (Apple Git-122)
PATCH v3 5/5 net/bnxt: fix incorrect COS queue mapping
In reply to Ajit KhapardeWhile issuing hwrm_queue_qportcfg command, we are setting the drv_qmap_cap bit which is causing the firmware to return incorrect COS queue mapping. This bit is not required when COS classification is enabled.
--- drivers/net/bnxt/bnxt_hwrm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/bnxt/bnxt_hwrm.c +3 -2
@@ -1217,8 +1217,9 @@ int bnxt_hwrm_queue_qportcfg(struct bnxt *bp)HWRM_PREP (req,QUEUE_QPORTCFG ,BNXT_USE_CHIMP_MB ); req.flags =rte_cpu_to_le_32 (dir); -/* HWRM Version >= 1.9.1 */ -if (bp->hwrm_spec_code >=HWRM_VERSION_1_9_1 ) +/* HWRM Version >= 1.9.1 only if COS Classification is not required. */ +if (bp->hwrm_spec_code >=HWRM_VERSION_1_9_1 && + !(bp->vnic_cap_flags &BNXT_VNIC_CAP_COS_CLASSIFY )) req.drv_qmap_cap =HWRM_QUEUE_QPORTCFG_INPUT_DRV_QMAP_CAP_ENABLED ; rc =bnxt_hwrm_send_message (bp, &req,sizeof (req),BNXT_USE_CHIMP_MB );
Signature · 1 line
2.21.0 (Apple Git-122)
Quoted 17 lines · Ajit Khaparde
v2->v3:
Sending with updated the commit logs for patch 1 & 2Ajit Khaparde (1):
net/bnxt: fix incorrect COS queue mappingKalesh AP (2):
net/bnxt: fix L4 checksum indication in non-vector Rx net/bnxt: fix a failure case during initializationSantoshkumar Karanappa Rastapur (1):
net/bnxt: fix vnic allocation failure on port toggleVenkat Duvvuru (1):
net/bnxt: fix redundant MAC address check
Quoted 12 lines
drivers/net/bnxt/bnxt_ethdev.c | 126 +++++++++++---------------------- drivers/net/bnxt/bnxt_filter.c | 4 +- drivers/net/bnxt/bnxt_filter.h | 8 ++- drivers/net/bnxt/bnxt_hwrm.c | 14 ++-- drivers/net/bnxt/bnxt_ring.c | 5 +- drivers/net/bnxt/bnxt_ring.h | 1 - drivers/net/bnxt/bnxt_rxq.c | 2 + drivers/net/bnxt/bnxt_rxr.c | 18 +++-- drivers/net/bnxt/bnxt_vnic.c | 5 +- drivers/net/bnxt/bnxt_vnic.h | 1 - 10 files changed, 73 insertions(+), 111 deletions(-)
Patchset applied to dpdk-next-net-brcm.
Quoted 5 lines
--
2.21.0 (Apple Git-122)