Skip to contentSkip to conversation

Refactor Gen11+ SAGV support

PATCH Superseded Stanislav Lisovskiy 2 participants 6 messages Nov 5, 2019

Subsystems (3)

v10 of 30 Superseded Latest is v30 →

lore
Share & tools
lore
#0 lore raw

v10 cover Refactor Gen11+ SAGV support

For Gen11+ platforms BSpec suggests disabling specific QGV points separately, depending on bandwidth limitations and current display configuration. Thus it required adding a new PCode request for disabling QGV points and some refactoring of already existing SAGV code.
Also had to refactor intel_can_enable_sagv function, as current seems to be outdated and using skl specific workarounds, also not following BSpec for Gen11+.

Stanislav Lisovskiy (2):
drm/i915: Refactor intel_can_enable_sagv
drm/i915: Restrict qgv points which don't have enough bandwidth.

 drivers/gpu/drm/i915/display/intel_atomic.h   |   3 +
 drivers/gpu/drm/i915/display/intel_bw.c       | 118 +++++--
 drivers/gpu/drm/i915/display/intel_bw.h       |   2 +
 drivers/gpu/drm/i915/display/intel_display.c  |  73 ++++-
 .../drm/i915/display/intel_display_types.h    |  12 +
 drivers/gpu/drm/i915/i915_drv.h               |  10 +-
 drivers/gpu/drm/i915/i915_reg.h               |   8 +
 drivers/gpu/drm/i915/intel_pm.c               | 303 ++++++++++++++++--
 drivers/gpu/drm/i915/intel_pm.h               |   1 +
 drivers/gpu/drm/i915/intel_sideband.c         |  27 +-
 10 files changed, 510 insertions(+), 47 deletions(-)
Signature · 6 lines
2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH v10 1/2 drm/i915: Refactor intel_can_enable_sagv

Currently intel_can_enable_sagv function contains a mix of workarounds for different platforms some of them are not valid for gens >= 11 already, so lets split it into separate functions.

v2:
- Rework watermark calculation algorithm to
attempt to calculate Level 0 watermark
with added sagv block time latency and
check if it fits in DBuf in order to
determine if SAGV can be enabled already
at this stage, just as BSpec 49325 states.
if that fails rollback to usual Level 0
latency and disable SAGV.
- Remove unneeded tabs(James Ausmus)

v3: Rebased the patch

v4: - Added back interlaced check for Gen12 and
added separate function for TGL SAGV check
(thanks to James Ausmus for spotting)
- Removed unneeded gen check
- Extracted Gen12 SAGV decision making code
to a separate function from skl_compute_wm

v5: - Added SAGV global state to dev_priv, because
we need to track all pipes, not only those in atomic state. Each pipe has now correspondent bit mask reflecting, whether it can tolerate SAGV or not(thanks to Ville Syrjala for suggestions).
- Now using active flag instead of enable in crc usage check.

v6: - Fixed rebase conflicts

Cc Ville Syrjälä <[email protected]>
Cc James Ausmus <[email protected]>
---
 drivers/gpu/drm/i915/display/intel_display.c  |   4 +
 .../drm/i915/display/intel_display_types.h    |   9 +
 drivers/gpu/drm/i915/i915_drv.h               |   6 +
 drivers/gpu/drm/i915/intel_pm.c               | 296 +++++++++++++++++-
 4 files changed, 303 insertions(+), 12 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +4 -0
index 876fc25968bf..7ea1e7518ab6 100644
@@ -14855,6 +14855,10 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)
 		if (dev_priv->display.optimize_watermarks)
 			dev_priv->display.optimize_watermarks(state,
 							      new_crtc_state);
+		if (state->crtc_sagv_mask & BIT(crtc->pipe))
+			dev_priv->crtc_sagv_mask |= BIT(crtc->pipe);
+		else
+			dev_priv->crtc_sagv_mask &= ~BIT(crtc->pipe);
 	}
 
 	for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {
drivers/gpu/drm/i915/display/intel_display_types.h +9 -0
index fadd9853f966..fb274538af23 100644
@@ -490,6 +490,14 @@ struct intel_atomic_state {
 	 */
 	u8 active_pipe_changes;
 
+	/*
+	 * Contains a mask which reflects whether correspondent pipe
+	 * can tolerate SAGV or not, so that we can make a decision
+	 * at atomic_commit_tail stage, whether we enable it or not
+	 * based on global state in dev_priv.
+	 */
+	u32 crtc_sagv_mask;
+
 	u8 active_pipes;
 	/* minimum acceptable cdclk for each pipe */
 	int min_cdclk[I915_MAX_PIPES];
@@ -670,6 +678,7 @@ struct skl_plane_wm {
 	struct skl_wm_level wm[8];
 	struct skl_wm_level uv_wm[8];
 	struct skl_wm_level trans_wm;
+	struct skl_wm_level sagv_wm0;
 	bool is_planar;
 };
 
drivers/gpu/drm/i915/i915_drv.h +6 -0
index 7e0f67babe20..4f4e2e839513 100644
@@ -1176,6 +1176,12 @@ struct drm_i915_private {
 
 	u32 sagv_block_time_us;
 
+	/*
+	 * Contains a bit mask, whether correspondent
+	 * pipe allows SAGV or not.
+	 */
+	u32 crtc_sagv_mask;
+
 	struct {
 		/*
 		 * Raw watermark latency values:
drivers/gpu/drm/i915/intel_pm.c +284 -12

411 lines not on this page · raw message

Signature · 6 lines
2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

PATCH v10 2/2 drm/i915: Restrict qgv points which don't have enough bandwidth.

In reply to Stanislav Lisovskiy

According to BSpec 53998, we should try to restrict qgv points, which can't provide enough bandwidth for desired display configuration.

Currently we are just comparing against all of
those and take minimum(worst case).

v2: Fixed wrong PCode reply mask, removed hardcoded
values.

v3: Forbid simultaneous legacy SAGV PCode requests and
restricting qgv points. Put the actual restriction to commit function, added serialization(thanks to Ville) to prevent commit being applied out of order in case of nonblocking and/or nomodeset commits.

v4:
- Minor code refactoring, fixed few typos(thanks to James Ausmus)
- Change the naming of qgv point
masking/unmasking functions(James Ausmus).
- Simplify the masking/unmasking operation itself,
as we don't need to mask only single point per request(James Ausmus)
- Reject and stick to highest bandwidth point if SAGV can't be enabled(BSpec)

v5:
- Add new mailbox reply codes, which seems to happen during boot time for TGL and indicate that QGV setting is not yet available.

v6:
- Increase number of supported QGV points to be in sync with BSpec.

v7: - Rebased and resolved conflict to fix build failure.
- Fix NUM_QGV_POINTS to 8 and moved that to header file(James Ausmus)

v8: - Don't report an error if we can't restrict qgv points, as SAGV
can be disabled by BIOS, which is completely legal. So don't make CI panic. Instead if we detect that there is only 1 QGV point accessible just analyze if we can fit the required bandwidth requirements, but no need in restricting.

---
 drivers/gpu/drm/i915/display/intel_atomic.h   |   3 +
 drivers/gpu/drm/i915/display/intel_bw.c       | 118 ++++++++++++++----
 drivers/gpu/drm/i915/display/intel_bw.h       |   2 +
 drivers/gpu/drm/i915/display/intel_display.c  |  69 +++++++++-
 .../drm/i915/display/intel_display_types.h    |   3 +
 drivers/gpu/drm/i915/i915_drv.h               |   4 +-
 drivers/gpu/drm/i915/i915_reg.h               |   8 ++
 drivers/gpu/drm/i915/intel_pm.c               |  11 +-
 drivers/gpu/drm/i915/intel_pm.h               |   1 +
 drivers/gpu/drm/i915/intel_sideband.c         |  27 +++-
 10 files changed, 209 insertions(+), 37 deletions(-)
drivers/gpu/drm/i915/display/intel_atomic.h +3 -0
index 7b49623419ba..3ab6d7ec75ae 100644
@@ -7,6 +7,7 @@
 #define __INTEL_ATOMIC_H__
 
 #include <linux/types.h>
+#include "intel_display_types.h"
 
 struct drm_atomic_state;
 struct drm_connector;
@@ -41,6 +42,8 @@ void intel_crtc_copy_color_blobs(struct intel_crtc_state *crtc_state);
 struct drm_atomic_state *intel_atomic_state_alloc(struct drm_device *dev);
 void intel_atomic_state_clear(struct drm_atomic_state *state);
 
+int intel_atomic_serialize_global_state(struct intel_atomic_state *state);
+
 struct intel_crtc_state *
 intel_atomic_get_crtc_state(struct drm_atomic_state *state,
 			    struct intel_crtc *crtc);
drivers/gpu/drm/i915/display/intel_bw.c +95 -23

160 lines not on this page · raw message

drivers/gpu/drm/i915/display/intel_bw.h +2 -0
index 9db10af012f4..66bf9bc10b73 100644
@@ -28,5 +28,7 @@ int intel_bw_init(struct drm_i915_private *dev_priv);
 int intel_bw_atomic_check(struct intel_atomic_state *state);
 void intel_bw_crtc_update(struct intel_bw_state *bw_state,
 			  const struct intel_crtc_state *crtc_state);
+int icl_pcode_restrict_qgv_points(struct drm_i915_private *dev_priv,
+				  u32 points_mask);
 
 #endif /* __INTEL_BW_H__ */
drivers/gpu/drm/i915/display/intel_display.c +65 -4

93 lines not on this page · raw message

drivers/gpu/drm/i915/display/intel_display_types.h +3 -0
index fb274538af23..896b13bc4494 100644
@@ -528,6 +528,9 @@ struct intel_atomic_state {
 	struct i915_sw_fence commit_ready;
 
 	struct llist_node freed;
+
+	/* Gen11+ only */
+	u32 qgv_points_mask;
 };
 
 struct intel_plane_state {
drivers/gpu/drm/i915/i915_drv.h +3 -1
index 4f4e2e839513..9924390cb94b 100644
@@ -1243,11 +1243,13 @@ struct drm_i915_private {
 	} dram_info;
 
 	struct intel_bw_info {
-		unsigned int deratedbw[3]; /* for each QGV point */
+		unsigned int deratedbw[NUM_SAGV_POINTS]; /* for each QGV point */
 		u8 num_qgv_points;
 		u8 num_planes;
 	} max_bw[6];
 
+	u32 qgv_points_mask;
+
 	struct drm_private_obj bw_obj;
 
 	struct intel_runtime_pm runtime_pm;
drivers/gpu/drm/i915/i915_reg.h +8 -0
index a607ea520829..6d6ecf1d9f6b 100644
@@ -8951,6 +8951,9 @@ enum {
 #define VLV_RENDER_C0_COUNT			_MMIO(0x138118)
 #define VLV_MEDIA_C0_COUNT			_MMIO(0x13811C)
 
+/* BSpec precisely defines this */
+#define NUM_SAGV_POINTS 8
+
 #define GEN6_PCODE_MAILBOX			_MMIO(0x138124)
 #define   GEN6_PCODE_READY			(1 << 31)
 #define   GEN6_PCODE_ERROR_MASK			0xFF
@@ -8961,6 +8964,8 @@ enum {
 #define     GEN6_PCODE_UNIMPLEMENTED_CMD	0xFF
 #define     GEN7_PCODE_TIMEOUT			0x2
 #define     GEN7_PCODE_ILLEGAL_DATA		0x3
+#define     GEN11_PCODE_MAIL_BOX_LOCKED		0x6
+#define     GEN11_PCODE_REJECTED		0x11
 #define     GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE 0x10
 #define   GEN6_PCODE_WRITE_RC6VIDS		0x4
 #define   GEN6_PCODE_READ_RC6VIDS		0x5
@@ -8982,6 +8987,7 @@ enum {
 #define   ICL_PCODE_MEM_SUBSYSYSTEM_INFO	0xd
 #define     ICL_PCODE_MEM_SS_READ_GLOBAL_INFO	(0x0 << 8)
 #define     ICL_PCODE_MEM_SS_READ_QGV_POINT_INFO(point)	(((point) << 16) | (0x1 << 8))
+#define   ICL_PCODE_SAGV_DE_MEM_SS_CONFIG	0xe
 #define   GEN6_PCODE_READ_D_COMP		0x10
 #define   GEN6_PCODE_WRITE_D_COMP		0x11
 #define   HSW_PCODE_DE_WRITE_FREQ_REQ		0x17
@@ -8994,6 +9000,8 @@ enum {
 #define     GEN9_SAGV_IS_DISABLED		0x1
 #define     GEN9_SAGV_ENABLE			0x3
 #define GEN12_PCODE_READ_SAGV_BLOCK_TIME_US	0x23
+#define GEN11_PCODE_POINTS_RESTRICTED		0x0
+#define GEN11_PCODE_POINTS_RESTRICTED_MASK	0x1
 #define GEN6_PCODE_DATA				_MMIO(0x138128)
 #define   GEN6_PCODE_FREQ_IA_RATIO_SHIFT	8
 #define   GEN6_PCODE_FREQ_RING_RATIO_SHIFT	16
drivers/gpu/drm/i915/intel_pm.c +3 -8
index c792dd168742..c737d2e8cd83 100644
@@ -3617,13 +3617,9 @@ static bool skl_needs_memory_bw_wa(struct drm_i915_private *dev_priv)
 	return IS_GEN9_BC(dev_priv) || IS_BROXTON(dev_priv);
 }
 
-static bool
+bool
 intel_has_sagv(struct drm_i915_private *dev_priv)
 {
-	/* HACK! */
-	if (IS_GEN(dev_priv, 12))
-		return false;
-
 	return (IS_GEN9_BC(dev_priv) || INTEL_GEN(dev_priv) >= 10) &&
 		dev_priv->sagv_status != I915_SAGV_NOT_CONTROLLED;
 }
@@ -3839,7 +3835,7 @@ static void icl_set_sagv_mask(struct intel_atomic_state *state)
 		if (flags & DRM_MODE_FLAG_INTERLACE)
 			continue;
 
-		if (!new_crtc_state->base.active)
+		if (!new_crtc_state->hw.enable)
 			continue;
 
 		can_sagv = true;
@@ -4340,7 +4336,7 @@ static int
 tgl_check_pipe_fits_sagv_wm(struct intel_crtc_state *crtc_state,
 		      struct skl_ddb_allocation *ddb /* out */)
 {
-	struct drm_crtc *crtc = crtc_state->base.crtc;
+	struct drm_crtc *crtc = crtc_state->uapi.crtc;
 	struct drm_i915_private *dev_priv = to_i915(crtc->dev);
 	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
 	struct skl_ddb_entry *alloc = &crtc_state->wm.skl.ddb;
@@ -4833,7 +4829,6 @@ static void skl_compute_plane_wm(const struct intel_crtc_state *crtc_state,
 				 struct skl_wm_level *result /* out */)
 {
 	struct drm_i915_private *dev_priv = to_i915(crtc_state->uapi.crtc->dev);
-	u32 latency = dev_priv->wm.skl_latency[level];
 	uint_fixed_16_16_t method1, method2;
 	uint_fixed_16_16_t selected_result;
 	u32 res_blocks, res_lines, min_ddb_alloc = 0;
drivers/gpu/drm/i915/intel_pm.h +1 -0
index b579c724b915..53275860731a 100644
@@ -43,6 +43,7 @@ void skl_pipe_wm_get_hw_state(struct intel_crtc *crtc,
 void g4x_wm_sanitize(struct drm_i915_private *dev_priv);
 void vlv_wm_sanitize(struct drm_i915_private *dev_priv);
 bool intel_can_enable_sagv(struct intel_atomic_state *state);
+bool intel_has_sagv(struct drm_i915_private *dev_priv);
 int intel_enable_sagv(struct drm_i915_private *dev_priv);
 int intel_disable_sagv(struct drm_i915_private *dev_priv);
 bool skl_wm_level_equals(const struct skl_wm_level *l1,
drivers/gpu/drm/i915/intel_sideband.c +26 -1
index e06b35b844a0..ff9dbed094d8 100644
@@ -371,6 +371,29 @@ static inline int gen7_check_mailbox_status(u32 mbox)
 	}
 }
 
+static inline int gen11_check_mailbox_status(u32 mbox)
+{
+	switch (mbox & GEN6_PCODE_ERROR_MASK) {
+	case GEN6_PCODE_SUCCESS:
+		return 0;
+	case GEN6_PCODE_ILLEGAL_CMD:
+		return -ENXIO;
+	case GEN7_PCODE_TIMEOUT:
+		return -ETIMEDOUT;
+	case GEN7_PCODE_ILLEGAL_DATA:
+		return -EINVAL;
+	case GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE:
+		return -EOVERFLOW;
+	case GEN11_PCODE_MAIL_BOX_LOCKED:
+		return -EAGAIN;
+	case GEN11_PCODE_REJECTED:
+		return -EACCES;
+	default:
+		MISSING_CASE(mbox & GEN6_PCODE_ERROR_MASK);
+		return 0;
+	}
+}
+
 static int __sandybridge_pcode_rw(struct drm_i915_private *i915,
 				  u32 mbox, u32 *val, u32 *val1,
 				  int fast_timeout_us,
@@ -408,7 +431,9 @@ static int __sandybridge_pcode_rw(struct drm_i915_private *i915,
 	if (is_read && val1)
 		*val1 = intel_uncore_read_fw(uncore, GEN6_PCODE_DATA1);
 
-	if (INTEL_GEN(i915) > 6)
+	if (INTEL_GEN(i915) >= 11)
+		return gen11_check_mailbox_status(mbox);
+	else if (INTEL_GEN(i915) > 6)
 		return gen7_check_mailbox_status(mbox);
 	else
 		return gen6_check_mailbox_status(mbox);
Signature · 6 lines
2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw

✗ Fi.CI.CHECKPATCH: warning for Refactor Gen11+ SAGV support (rev8)

In reply to Stanislav Lisovskiy
== Series Details ==

== Series Details ==

Series: Refactor Gen11+ SAGV support (rev8)
URL : https://patchwork.freedesktop.org/series/68028/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
962b1132a55c drm/i915: Refactor intel_can_enable_sagv
-:191: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#191: FILE: drivers/gpu/drm/i915/intel_pm.c:3835:
+	for_each_new_intel_crtc_in_state(state, crtc,
+					     new_crtc_state, i) {

-:271: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #271: FILE: drivers/gpu/drm/i915/intel_pm.c:3915:
+ bool state_sagv_masked = \

-:276: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #276: FILE: drivers/gpu/drm/i915/intel_pm.c:3920:
+ bool sagv_masked = \

-:311: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #311: FILE: drivers/gpu/drm/i915/intel_pm.c:4341:
+tgl_check_pipe_fits_sagv_wm(struct intel_crtc_state *crtc_state,
+ struct skl_ddb_allocation *ddb /* out */)

-:423: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #423: FILE: drivers/gpu/drm/i915/intel_pm.c:4991:
+ skl_compute_plane_wm(crtc_state, 0, latency,
+ wm_params, &levels[0],

-:425: CHECK:BRACES: Unbalanced braces around else statement #425: FILE: drivers/gpu/drm/i915/intel_pm.c:4993:
+ } else

-:427: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #427: FILE: drivers/gpu/drm/i915/intel_pm.c:4995:
+ memcpy(&plane_wm->sagv_wm0, &levels[0],
+ sizeof(struct skl_wm_level));

-:490: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #490: FILE: drivers/gpu/drm/i915/intel_pm.c:5681:
+ for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
+ new_crtc_state, i) {

-:496: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #496: FILE: drivers/gpu/drm/i915/intel_pm.c:5687:
+ struct skl_plane_wm *plane_wm = \

-:519: WARNING:LINE_SPACING: Missing a blank line after declarations #519: FILE: drivers/gpu/drm/i915/intel_pm.c:5710:
+ int pipe_bit = BIT(crtc->pipe);
+ state->crtc_sagv_mask |= pipe_bit;

total: 0 errors, 4 warnings, 6 checks, 454 lines checked adb7c6a30deb drm/i915: Restrict qgv points which don't have enough bandwidth. -:93: CHECK:LINE_SPACING: Please don't use multiple blank lines #93: FILE: drivers/gpu/drm/i915/display/intel_bw.c:19:

+

-:124: CHECK:LINE_SPACING: Please don't use multiple blank lines #124: FILE: drivers/gpu/drm/i915/display/intel_bw.c:139:
+
+

-:351: CHECK:BRACES: braces {} should be used on all arms of this statement #351: FILE: drivers/gpu/drm/i915/display/intel_display.c:14934:
+ if (INTEL_GEN(dev_priv) < 11) {
[...]
+ } else
[...]

-:354: CHECK:BRACES: Unbalanced braces around else statement #354: FILE: drivers/gpu/drm/i915/display/intel_display.c:14937:
+ } else

total: 0 errors, 0 warnings, 4 checks, 413 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

✗ Fi.CI.SPARSE: warning for Refactor Gen11+ SAGV support (rev8)

In reply to Stanislav Lisovskiy
== Series Details ==

== Series Details ==

Series: Refactor Gen11+ SAGV support (rev8)
URL : https://patchwork.freedesktop.org/series/68028/
State : warning

== Summary ==

$ dim sparse origin/drm-tip
Sparse version: v0.6.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

✗ Fi.CI.BAT: failure for Refactor Gen11+ SAGV support (rev8)

In reply to Stanislav Lisovskiy
== Series Details ==

== Series Details ==

Series: Refactor Gen11+ SAGV support (rev8)
URL : https://patchwork.freedesktop.org/series/68028/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7262 -> Patchwork_15135
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_15135 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_15135, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15135/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_15135:

### IGT changes ###

#### Possible regressions ####

* igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7262/fi-icl-u3/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15135/fi-icl-u3/igt@[email protected]
- fi-icl-u2: [PASS][3] -> [DMESG-WARN][4] +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7262/fi-icl-u2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15135/fi-icl-u2/igt@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@i915_selftest@live_client:
- {fi-tgl-u}: NOTRUN -> [DMESG-WARN][5] +32 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15135/fi-tgl-u/igt@i915_selftest@live_client.html

* igt@kms_cursor_legacy@basic-flip-before-cursor-atomic:
- {fi-tgl-u}: NOTRUN -> [FAIL][6] +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15135/fi-tgl-u/igt@[email protected]

* igt@kms_flip@basic-flip-vs-dpms:
- {fi-icl-y}: [PASS][7] -> [DMESG-WARN][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7262/fi-icl-y/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15135/fi-icl-y/igt@[email protected]

* igt@kms_flip@basic-flip-vs-wf_vblank:
- {fi-icl-u4}: [PASS][9] -> [DMESG-WARN][10] +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7262/fi-icl-u4/igt@kms_flip@basic-flip-vs-wf_vblank.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15135/fi-icl-u4/igt@kms_flip@basic-flip-vs-wf_vblank.html

Known issues
------------

Here are the changes found in Patchwork_15135 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_param@basic-default:
- fi-icl-u3: [PASS][11] -> [DMESG-WARN][12] ([fdo#107724])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7262/fi-icl-u3/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15135/fi-icl-u3/igt@[email protected]

* igt@gem_flink_basic@basic:
- fi-icl-u3: [PASS][13] -> [DMESG-WARN][14] ([fdo#107724] / [fdo#112052 ])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7262/fi-icl-u3/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15135/fi-icl-u3/igt@[email protected]

* igt@i915_selftest@live_blt:
- fi-bsw-n3050: [PASS][15] -> [DMESG-FAIL][16] ([fdo#112176])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7262/fi-bsw-n3050/igt@i915_selftest@live_blt.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15135/fi-bsw-n3050/igt@i915_selftest@live_blt.html

#### Possible fixes ####

* igt@gem_exec_parallel@basic:
- {fi-tgl-u}: [INCOMPLETE][17] ([fdo#111887]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7262/fi-tgl-u/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15135/fi-tgl-u/igt@[email protected]

* igt@gem_flink_basic@double-flink:
- fi-icl-u3: [DMESG-WARN][19] ([fdo#107724]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7262/fi-icl-u3/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15135/fi-icl-u3/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][21] ([fdo#111045] / [fdo#111096]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7262/fi-kbl-7500u/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15135/fi-kbl-7500u/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111887]: https://bugs.freedesktop.org/show_bug.cgi?id=111887
[fdo#112052 ]: https://bugs.freedesktop.org/show_bug.cgi?id=112052
[fdo#112176]: https://bugs.freedesktop.org/show_bug.cgi?id=112176

Participating hosts (51 -> 43)
------------------------------

Additional (1): fi-cml-u2
Missing (9): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-bwr-2160 fi-ctg-p8600 fi-gdg-551 fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_7262 -> Patchwork_15135

CI-20190529: 20190529
CI_DRM_7262: 6d9033858175fc0e1ef5f77d6bd60356e6b70ee4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5263: 8a5d44dc5e51622cd43f23c2cf24d44c24a0564d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15135: adb7c6a30deb3644ad63864c228d006cfba35c4c @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

adb7c6a30deb drm/i915: Restrict qgv points which don't have enough bandwidth. 962b1132a55c drm/i915: Refactor intel_can_enable_sagv

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15135/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx