Skip to contentSkip to conversation

examples/l3fwd: use correct IP reserved address range

PATCH Applied Stephen Hemminger 4 participants 6 messages Nov 5, 2019 – Nov 8, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 examples/l3fwd: use correct IP reserved address range

The original patch used incorrect subnet range for testing.

Fixes 37afe381bde4 ("examples/l3fwd: use reserved IP addresses")
---
 doc/guides/testpmd_app_ug/run_app.rst |  6 +++---
 examples/l3fwd/l3fwd_lpm.c            | 18 +++++++++---------
 2 files changed, 12 insertions(+), 12 deletions(-)
doc/guides/testpmd_app_ug/run_app.rst +3 -3
index 00e0c2ac5152..858cec7e0b0b 100644
@@ -129,9 +129,9 @@ The command line options are:
 *   ``--tx-ip=SRC,DST``
 
     Set the source and destination IP address used when doing transmit only test.
-    The defaults address values are source 192.18.0.1 and
-    destination 192.18.0.2. These are special purpose addresses
-    reserved for benchmarking (RFC 2544).
+    The defaults address values are source 198.18.0.1 and
+    destination 198.18.0.2. These are special purpose addresses
+    reserved for benchmarking (RFC 5735).
 
 *   ``--tx-udp=SRC[,DST]``
 
examples/l3fwd/l3fwd_lpm.c +9 -9
index a3a65f7fc814..349de2703cd1 100644
@@ -41,16 +41,16 @@ struct ipv6_l3fwd_lpm_route {
 	uint8_t  if_out;
 };
 
-/* 192.18.0.0/16 are set aside for RFC2544 benchmarking. */
+/* 198.18.0.0/16 are set aside for RFC2544 benchmarking (RFC5735). */
 static struct ipv4_l3fwd_lpm_route ipv4_l3fwd_lpm_route_array[] = {
-	{RTE_IPV4(192, 18, 0, 0), 24, 0},
-	{RTE_IPV4(192, 18, 1, 0), 24, 1},
-	{RTE_IPV4(192, 18, 2, 0), 24, 2},
-	{RTE_IPV4(192, 18, 3, 0), 24, 3},
-	{RTE_IPV4(192, 18, 4, 0), 24, 4},
-	{RTE_IPV4(192, 18, 5, 0), 24, 5},
-	{RTE_IPV4(192, 18, 6, 0), 24, 6},
-	{RTE_IPV4(192, 18, 7, 0), 24, 7},
+	{RTE_IPV4(198, 18, 0, 0), 24, 0},
+	{RTE_IPV4(198, 18, 1, 0), 24, 1},
+	{RTE_IPV4(198, 18, 2, 0), 24, 2},
+	{RTE_IPV4(198, 18, 3, 0), 24, 3},
+	{RTE_IPV4(198, 18, 4, 0), 24, 4},
+	{RTE_IPV4(198, 18, 5, 0), 24, 5},
+	{RTE_IPV4(198, 18, 6, 0), 24, 6},
+	{RTE_IPV4(198, 18, 7, 0), 24, 7},
 };
 
 /* 2001:0200::/48 is IANA reserved range for IPv6 benchmarking (RFC5180) */
Signature · 1 line
2.20.1
#1 lore raw
Quoted 4 lines · Stephen Hemminger

The original patch used incorrect subnet range for testing.

Fixes 37afe381bde4 ("examples/l3fwd: use reserved IP addresses")

I guess this is:

Quoted 54 lines
---
 doc/guides/testpmd_app_ug/run_app.rst |  6 +++---
 examples/l3fwd/l3fwd_lpm.c            | 18 +++++++++---------
 2 files changed, 12 insertions(+), 12 deletions(-)
doc/guides/testpmd_app_ug/run_app.rst +3 -3
index 00e0c2ac5152..858cec7e0b0b 100644
@@ -129,9 +129,9 @@ The command line options are:
 *   ``--tx-ip=SRC,DST``
 
     Set the source and destination IP address used when doing transmit only test.
-    The defaults address values are source 192.18.0.1 and
-    destination 192.18.0.2. These are special purpose addresses
-    reserved for benchmarking (RFC 2544).
+    The defaults address values are source 198.18.0.1 and
+    destination 198.18.0.2. These are special purpose addresses
+    reserved for benchmarking (RFC 5735).
 
 *   ``--tx-udp=SRC[,DST]``
 
examples/l3fwd/l3fwd_lpm.c +9 -9
index a3a65f7fc814..349de2703cd1 100644
@@ -41,16 +41,16 @@ struct ipv6_l3fwd_lpm_route {
 	uint8_t  if_out;
 };
 
-/* 192.18.0.0/16 are set aside for RFC2544 benchmarking. */
+/* 198.18.0.0/16 are set aside for RFC2544 benchmarking (RFC5735). */
 static struct ipv4_l3fwd_lpm_route ipv4_l3fwd_lpm_route_array[] = {
-	{RTE_IPV4(192, 18, 0, 0), 24, 0},
-	{RTE_IPV4(192, 18, 1, 0), 24, 1},
-	{RTE_IPV4(192, 18, 2, 0), 24, 2},
-	{RTE_IPV4(192, 18, 3, 0), 24, 3},
-	{RTE_IPV4(192, 18, 4, 0), 24, 4},
-	{RTE_IPV4(192, 18, 5, 0), 24, 5},
-	{RTE_IPV4(192, 18, 6, 0), 24, 6},
-	{RTE_IPV4(192, 18, 7, 0), 24, 7},
+	{RTE_IPV4(198, 18, 0, 0), 24, 0},
+	{RTE_IPV4(198, 18, 1, 0), 24, 1},
+	{RTE_IPV4(198, 18, 2, 0), 24, 2},
+	{RTE_IPV4(198, 18, 3, 0), 24, 3},
+	{RTE_IPV4(198, 18, 4, 0), 24, 4},
+	{RTE_IPV4(198, 18, 5, 0), 24, 5},
+	{RTE_IPV4(198, 18, 6, 0), 24, 6},
+	{RTE_IPV4(198, 18, 7, 0), 24, 7},
 };
 
 /* 2001:0200::/48 is IANA reserved range for IPv6 benchmarking (RFC5180) */
Acked-by on v1 1/1
#3 lore raw
In reply to Stephen Hemminger
Quoted 9 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Stephen Hemminger
Sent: Tuesday, November 5, 2019 9:39 PM
To: [email protected]
Cc: Stephen Hemminger <[email protected]>; Ferruh Yigit <[email protected]>
Subject: [dpdk-dev] [PATCH] examples/l3fwd: use correct IP reserved address range

Quoted 3 lines

The original patch used incorrect subnet range for testing.

Fixes 37afe381bde4 ("examples/l3fwd: use reserved IP addresses")

[Hemant] better to also add Cc: [email protected]

#4 lore raw

Stephen,

Do we want to fix testpmd?

$ git grep 192.*18 origin/master -- app/test-pmd/
origin/master:app/test-pmd/txonly.c:uint32_t tx_ip_src_addr = (192U <<
24) | (18 << 16) | (0 << 8) | 1;
origin/master:app/test-pmd/txonly.c:uint32_t tx_ip_dst_addr = (192U <<
24) | (18 << 16) | (0 << 8) | 2;

Commit bf5b2126bf44 ("app/testpmd: add ability to set Tx IP and UDP parameters")

I will take this patch on the example, for now.

Quoted 10 lines · Hemant Agrawal
Quoted 10 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Stephen Hemminger
Sent: Tuesday, November 5, 2019 9:39 PM
To: [email protected]
Cc: Stephen Hemminger <[email protected]>; Ferruh Yigit <[email protected]>
Subject: [dpdk-dev] [PATCH] examples/l3fwd: use correct IP reserved address range

Quoted 5 lines
Quoted 3 lines

The original patch used incorrect subnet range for testing.

Fixes 37afe381bde4 ("examples/l3fwd: use reserved IP addresses")

[Hemant] better to also add Cc: [email protected]

Yes.

Quoted 1 line

Applied, thanks.

Signature · 1 line
David Marchand
#5 lore raw
Quoted 4 lines · On Thu, 7 Nov 2019 21:52:47 +0100 David Marchand <[email protected]>…

Stephen,

Do we want to fix testpmd?

Quoted 8 lines
$ git grep 192.*18 origin/master -- app/test-pmd/
origin/master:app/test-pmd/txonly.c:uint32_t tx_ip_src_addr = (192U <<
24) | (18 << 16) | (0 << 8) | 1;
origin/master:app/test-pmd/txonly.c:uint32_t tx_ip_dst_addr = (192U <<
24) | (18 << 16) | (0 << 8) | 2;

Commit bf5b2126bf44 ("app/testpmd: add ability to set Tx IP and UDP parameters")

Yes, that should be fixed.
Ideally it should use a string instead of hardcoding shifts.