Skip to contentSkip to conversation

rtc: brcmstb-waketimer: add missed clk_disable_unprepare

PATCH Applied Chuhong Yuan 3 participants 3 messages Nov 5, 2019

Subsystems (2)
Real time clock (RTC) Broadcom BCM7XXX Arm architecture
lore
Share & tools
lore

Chuhong Yuan

author
#0 lore raw

PATCH v2 1/1 rtc: brcmstb-waketimer: add missed clk_disable_unprepare

This driver forgets to disable and unprepare clock when remove. Add a call to clk_disable_unprepare to fix it.

Fixes c4f07ecee22e ("rtc: brcmstb-waketimer: Add Broadcom STB wake-timer")
Signed-off-by Chuhong Yuan <[email protected]>

---
Changes in v2:
- Remove the check for timer->clk and add fixes tag.

 drivers/rtc/rtc-brcmstb-waketimer.c | 1 +
 1 file changed, 1 insertion(+)
drivers/rtc/rtc-brcmstb-waketimer.c +1 -0
index 3e9800f9878a..82d2ab0b3e9c 100644
@@ -277,6 +277,7 @@ static int brcmstb_waketmr_remove(struct platform_device *pdev)
 	struct brcmstb_waketmr *timer = dev_get_drvdata(&pdev->dev);
 
 	unregister_reboot_notifier(&timer->reboot_notifier);
+	clk_disable_unprepare(timer->clk);
 
 	return 0;
 }
Signature · 1 line
2.23.0
maintainer Applied
#2 lore raw
In reply to Chuhong Yuan
Quoted 12 lines · Chuhong Yuan

This driver forgets to disable and unprepare clock when remove. Add a call to clk_disable_unprepare to fix it.

Fixes c4f07ecee22e ("rtc: brcmstb-waketimer: Add Broadcom STB wake-timer")
Signed-off-by Chuhong Yuan <[email protected]>

---
Changes in v2:
- Remove the check for timer->clk and add fixes tag.

 drivers/rtc/rtc-brcmstb-waketimer.c | 1 +
 1 file changed, 1 insertion(+)

Applied, thanks.

Signature · 3 lines
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com