Skip to contentSkip to conversation

package/freerdp: fix pulseaudio support

PATCH New Alexey Lukyanchuk 3 participants 3 messages Nov 5, 2019 – Nov 7, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/freerdp: fix pulseaudio support

---
 package/freerdp/freerdp.mk | 1 +
 1 file changed, 1 insertion(+)
package/freerdp/freerdp.mk +1 -0
index 0f32ff4718..931fa49477 100644
@@ -51,6 +51,7 @@ endif
 
 ifeq ($(BR2_PACKAGE_PULSEAUDIO),y)
 FREERDP_CONF_OPTS += -DWITH_PULSEAUDIO=ON
+FREERDP_CONF_OPTS += -DWITH_PULSE=ON
 FREERDP_DEPENDENCIES += pulseaudio
 else
 FREERDP_CONF_OPTS += -DWITH_PULSEAUDIO=OFF
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/1 package/freerdp: fix pulseaudio support

Alexey, All,

On 2019-11-05 12:42 +0300, Alexey Lukyanchuk spake thusly:

package/freerdp/freerdp.mk endif · line 53

Quoted 13 lines
---
 package/freerdp/freerdp.mk | 1 +
 1 file changed, 1 insertion(+)
package/freerdp/freerdp.mk +0 -0
index 0f32ff4718..931fa49477 100644
@@ -51,6 +51,7 @@ endif
 
 ifeq ($(BR2_PACKAGE_PULSEAUDIO),y)
 FREERDP_CONF_OPTS += -DWITH_PULSEAUDIO=ON

This one should be removed, since it is in fact not used, and since ...

package/freerdp/freerdp.mk endif · line 54

Quoted 1 line
package/freerdp/freerdp.mk +1 -0
+FREERDP_CONF_OPTS += -DWITH_PULSE=ON

... this is the ciorrect variable, and ...

package/freerdp/freerdp.mk endif · line 57

Quoted 3 lines
package/freerdp/freerdp.mk +0 -0
 FREERDP_DEPENDENCIES += pulseaudio
 else
 FREERDP_CONF_OPTS += -DWITH_PULSEAUDIO=OFF

... it should also be used here too.

I've applied, fixed, expanded the commit log, and pushed now. Thanks!

Regards,
Yann E. MORIN.

Quoted 7 lines
Signature · 6 lines
2.21.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'