Skip to contentSkip to conversation

mm, vmstat: hide /proc/pagetypeinfo from normal users

PATCH In review [email protected] 1 participant 1 message Nov 6, 2019

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 7/17 mm, vmstat: hide /proc/pagetypeinfo from normal users

From: Michal Hocko <[email protected]>
Subject: mm, vmstat: hide /proc/pagetypeinfo from normal users

/proc/pagetypeinfo is a debugging tool to examine internal page allocator state wrt to fragmentation. It is not very useful for any other use so normal users really do not need to read this file.

Waiman Long has noticed that reading this file can have negative side effects because zone->lock is necessary for gathering data and that a) interferes with the page allocator and its users and b) can lead to hard lockups on large machines which have very long free_list.

Reduce both issues by simply not exporting the file to regular users.

Fixes 467c996c1e19 ("Print out statistics in relation to fragmentation avoidance to /proc/pagetypeinfo")
Cc David Hildenbrand <[email protected]>
Cc Johannes Weiner <[email protected]>
Cc Roman Gushchin <[email protected]>
Cc Konstantin Khlebnikov <[email protected]>
Cc Jann Horn <[email protected]>
Cc Song Liu <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>

---

 mm/vmstat.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/vmstat.c renamed from mm/vmstat.c~mm-vmstat-hide-proc-pagetypeinfo-from-normal-users +1 -1
@@ -1972,7 +1972,7 @@ void __init init_mm_internals(void)
 #endif
 #ifdef CONFIG_PROC_FS
 	proc_create_seq("buddyinfo", 0444, NULL, &fragmentation_op);
-	proc_create_seq("pagetypeinfo", 0444, NULL, &pagetypeinfo_op);
+	proc_create_seq("pagetypeinfo", 0400, NULL, &pagetypeinfo_op);
 	proc_create_seq("vmstat", 0444, NULL, &vmstat_op);
 	proc_create_seq("zoneinfo", 0444, NULL, &zoneinfo_op);
 #endif

_