Skip to contentSkip to conversation

Pull request: u-boot-dfu (06.11.2019)

U-Boot Lukasz Majewski 2 participants 6 messages Nov 6, 2019

lore
Share & tools
lore
#0 lore raw

Dear Marek,

The following changes since commit
14d39c9e1dc9397febd58399a70f32e7481bbc27:

travis: Rework how we write the ~/.buildman file (2019-11-05 10:44:16 -0500)

are available in the Git repository at:

git at gitlab.denx.de:u-boot/custodians/u-boot-dfu.git

BRANCH: master
https://gitlab.denx.de/u-boot/custodians/u-boot-dfu/commits/master

Merge TAG:
https://gitlab.denx.de/u-boot/custodians/u-boot-dfu/-/tags/u-boot-dfu-06Nov2019

for you to fetch changes up to 8c5df588e89b2bf4aad4c95b17cfc8634b8dcaaf:

usb: composite: add BOS descriptor support to composite framework (2019-11-06 01:01:06 +0100)

My remark:

- Those patches are new code, (like adding the USB 3.0 controller from Cadence) hence IMHO it would be best to add them to your next PR

----------------------------------------------------------------
Sherry Sun (1):

      usb: udc: Introduce ->udc_set_speed() method

T Karthik Reddy (1):
usb: composite: add BOS descriptor support to composite framework

Vignesh Raghavendra (7):
list: import list_first_entry_or_null()
bitmaps: import for_each_set_bit() macro
usb: gadget: Add match_ep() op to usb_gadget_ops
usb: Add Cadence USB3 host and gadget driver
usb: cdns3: gadget: Implement udc_set_speed() callback
usb: cdns3: Add TI wrapper driver for CDNS USB3 controller
usb: gadget: Add gadget_is_cdns3() macro

Travis-CI: https://travis-ci.org/lmajewski/u-boot-dfu/builds/607937090

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191106/314fcd2e/attachment.sig>

#1 lore raw
Quoted 20 lines · Lukasz Majewski

Dear Marek,

The following changes since commit
14d39c9e1dc9397febd58399a70f32e7481bbc27:

travis: Rework how we write the ~/.buildman file (2019-11-05 10:44:16 -0500)

are available in the Git repository at:

git at gitlab.denx.de:u-boot/custodians/u-boot-dfu.git

BRANCH: master
https://gitlab.denx.de/u-boot/custodians/u-boot-dfu/commits/master

Merge TAG:
https://gitlab.denx.de/u-boot/custodians/u-boot-dfu/-/tags/u-boot-dfu-06Nov2019

for you to fetch changes up to 8c5df588e89b2bf4aad4c95b17cfc8634b8dcaaf:

Quoted 8 lines

usb: composite: add BOS descriptor support to composite framework (2019-11-06 01:01:06 +0100)

My remark:

- Those patches are new code, (like adding the USB 3.0 controller from Cadence) hence IMHO it would be best to add them to your next PR

We are already in -rc cycle, so fixes only. Should this PR be for -next ?

Signature · 2 lines
Best regards,
Marek Vasut
#2 lore raw

Hi Marek,

Quoted 26 lines · Lukasz Majewski
Quoted 25 lines

Dear Marek,

The following changes since commit
14d39c9e1dc9397febd58399a70f32e7481bbc27:

travis: Rework how we write the ~/.buildman file (2019-11-05
10:44:16 -0500)

are available in the Git repository at:

git at gitlab.denx.de:u-boot/custodians/u-boot-dfu.git

BRANCH: master
https://gitlab.denx.de/u-boot/custodians/u-boot-dfu/commits/master

Merge TAG:
https://gitlab.denx.de/u-boot/custodians/u-boot-dfu/-/tags/u-boot-dfu-06Nov2019

for you to fetch changes up to
8c5df588e89b2bf4aad4c95b17cfc8634b8dcaaf:

usb: composite: add BOS descriptor support to composite framework (2019-11-06 01:01:06 +0100)

Quoted 9 lines
Quoted 5 lines

My remark:

- Those patches are new code, (like adding the USB 3.0 controller from Cadence) hence IMHO it would be best to add them to your next PR

We are already in -rc cycle, so fixes only. Should this PR be for -next ?

The BOS support is a fix do SS USB.

And the Cadence USB support is a new code, which is not touching any relevant parts of USB (and IMHO it applies to the same category as adding new boards outside the merge window).

However, if you believe that this code is not eligible for u-boot-usb/master ,then yes please pull it into -next.

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191106/3b9823ac/attachment.sig>

#3 lore raw
Quoted 38 lines · Lukasz Majewski

Hi Marek,

Quoted 26 lines · Lukasz Majewski
Quoted 25 lines

Dear Marek,

The following changes since commit
14d39c9e1dc9397febd58399a70f32e7481bbc27:

travis: Rework how we write the ~/.buildman file (2019-11-05
10:44:16 -0500)

are available in the Git repository at:

git at gitlab.denx.de:u-boot/custodians/u-boot-dfu.git

BRANCH: master
https://gitlab.denx.de/u-boot/custodians/u-boot-dfu/commits/master

Merge TAG:
https://gitlab.denx.de/u-boot/custodians/u-boot-dfu/-/tags/u-boot-dfu-06Nov2019

for you to fetch changes up to
8c5df588e89b2bf4aad4c95b17cfc8634b8dcaaf:

usb: composite: add BOS descriptor support to composite framework (2019-11-06 01:01:06 +0100)

Quoted 9 lines
Quoted 5 lines

My remark:

- Those patches are new code, (like adding the USB 3.0 controller from Cadence) hence IMHO it would be best to add them to your next PR

We are already in -rc cycle, so fixes only. Should this PR be for -next ?

Quoted 8 lines

The BOS support is a fix do SS USB.

And the Cadence USB support is a new code, which is not touching any relevant parts of USB (and IMHO it applies to the same category as adding new boards outside the merge window).

However, if you believe that this code is not eligible for u-boot-usb/master ,then yes please pull it into -next.

That decision is up to you. If you think this is safe to pull in RC1, I don't mind either way.

#4 lore raw

Hi Marek,

Quoted 45 lines · Lukasz Majewski
Quoted 44 lines

Hi Marek,

Quoted 26 lines · Lukasz Majewski
Quoted 25 lines

Dear Marek,

The following changes since commit
14d39c9e1dc9397febd58399a70f32e7481bbc27:

travis: Rework how we write the ~/.buildman file (2019-11-05
10:44:16 -0500)

are available in the Git repository at:

git at gitlab.denx.de:u-boot/custodians/u-boot-dfu.git

BRANCH: master
https://gitlab.denx.de/u-boot/custodians/u-boot-dfu/commits/master

Merge TAG:
https://gitlab.denx.de/u-boot/custodians/u-boot-dfu/-/tags/u-boot-dfu-06Nov2019

for you to fetch changes up to
8c5df588e89b2bf4aad4c95b17cfc8634b8dcaaf:

usb: composite: add BOS descriptor support to composite
framework (2019-11-06 01:01:06 +0100)

Quoted 9 lines
Quoted 5 lines

My remark:

- Those patches are new code, (like adding the USB 3.0 controller from Cadence) hence IMHO it would be best to add them to your next PR

We are already in -rc cycle, so fixes only. Should this PR be for -next ?

The BOS support is a fix do SS USB.

And the Cadence USB support is a new code, which is not touching any relevant parts of USB (and IMHO it applies to the same category as adding new boards outside the merge window).

Quoted 5 lines
Quoted 2 lines

However, if you believe that this code is not eligible for u-boot-usb/master ,then yes please pull it into -next.

That decision is up to you. If you think this is safe to pull in RC1, I don't mind either way.

Ok. Lets then pull it in RC1. Thanks for understanding :-)

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191106/43de25b3/attachment.sig>

#5 lore raw
Quoted 1 line · Lukasz Majewski

Hi Marek,

Hi,

Quoted 45 lines
Quoted 45 lines · Lukasz Majewski
Quoted 44 lines

Hi Marek,

Quoted 26 lines · Lukasz Majewski
Quoted 25 lines

Dear Marek,

The following changes since commit
14d39c9e1dc9397febd58399a70f32e7481bbc27:

travis: Rework how we write the ~/.buildman file (2019-11-05
10:44:16 -0500)

are available in the Git repository at:

git at gitlab.denx.de:u-boot/custodians/u-boot-dfu.git

BRANCH: master
https://gitlab.denx.de/u-boot/custodians/u-boot-dfu/commits/master

Merge TAG:
https://gitlab.denx.de/u-boot/custodians/u-boot-dfu/-/tags/u-boot-dfu-06Nov2019

for you to fetch changes up to
8c5df588e89b2bf4aad4c95b17cfc8634b8dcaaf:

usb: composite: add BOS descriptor support to composite
framework (2019-11-06 01:01:06 +0100)

Quoted 9 lines
Quoted 5 lines

My remark:

- Those patches are new code, (like adding the USB 3.0 controller from Cadence) hence IMHO it would be best to add them to your next PR

We are already in -rc cycle, so fixes only. Should this PR be for -next ?

The BOS support is a fix do SS USB.

And the Cadence USB support is a new code, which is not touching any relevant parts of USB (and IMHO it applies to the same category as adding new boards outside the merge window).

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

However, if you believe that this code is not eligible for u-boot-usb/master ,then yes please pull it into -next.

That decision is up to you. If you think this is safe to pull in RC1, I don't mind either way.

Ok. Lets then pull it in RC1. Thanks for understanding :-)

Pulled, thanks.