Skip to contentSkip to conversation

ARM: defconfig: add unified config for RPi3 and RPi4

PATCH New matthias.bgg at kernel.org 3 participants 3 messages Nov 6, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: defconfig: add unified config for RPi3 and RPi4

From: Matthias Brugger <[email protected]>

Provide a defconfig which allows us to boot Raspberrry Pi 4 and Raspberry Pi 3 Model B/B+
Instead of using the embedded DTB as done in RPi3 we use the devicetree provided by the firmware.

---
This patch is based on the series to enable one binary for RPi3 and RPi4:
https://patchwork.ozlabs.org/project/uboot/list/?series=140696

 arch/arm/mach-bcm283x/Kconfig |  7 ++++++
 configs/rpi_arm64_defconfig   | 45 +++++++++++++++++++++++++++++++++++
 2 files changed, 52 insertions(+)
 create mode 100644 configs/rpi_arm64_defconfig
arch/arm/mach-bcm283x/Kconfig +7 -0
index e8e0ff0eb4..00419bf254 100644
@@ -188,6 +188,13 @@ config TARGET_RPI_4
 	  This option creates a build targeting the ARMv8/AArch64 ISA.
 	select BCM2711_64B
 
+config TARGET_RPI_ARM64
+	bool "Raspberry Pi one binary 64-bit build"
+	help
+	  Support for all armv8 based Raspberry Pi variants, such as
+	  the RPi 4 model B, in AArch64 (64-bit) mode.
+	select ARM64
+
 endchoice
 
 config SYS_BOARD
configs/rpi_arm64_defconfig new file +45 -0

45 lines not on this page · raw message

Signature · 1 line
2.23.0
#1 lore raw

PATCH 1/1 ARM: defconfig: add unified config for RPi3 and RPi4

Quoted 6 lines · matthias.bgg at kernel.org

From: Matthias Brugger <[email protected]>

Provide a defconfig which allows us to boot Raspberrry Pi 4 and Raspberry Pi 3 Model B/B+
Instead of using the embedded DTB as done in RPi3 we use the devicetree provided by the firmware.

How different are the DTBs provided by different firmware releases?

Could we run into problems because some elder or newer firmware releases are not supported by U-Boot? - This prospect is what makes your patch a bit scary to me.

Which different firmware releases did you test against?

Do you plan to keep the existing defconfigs and dtbs?

Best regards

Heinrich

#2 lore raw

PATCH 1/1 ARM: defconfig: add unified config for RPi3 and RPi4

Quoted 8 lines · Heinrich Schuchardt
Quoted 6 lines · matthias.bgg at kernel.org

From: Matthias Brugger <[email protected]>

Provide a defconfig which allows us to boot Raspberrry Pi 4 and Raspberry Pi 3 Model B/B+
Instead of using the embedded DTB as done in RPi3 we use the devicetree provided by the firmware.

Quoted 5 lines

How different are the DTBs provided by different firmware releases?

Could we run into problems because some elder or newer firmware releases are not supported by U-Boot? - This prospect is what makes your patch a bit scary to me.

That could happen, but I suppose especially for older releases. Newer releases tend to change in the direction of upstream.

Quoted 5 lines

Which different firmware releases did you test against?

Do you plan to keep the existing defconfigs and dtbs?

I didn't do any extensive testing to be honest. We are using the DTB from the firmware on RPi4 already, and I expect that newer firmwares won't break U-Boot.

My idea is to keep the existing defconfigs. Apart from being a good fallback option if really something breaks, there might be some distros use U-Boot with this config files and I don't want to break the setup for them.

Regards,
Matthias