Skip to contentSkip to conversation

dmaengine: milbeaut-hdmac: remove redundant error log

PATCH In review Vinod Koul 1 participant 3 messages Nov 6, 2019 – Nov 8, 2019

Subsystems (2)
lore
Share & tools
lore

Vinod Koul

author maintainer
#0 lore raw

PATCH 1/2 dmaengine: milbeaut-hdmac: remove redundant error log

platform_get_irq() prints the error message, so caller need not do so, remove the error line in this driver for platform_get_irq()

---
 drivers/dma/milbeaut-hdmac.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/dma/milbeaut-hdmac.c +1 -4
index 2bb33535ab9e..8853d442430b 100644
@@ -431,11 +431,8 @@ static int milbeaut_hdmac_chan_init(struct platform_device *pdev,
 	int irq, ret;
 
 	irq = platform_get_irq(pdev, chan_id);
-	if (irq < 0) {
-		dev_err(&pdev->dev, "failed to get IRQ number for ch%d\n",
-			chan_id);
+	if (irq < 0)
 		return irq;
-	}
 
 	irq_name = devm_kasprintf(dev, GFP_KERNEL, "milbeaut-hdmac-%d",
 				  chan_id);
Signature · 1 line
2.23.0
author maintainer
#1 lore raw

PATCH 2/2 dmaengine: milbeaut-xdmac: remove redundant error log

platform_get_irq() prints the error message, so caller need not do so, remove the error line in this driver for platform_get_irq()

---
 drivers/dma/milbeaut-xdmac.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/dma/milbeaut-xdmac.c +1 -4
index 3d5b1926a58d..ab3d2f395378 100644
@@ -269,11 +269,8 @@ static int milbeaut_xdmac_chan_init(struct platform_device *pdev,
 	int irq, ret;
 
 	irq = platform_get_irq(pdev, chan_id);
-	if (irq < 0) {
-		dev_err(&pdev->dev, "failed to get IRQ number for ch%d\n",
-			chan_id);
+	if (irq < 0)
 		return irq;
-	}
 
 	irq_name = devm_kasprintf(dev, GFP_KERNEL, "milbeaut-xdmac-%d",
 				  chan_id);
Signature · 1 line
2.23.0
author maintainer
#2 lore raw
In reply to Vinod Koul
Quoted 2 lines · Vinod Koul

platform_get_irq() prints the error message, so caller need not do so, remove the error line in this driver for platform_get_irq()

Applied these now

Signature · 1 line
~Vinod