Skip to contentSkip to conversation

selftests/bps: clean up removed ints relocations negative tests

PATCH Applied Andrii Nakryiko 2 participants 2 messages Nov 6, 2019

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests/bps: clean up removed ints relocations negative tests

As part of 42765ede5c54 ("selftests/bpf: Remove too strict field offset relo test cases"), few ints relocations negative (supposed to fail) tests were removed, but not completely. Due to them being negative, some leftovers in prog_tests/core_reloc.c went unnoticed. Clean them up.

Fixes 42765ede5c54 ("selftests/bpf: Remove too strict field offset relo test cases")
---
 tools/testing/selftests/bpf/prog_tests/core_reloc.c | 6 ------
 1 file changed, 6 deletions(-)
tools/testing/selftests/bpf/prog_tests/core_reloc.c +0 -6
index 00f1f3229542..f94bd071536b 100644
@@ -337,12 +337,6 @@ static struct core_reloc_test_case test_cases[] = {
 	INTS_CASE(ints___bool),
 	INTS_CASE(ints___reverse_sign),
 
-	INTS_ERR_CASE(ints___err_bitfield),
-	INTS_ERR_CASE(ints___err_wrong_sz_8),
-	INTS_ERR_CASE(ints___err_wrong_sz_16),
-	INTS_ERR_CASE(ints___err_wrong_sz_32),
-	INTS_ERR_CASE(ints___err_wrong_sz_64),
-	
 	/* validate edge cases of capturing relocations */
 	{
 		.case_name = "misc",
Signature · 1 line
2.17.1
#1 lore raw
Quoted 8 lines · Andrii Nakryiko

As part of 42765ede5c54 ("selftests/bpf: Remove too strict field offset relo test cases"), few ints relocations negative (supposed to fail) tests were removed, but not completely. Due to them being negative, some leftovers in prog_tests/core_reloc.c went unnoticed. Clean them up.

Fixes 42765ede5c54 ("selftests/bpf: Remove too strict field offset relo test cases")

Applied. Thanks