Skip to contentSkip to conversation

package/sudo: make adding 'sudo' group+rule optional

PATCH New Stephan Henningsen 2 participants 2 messages Nov 5, 2019 – Nov 6, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/sudo: make adding 'sudo' group+rule optional

From: Stephan Henningsen <[email protected]>

I have concerns about the change that was made to my original patch; Instead of having the 'sudo' group and sudoers rule enabled by the user manually and thereby giving her concent, a change was made to apply the option silently.

While I do understand that making this all default will make the user experience a bit smoother, I fear that this won't be the case for everyone.

My motivations for making it an option to begin with (and for this follow-up patch) are the following:

1) Not everyone may be interested in the added rule to /etc/sudoers; it may even conflict with a custom rule. For example if a custom rule was added that does not prompt for user password, then the newly added rule, which does prompt for user password, maybe break automated cronjobs that rely on sudo for elevated priviledges without a password prompt.

2) Adding this group and rule is only one of many use-cases of the sudo package; some people may prefer adding custom rules that only allow certain well-known users (e.g. alice, bob) or certain system groups (e.g. wheel, daemon) to become root. These users may have to manually revert the changes now done to their /etc/sudoers.

3) If only a little, this addition adds to the size of the system's attack surface, potentially inadvertently allowing users to become root.

4) Not everyone may be interested in the added non-standard system group 'sudo'; they may even have to manually revert the changes now done to their /etc/groups to trim it.

5) We're chaning default behavior of a security-critical package that may affect systems that have run in production of years.

Most of this is just speculation, of course. But the fact remains that the default behavior of a package that deals with elevating user priviledges has been changed, and for no real reason at all. "If it ain't broke, don't fix it" certain seems fitting, I think.

---
 package/sudo/Config.in | 13 +++++++++++++
 package/sudo/sudo.mk   |  2 ++
 2 files changed, 15 insertions(+)
package/sudo/Config.in +13 -0
index cbef15d67b..982a4ffaa8 100644
@@ -9,3 +9,16 @@ config BR2_PACKAGE_SUDO
 	  but still allow people to get their work done.
 
 	  http://www.sudo.ws/sudo/
+
+if BR2_PACKAGE_SUDO
+
+config BR2_PACKAGE_SUDO_GROUP_AND_RULE
+	bool "add group 'sudo' and enable associated sudoers rule"
+	default n
+	help
+	  Creates a group named 'sudo', and enables the following rule
+	  in the /etc/sudoers configuration file that allows members of
+	  group 'sudo' to execute any command as root:
+
+	  %sudo ALL=(ALL) ALL
+endif
package/sudo/sudo.mk +2 -0
index 7d52eb0b57..b8c3924d8a 100644
@@ -74,9 +74,11 @@ define SUDO_USERS
 	- - sudo -1 - - - -
 endef
 
+ifeq ($(BR2_PACKAGE_SUDO_GROUP_AND_RULE),y)
 define SUDO_ENABLE_SUDO_GROUP_RULE
 	$(SED) '/^# \%sudo\tALL=(ALL) ALL/s/^# //' $(TARGET_DIR)/etc/sudoers
 endef
 SUDO_POST_INSTALL_TARGET_HOOKS += SUDO_ENABLE_SUDO_GROUP_RULE
+endif
 
 $(eval $(autotools-package))
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 package/sudo: make adding 'sudo' group+rule optional

Hello Stephan,

Thanks for your patch!

Quoted 33 lines · On Tue, 5 Nov 2019 23:42:29 +0100 Stephan Henningsen <[email protected]>…

From: Stephan Henningsen <[email protected]>

I have concerns about the change that was made to my original patch; Instead of having the 'sudo' group and sudoers rule enabled by the user manually and thereby giving her concent, a change was made to apply the option silently.

While I do understand that making this all default will make the user experience a bit smoother, I fear that this won't be the case for everyone.

My motivations for making it an option to begin with (and for this follow-up patch) are the following:

1) Not everyone may be interested in the added rule to /etc/sudoers; it may even conflict with a custom rule. For example if a custom rule was added that does not prompt for user password, then the newly added rule, which does prompt for user password, maybe break automated cronjobs that rely on sudo for elevated priviledges without a password prompt.

2) Adding this group and rule is only one of many use-cases of the sudo package; some people may prefer adding custom rules that only allow certain well-known users (e.g. alice, bob) or certain system groups (e.g. wheel, daemon) to become root. These users may have to manually revert the changes now done to their /etc/sudoers.

3) If only a little, this addition adds to the size of the system's attack surface, potentially inadvertently allowing users to become root.

4) Not everyone may be interested in the added non-standard system group 'sudo'; they may even have to manually revert the changes now done to their /etc/groups to trim it.

Quoted 7 lines

5) We're chaning default behavior of a security-critical package that may affect systems that have run in production of years.

Most of this is just speculation, of course. But the fact remains that the default behavior of a package that deals with elevating user priviledges has been changed, and for no real reason at all. "If it ain't broke, don't fix it" certain seems fitting, I think.

We can't provide options for every bit of system configuration. Having a sudo group, configured by default so that the users in this group can use sudo, seems like a sensible default. Buildroot has traditionally had a policy of: let's have sensible/basic defaults for the configuration of most packages, and leave it up to the user to further customize such defaults.

Here, it is pretty trivial to override the sudoers file with its own version in a rootfs-overlay, and also trivial to remove the sudo group from /etc/group in a post-build script if really needed.

So overall, I agree with the change Yann did to simply make the sudo group and sudoers unconditional.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com