drm/amd/powerplay: correct Arcturus OD support
Subsystems (2)
PATCH 1/1 drm/amd/powerplay: correct Arcturus OD support
OD is not supported on Arcturus. Thus the pp_od_clk_voltage sysfs interface is also not supported.
--- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/powerplay/amdgpu_smu.c +5 -3
@@ -714,6 +714,9 @@ static int smu_set_funcs(struct amdgpu_device *adev) {struct smu_context *smu = &adev->smu; +if (adev->pm.pp_feature &PP_OVERDRIVE_MASK ) + smu->od_enabled = true; +switch (adev->asic_type) {case CHIP_VEGA20 :vega20_set_ppt_funcs (smu);
@@ -725,6 +728,8 @@ static int smu_set_funcs(struct amdgpu_device *adev)break ;case CHIP_ARCTURUS :arcturus_set_ppt_funcs (smu); +/* OD is not supported on Arcturus */ + smu->od_enabled =false;break ;case CHIP_RENOIR :renoir_set_ppt_funcs (smu);
@@ -733,9 +738,6 @@ static int smu_set_funcs(struct amdgpu_device *adev)return -EINVAL ; } -if (adev->pm.pp_feature &PP_OVERDRIVE_MASK ) - smu->od_enabled = true; -return 0 ; }
Signature · 6 lines
2.23.0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): [email protected]
Alex Deucher
Reviewed-byQuoted 6 lines · Evan
OD is not supported on Arcturus. Thus the
pp_od_clk_voltagesysfs interface is also not supported.Change-Id Ib70632a55a0980cf04c3432d43dbcf869cd1b4bfSigned-off-by Evan Quan <[email protected]>
You might want to check with Chris and Kent about this. I think there is a use case for OD on ROCm in some cases. Assuming they are ok with it,
Alex
Quoted 40 lines
--- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)drivers/gpu/drm/amd/powerplay/amdgpu_smu.c +5
-4@@ -714,6 +714,9 @@ static int smu_set_funcs(struct amdgpu_device *adev) {struct smu_context *smu = &adev->smu; +if (adev->pm.pp_feature &PP_OVERDRIVE_MASK ) + smu->od_enabled = true; +switch (adev->asic_type) {case CHIP_VEGA20 :vega20_set_ppt_funcs (smu);@@ -725,6 +728,8 @@ static int smu_set_funcs(struct amdgpu_device *adev)break ;case CHIP_ARCTURUS :arcturus_set_ppt_funcs (smu); +/* OD is not supported on Arcturus */ + smu->od_enabled =false;break ;case CHIP_RENOIR :renoir_set_ppt_funcs (smu);@@ -733,9 +738,6 @@ static int smu_set_funcs(struct amdgpu_device *adev)return -EINVAL ; } -if (adev->pm.pp_feature &PP_OVERDRIVE_MASK ) - smu->od_enabled = true; -return 0 ; } --2.23.0
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): CADnq5_PxWYGE1-uL+pey-Rwj6EiP2EuO+Y4N7aYNL85P3QOeUw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Russell, Kent
Reviewed-by Alex DeucherWhile we do like OverDrive being available (mostly our open-source community users who are using consumer cards vs server cards), if it's not supported on the HW for whatever reason, we'll adapt. If we get a request later for its enablement (since OverDrive is consumer-card-only in general, and I personally haven't seen any Arcturus consumer cards), we can discuss then. It's fine with Chris and I in that regard.
Kent
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Alex Deucher
Sent: Thursday, November 7, 2019 8:58 AM
To: Quan, Evan <[email protected]>
Cc: Li, Candice <[email protected]>; [email protected]; Freehill, Chris <[email protected]>
Subject: Re: [PATCH] drm/amd/powerplay: correct Arcturus OD support
Quoted 6 lines · Evan
OD is not supported on Arcturus. Thus the
pp_od_clk_voltagesysfs interface is also not supported.Change-Id Ib70632a55a0980cf04c3432d43dbcf869cd1b4bfSigned-off-by Evan Quan <[email protected]>
You might want to check with Chris and Kent about this. I think there is a use case for OD on ROCm in some cases. Assuming they are ok with it,
Alex
Quoted 41 lines
--- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)drivers/gpu/drm/amd/powerplay/amdgpu_smu.c +3
-0@@ -714,6 +714,9 @@ static int smu_set_funcs(struct amdgpu_device *adev) {struct smu_context *smu = &adev->smu; +if (adev->pm.pp_feature &PP_OVERDRIVE_MASK ) + smu->od_enabled = true; +switch (adev->asic_type) {case CHIP_VEGA20 : vega20_set_ppt_funcs(smu); @@ -725,6 +728,8 @@ staticint
smu_set_funcs(struct amdgpu_device *adev)break; case CHIP_ARCTURUS: arcturus_set_ppt_funcs(smu);drivers/gpu/drm/amd/powerplay/amdgpu_smu.c +2
-0+/* OD is not supported on Arcturus */ + smu->od_enabled =false;break ;case CHIP_RENOIR : renoir_set_ppt_funcs(smu); @@ -733,9 +738,6 @@ staticint
smu_set_funcs(struct amdgpu_device *adev)return -EINVAL; }drivers/gpu/drm/amd/powerplay/amdgpu_smu.c +0
-4-if (adev->pm.pp_feature &PP_OVERDRIVE_MASK ) - smu->od_enabled = true; -return 0 ; } --2.23.0
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): CY4PR1201MB2533B1569C97729EA15C8B8085780-1iTaO6aE1DCmssYNuJz6EmrFom/aUZj6nBOFsp37pqbUKgpGm//BTAC/[email protected]
Freehill, Chris
Reviewed-by Alex DeucherI think Kent has more insight with demand for this feature than I do, so I defer to his opinion. I haven't received any feedback on that API.
Main thing is that if it's not supported, don't have the file visible.
Thanks,
Chris
-----Original Message-----
From: Russell, Kent <[email protected]>
Sent: Thursday, November 7, 2019 8:05 AM
To: Alex Deucher <[email protected]>; Quan, Evan <[email protected]>
Cc: Li, Candice <[email protected]>; [email protected]; Freehill, Chris <[email protected]>
Subject: RE: [PATCH] drm/amd/powerplay: correct Arcturus OD support
While we do like OverDrive being available (mostly our open-source community users who are using consumer cards vs server cards), if it's not supported on the HW for whatever reason, we'll adapt. If we get a request later for its enablement (since OverDrive is consumer-card-only in general, and I personally haven't seen any Arcturus consumer cards), we can discuss then. It's fine with Chris and I in that regard.
Kent
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Alex Deucher
Sent: Thursday, November 7, 2019 8:58 AM
To: Quan, Evan <[email protected]>
Cc: Li, Candice <[email protected]>; [email protected]; Freehill, Chris <[email protected]>
Subject: Re: [PATCH] drm/amd/powerplay: correct Arcturus OD support
Quoted 6 lines · Evan
OD is not supported on Arcturus. Thus the
pp_od_clk_voltagesysfs interface is also not supported.Change-Id Ib70632a55a0980cf04c3432d43dbcf869cd1b4bfSigned-off-by Evan Quan <[email protected]>
You might want to check with Chris and Kent about this. I think there is a use case for OD on ROCm in some cases. Assuming they are ok with it,
Alex
Quoted 41 lines
--- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)drivers/gpu/drm/amd/powerplay/amdgpu_smu.c +3
-0@@ -714,6 +714,9 @@ static int smu_set_funcs(struct amdgpu_device *adev) {struct smu_context *smu = &adev->smu; +if (adev->pm.pp_feature &PP_OVERDRIVE_MASK ) + smu->od_enabled = true; +switch (adev->asic_type) {case CHIP_VEGA20 : vega20_set_ppt_funcs(smu); @@ -725,6 +728,8 @@ staticint
smu_set_funcs(struct amdgpu_device *adev)break; case CHIP_ARCTURUS: arcturus_set_ppt_funcs(smu);drivers/gpu/drm/amd/powerplay/amdgpu_smu.c +2
-0+/* OD is not supported on Arcturus */ + smu->od_enabled =false;break ;case CHIP_RENOIR : renoir_set_ppt_funcs(smu); @@ -733,9 +738,6 @@ staticint
smu_set_funcs(struct amdgpu_device *adev)return -EINVAL; }drivers/gpu/drm/amd/powerplay/amdgpu_smu.c +0
-4-if (adev->pm.pp_feature &PP_OVERDRIVE_MASK ) - smu->od_enabled = true; -return 0 ; } --2.23.0
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Feng, Kenneth
Reviewed-by Kenneth Feng-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Quan, Evan
Sent: Thursday, November 7, 2019 3:39 PM
To: [email protected]
Cc: Li, Candice <[email protected]>; Quan, Evan <[email protected]>; Freehill, Chris <[email protected]>
Subject: [PATCH] drm/amd/powerplay: correct Arcturus OD support
[CAUTION: External Email]
OD is not supported on Arcturus. Thus the pp_od_clk_voltage sysfs interface is also not supported.
--- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/powerplay/amdgpu_smu.c +3 -0
@@ -714,6 +714,9 @@ static int smu_set_funcs(struct amdgpu_device *adev) {struct smu_context *smu = &adev->smu; +if (adev->pm.pp_feature &PP_OVERDRIVE_MASK ) + smu->od_enabled = true; +switch (adev->asic_type) {case CHIP_VEGA20 : vega20_set_ppt_funcs(smu); @@ -725,6 +728,8 @@ static int smu_set_funcs(struct amdgpu_device *adev) break;
case CHIP_ARCTURUS:
arcturus_set_ppt_funcs(smu);
+ /* OD is not supported on Arcturus */
+ smu->od_enabled =false;
break;
case CHIP_RENOIR:
renoir_set_ppt_funcs(smu); @@ -733,9 +738,6 @@ static int smu_set_funcs(struct amdgpu_device *adev)
return -EINVAL;
}- if (adev->pm.pp_feature & PP_OVERDRIVE_MASK)
- smu->od_enabled = true;
-
return 0;
}
--
2.23.0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx