Skip to contentSkip to conversation

net/ice: fix tunnel profile existence check

PATCH Superseded Yahui Cao 4 participants 5 messages Nov 5, 2019 – Nov 7, 2019 Network drivers

lore
Share & tools
lore

Yahui Cao

author
#0 lore raw

PATCH 1/1 net/ice: fix tunnel profile existence check

Fixes d5ea22e9f4a5 ("net/ice: configure HW FDIR rule")
---
 drivers/net/ice/ice_fdir_filter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ice/ice_fdir_filter.c +1 -1
index 736ccd54e..685383c1a 100644
@@ -646,7 +646,7 @@ ice_fdir_hw_tbl_conf(struct ice_pf *pf, struct ice_vsi *vsi,
 			if (!memcmp(ori_seg, seg, sizeof(*seg)))
 				return -EAGAIN;
 		} else {
-			if (!memcmp(ori_seg, &seg[1], sizeof(*seg)))
+			if (!memcmp(&ori_seg[1], &seg[1], sizeof(*seg)))
 				return -EAGAIN;
 		}
 
Signature · 1 line
2.17.1
#1 lore raw
Quoted 12 lines

-----Original Message-----
From: Cao, Yahui
Sent: Tuesday, November 5, 2019 7:37 PM
To: Yang, Qiming <[email protected]>; Lu, Wenzhuo <[email protected]>
Cc: [email protected]; Zhang, Qi Z <[email protected]>; Cao, Yahui <[email protected]>; Ye, Xiaolong <[email protected]>; Xing, Beilei <[email protected]>
Subject: [PATCH] net/ice: fix tunnel profile existence check

The patch looks OK for me.
Could you detail some description for the issue?

Beilei

Quoted 24 lines
Fixes d5ea22e9f4a5 ("net/ice: configure HW FDIR rule")
---
 drivers/net/ice/ice_fdir_filter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ice/ice_fdir_filter.c +1 -2
index 736ccd54e..685383c1a 100644
@@ -646,7 +646,7 @@ ice_fdir_hw_tbl_conf(struct ice_pf *pf, struct ice_vsi
 *vsi,
 			if (!memcmp(ori_seg, seg, sizeof(*seg)))
 				return -EAGAIN;
 		} else {
-			if (!memcmp(ori_seg, &seg[1], sizeof(*seg)))
+			if (!memcmp(&ori_seg[1], &seg[1], sizeof(*seg)))
 				return -EAGAIN;
 		}
 
--

2.17.1

author
#2 lore raw

PATCH v2 1/1 net/ice: fix FDIR tunnel profile existence check

In reply to Yahui Cao

If first rule is issued and then the second rule is issued with the same input set as first rule's, FDIR driver can't find there is an identical input set.

Fixes d5ea22e9f4a5 ("net/ice: configure HW FDIR rule")
---
 drivers/net/ice/ice_fdir_filter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ice/ice_fdir_filter.c +1 -1
index 736ccd54e..685383c1a 100644
@@ -646,7 +646,7 @@ ice_fdir_hw_tbl_conf(struct ice_pf *pf, struct ice_vsi *vsi,
 			if (!memcmp(ori_seg, seg, sizeof(*seg)))
 				return -EAGAIN;
 		} else {
-			if (!memcmp(ori_seg, &seg[1], sizeof(*seg)))
+			if (!memcmp(&ori_seg[1], &seg[1], sizeof(*seg)))
 				return -EAGAIN;
 		}
 
Signature · 1 line
2.17.1
Acked-by on v2 1/1
#3 lore raw

Re: [dpdk-dev] [PATCH v2] net/ice: fix FDIR tunnel profile existence check

Quoted 12 lines

-----Original Message-----
From: Cao, Yahui <[email protected]>
Sent: Tuesday, November 5, 2019 9:37 PM
To: Yang, Qiming <[email protected]>; Lu, Wenzhuo <[email protected]>
Cc: [email protected]; Zhang, Qi Z <[email protected]>; Cao, Yahui <[email protected]>; Ye, Xiaolong <[email protected]>; Xing, Beilei <[email protected]>
Subject: [PATCH v2] net/ice: fix FDIR tunnel profile existence check

Quoted 7 lines

If first rule is issued and then the second rule is issued with the same input set as first rule's, FDIR driver can't find there is an identical input set.

Fixes d5ea22e9f4a5 ("net/ice: configure HW FDIR rule")
Applied
#4 lore raw

Re: [dpdk-dev] [PATCH v2] net/ice: fix FDIR tunnel profile existence check

In reply to Yahui Cao
Quoted 28 lines · Yahui Cao

If first rule is issued and then the second rule is issued with the same input set as first rule's, FDIR driver can't find there is an identical input set.

Fixes d5ea22e9f4a5 ("net/ice: configure HW FDIR rule")

---
drivers/net/ice/ice_fdir_filter.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ice/ice_fdir_filter.c +1 -1
index 736ccd54e..685383c1a 100644
@@ -646,7 +646,7 @@ ice_fdir_hw_tbl_conf(struct ice_pf *pf, struct ice_vsi *vsi,
 			if (!memcmp(ori_seg, seg, sizeof(*seg)))
 				return -EAGAIN;
 		} else {
-			if (!memcmp(ori_seg, &seg[1], sizeof(*seg)))
+			if (!memcmp(&ori_seg[1], &seg[1], sizeof(*seg)))
 				return -EAGAIN;
 		}
 
Signature · 1 line
2.17.1

Applied to dpdk-next-net-intel. Thanks.