dt-bindings: gpu: mali-midgard: add samsung exynos 5420 compatible
Subsystems (4)
PATCH v4 1/2 dt-bindings: gpu: mali-midgard: add samsung exynos 5420 compatible
Add "samsung,exynos5420-mali" binding
--- Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml +4 -1
@@ -38,9 +38,12 @@ properties: - enum: - samsung,exynos5433-mali - const: arm,mali-t760 + - items: + - enum: + - samsung,exynos5420-mali + - const: arm,mali-t628 # "arm,mali-t624" - # "arm,mali-t628" # "arm,mali-t830" # "arm,mali-t880"
Signature · 1 line
2.14.1
PATCH v4 2/2 ARM: dts: exynos5420: add mali dt node and enable mali on Odroid XU3/4
Add device tree node for Mali GPU for Exynos 542x SoC. GPU is disabled by default, and is enabled for each board after the regulator is defined. Tested on Odroid-XU4.
Changes since v3:
- fixed compatible to match bindings
Changes since v2:
- separate patch for bindings
- fixed bindings typo
Changes since v1:
- used generic node and label for GPU
- added bindings for compatible
- fixed irq indentation
- fixed interrupt-names to match bindings
- added cooling cells for future TMU connection
- used generic node and label for GPU opp table
- removed always-on from SoC GPU regulator
--- arch/arm/boot/dts/exynos5420.dtsi | 50 +++++++++++++++++++++++++++ arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 6 +++- 2 files changed, 55 insertions(+), 1 deletion(-)
arch/arm/boot/dts/exynos5420.dtsi +50 -0
@@ -670,6 +670,56 @@ iommus = <&sysmmu_gscl1>; }; + gpu: gpu@11800000 { + compatible = "samsung,exynos5420-mali", "arm,mali-t628"; + reg = <0x11800000 0x5000>; + interrupts = <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "job", "mmu", "gpu"; + + clocks = <&clock CLK_G3D>; + clock-names = "core"; + power-domains = <&g3d_pd>; + operating-points-v2 = <&gpu_opp_table>; + + status = "disabled"; + #cooling-cells = <2>; + + gpu_opp_table: opp-table { + compatible = "operating-points-v2"; + + opp@177000000 { + opp-hz = /bits/ 64 <177000000>; + opp-microvolt = <812500>; + }; + opp@266000000 { + opp-hz = /bits/ 64 <266000000>; + opp-microvolt = <862500>; + }; + opp@350000000 { + opp-hz = /bits/ 64 <350000000>; + opp-microvolt = <912500>; + }; + opp-420000000 { + opp-hz = /bits/ 64 <420000000>; + opp-microvolt = <962500>; + }; + opp-480000000 { + opp-hz = /bits/ 64 <480000000>; + opp-microvolt = <1000000>; + }; + opp-543000000 { + opp-hz = /bits/ 64 <543000000>; + opp-microvolt = <1037500>; + }; + opp-600000000 { + opp-hz = /bits/ 64 <600000000>; + opp-microvolt = <1150000>; + }; + }; + }; + scaler_0: scaler@12800000 { compatible = "samsung,exynos5420-scaler"; reg = <0x12800000 0x1294>;
arch/arm/boot/dts/exynos5422-odroid-core.dtsi +5 -1
@@ -522,7 +522,6 @@ regulator-name = "vdd_g3d"; regulator-min-microvolt = <800000>; regulator-max-microvolt = <1400000>; - regulator-always-on; regulator-boot-on; regulator-state-mem {
@@ -659,6 +658,11 @@ status = "okay"; }; +&gpu { + mali-supply = <&buck4_reg>; + status = "okay"; +}; + &rtc { status = "okay"; clocks = <&clock CLK_RTC>, <&s2mps11_osc S2MPS11_CLK_AP>;
Signature · 1 line
2.14.1
Krzysztof Kozlowski
maintainerRe: [PATCH v4 2/2] ARM: dts: exynos5420: add mali dt node and enable mali on Odroid XU3/4
Quoted 6 lines · Marian Mihailescu
Add device tree node for Mali GPU for Exynos 542x SoC. GPU is disabled by default, and is enabled for each board after the regulator is defined. Tested on Odroid-XU4.
Changes since v3:
- fixed compatible to match bindings
Changelog does not go to commit message. Put it after msg separator (---).
Except this looks good so I will fix it up while applying.
Best regards,
Krzysztof
Quoted 108 lines
Changes since v2:
- separate patch for bindings
- fixed bindings typoChanges since v1:
- used generic node and label for GPU
- added bindings for compatible
- fixed irq indentation
- fixed interrupt-names to match bindings
- added cooling cells for future TMU connection
- used generic node and label for GPU opp table
- removed always-on from SoC GPU regulatorSigned-off-by Marian Mihailescu <[email protected]>--- arch/arm/boot/dts/exynos5420.dtsi | 50 +++++++++++++++++++++++++++ arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 6 +++- 2 files changed, 55 insertions(+), 1 deletion(-)arch/arm/boot/dts/exynos5420.dtsi +50
-0@@ -670,6 +670,56 @@ iommus = <&sysmmu_gscl1>; }; + gpu: gpu@11800000 { + compatible = "samsung,exynos5420-mali", "arm,mali-t628"; + reg = <0x11800000 0x5000>; + interrupts = <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "job", "mmu", "gpu"; + + clocks = <&clock CLK_G3D>; + clock-names = "core"; + power-domains = <&g3d_pd>; + operating-points-v2 = <&gpu_opp_table>; + + status = "disabled"; + #cooling-cells = <2>; + + gpu_opp_table: opp-table { + compatible = "operating-points-v2"; + + opp@177000000 { + opp-hz = /bits/ 64 <177000000>; + opp-microvolt = <812500>; + }; + opp@266000000 { + opp-hz = /bits/ 64 <266000000>; + opp-microvolt = <862500>; + }; + opp@350000000 { + opp-hz = /bits/ 64 <350000000>; + opp-microvolt = <912500>; + }; + opp-420000000 { + opp-hz = /bits/ 64 <420000000>; + opp-microvolt = <962500>; + }; + opp-480000000 { + opp-hz = /bits/ 64 <480000000>; + opp-microvolt = <1000000>; + }; + opp-543000000 { + opp-hz = /bits/ 64 <543000000>; + opp-microvolt = <1037500>; + }; + opp-600000000 { + opp-hz = /bits/ 64 <600000000>; + opp-microvolt = <1150000>; + }; + }; + }; + scaler_0: scaler@12800000 { compatible = "samsung,exynos5420-scaler"; reg = <0x12800000 0x1294>;arch/arm/boot/dts/exynos5422-odroid-core.dtsi +5
-1@@ -522,7 +522,6 @@ regulator-name = "vdd_g3d"; regulator-min-microvolt = <800000>; regulator-max-microvolt = <1400000>; - regulator-always-on; regulator-boot-on; regulator-state-mem {@@ -659,6 +658,11 @@ status = "okay"; }; +&gpu { + mali-supply = <&buck4_reg>; + status = "okay"; +}; + &rtc { status = "okay"; clocks = <&clock CLK_RTC>, <&s2mps11_osc S2MPS11_CLK_AP>;Signature · 1 line
2.14.1
Krzysztof Kozlowski
maintainerRe: [PATCH v4 2/2] ARM: dts: exynos5420: add mali dt node and enable mali on Odroid XU3/4
In reply to Marian MihailescuQuoted 20 lines · Marian Mihailescu
Add device tree node for Mali GPU for Exynos 542x SoC. GPU is disabled by default, and is enabled for each board after the regulator is defined. Tested on Odroid-XU4.
Changes since v3:
- fixed compatible to match bindingsChanges since v2:
- separate patch for bindings
- fixed bindings typoChanges since v1:
- used generic node and label for GPU
- added bindings for compatible
- fixed irq indentation
- fixed interrupt-names to match bindings
- added cooling cells for future TMU connection
- used generic node and label for GPU opp table
- removed always-on from SoC GPU regulator
Quoted 4 lines
Signed-off-by Marian Mihailescu <[email protected]>--- arch/arm/boot/dts/exynos5420.dtsi | 50 +++++++++++++++++++++++++++ arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 6 +++-
Hi,
Unfortunately this does not apply around exynos5422-odroid-core.dtsi. I think there were no changes to this file in current development cycle so I am surprised that there are conflicts.
On what version were you basing your patch? Was it tested on latest kernel? The patches should be based usually on one of:
1. current-rc1 (v5.4-rc1)
2. latest-rc (v5.4-rc7)
3. maintainer's tree (my next/dt or for-next)
4. linux-next
In all other cases the patch would need rebasing and re-testing.
Best regards,
Krzysztof
Re: [PATCH v4 2/2] ARM: dts: exynos5420: add mali dt node and enable mali on Odroid XU3/4
Apologies - it was applied and tested on latest -rc, however I had gpu_tmu enabled as well (by adding status=okay), line which was not included in the patch and was the cause of it not applying. Fixed it in the coming v5, tested and applies on a fresh -rc7.
Either I've been missing something or nothing has been going on. (K. E. Gordon)
Quoted 45 lines · Krzysztof Kozlowski
Quoted 20 lines · Marian Mihailescu
Add device tree node for Mali GPU for Exynos 542x SoC. GPU is disabled by default, and is enabled for each board after the regulator is defined. Tested on Odroid-XU4.
Changes since v3:
- fixed compatible to match bindingsChanges since v2:
- separate patch for bindings
- fixed bindings typoChanges since v1:
- used generic node and label for GPU
- added bindings for compatible
- fixed irq indentation
- fixed interrupt-names to match bindings
- added cooling cells for future TMU connection
- used generic node and label for GPU opp table
- removed always-on from SoC GPU regulatorQuoted 4 lines
Signed-off-by Marian Mihailescu <[email protected]>--- arch/arm/boot/dts/exynos5420.dtsi | 50 +++++++++++++++++++++++++++ arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 6 +++-Hi,
Unfortunately this does not apply around
exynos5422-odroid-core.dtsi. I think there were no changes to this file in current development cycle so I am surprised that there are conflicts.On what version were you basing your patch? Was it tested on latest kernel? The patches should be based usually on one of:
1. current-rc1 (v5.4-rc1)
2. latest-rc (v5.4-rc7)
3. maintainer's tree (my next/dt or for-next)
4. linux-nextIn all other cases the patch would need rebasing and re-testing.
Best regards,
Krzysztof
Quoted 12 lines · Marian Mihailescu
Add "samsung,exynos5420-mali" binding
Signed-off-by Marian Mihailescu <[email protected]>--- Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml +0
-0
Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml properties: · line 44
Quoted 7 lines
Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml +4
-0@@ -38,9 +38,12 @@ properties: - enum: - samsung,exynos5433-mali - const: arm,mali-t760 + - items: + - enum: + - samsung,exynos5420-mali + - const: arm,mali-t628
I would prefer to order it logically/alphabetically, so after 5250 and before 5433. With that change:
Best regards,
Krzysztof
Quoted 9 lines · Krzysztof Kozlowski
Quoted 7 lines · Marian Mihailescu
Add "samsung,exynos5420-mali" binding
Signed-off-by Marian Mihailescu <[email protected]>--- Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Quoted 15 lines
Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml properties: · line 44
Quoted 12 lines
Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml +4
-0@@ -38,9 +38,12 @@ properties: - enum: - samsung,exynos5433-mali - const: arm,mali-t760 + - items: + - enum: + - samsung,exynos5420-mali + - const: arm,mali-t628I would prefer to order it logically/alphabetically, so after 5250 and before 5433. With that change:
I didn't see your comment, but that's what I did. This has been re-ordered to be sorted by Mali part numbers (though partially to avoid a conflict). Good thing Arm and Samsung agree newer/better/faster should be higher numbers. :)
Rob
Quoted 10 lines
Quoted 3 lines
I would prefer to order it logically/alphabetically, so after 5250 and before 5433. With that change:
I didn't see your comment, but that's what I did. This has been re-ordered to be sorted by Mali part numbers (though partially to avoid a conflict). Good thing Arm and Samsung agree newer/better/faster should be higher numbers. :)
Rob
Thank you.
-Marian
Quoted 7 lines · Marian Mihailescu
Add "samsung,exynos5420-mali" binding
Signed-off-by Marian Mihailescu <[email protected]>--- Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Applied, thanks.
Rob