Skip to contentSkip to conversation

KVM: coalesced_mmio: cleanup kvm_coalesced_mmio_init()

PATCH New Vitaly Kuznetsov 1 participant 1 message Nov 7, 2019 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 KVM: coalesced_mmio: cleanup kvm_coalesced_mmio_init()

Neither 'ret' variable nor 'out_err' label is really needed.

---
 virt/kvm/coalesced_mmio.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
virt/kvm/coalesced_mmio.c +2 -6
index 8ffd07e2a160..00c747dbc82e 100644
@@ -110,14 +110,11 @@ static const struct kvm_io_device_ops coalesced_mmio_ops = {
 int kvm_coalesced_mmio_init(struct kvm *kvm)
 {
 	struct page *page;
-	int ret;
 
-	ret = -ENOMEM;
 	page = alloc_page(GFP_KERNEL | __GFP_ZERO);
 	if (!page)
-		goto out_err;
+		return -ENOMEM;
 
-	ret = 0;
 	kvm->coalesced_mmio_ring = page_address(page);
 
 	/*
@@ -128,8 +125,7 @@ int kvm_coalesced_mmio_init(struct kvm *kvm)
 	spin_lock_init(&kvm->ring_lock);
 	INIT_LIST_HEAD(&kvm->coalesced_zones);
 
-out_err:
-	return ret;
+	return 0;
 }
 
 void kvm_coalesced_mmio_free(struct kvm *kvm)
Signature · 1 line
2.20.1