Skip to contentSkip to conversation

drm/i915/bios: use a flag for vbt hdmi level shift presence

PATCH In review Jani Nikula 3 participants 6 messages Nov 7, 2019 – Nov 12, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/bios: use a flag for vbt hdmi level shift presence

The pre-initialized magic value is a bit silly, switch to a flag instead.

v2: Reduce paranoia to a single sanity check (Ville)

Cc Ville Syrjälä <[email protected]>
---
 drivers/gpu/drm/i915/display/intel_bios.c | 10 +---------
 drivers/gpu/drm/i915/display/intel_ddi.c  | 13 +++++++------
 drivers/gpu/drm/i915/i915_drv.h           |  8 ++------
 3 files changed, 10 insertions(+), 21 deletions(-)
drivers/gpu/drm/i915/display/intel_bios.c +1 -9
index a03f56b7b4ef..c19b234bebe6 100644
@@ -1509,6 +1509,7 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv,
 			      port_name(port),
 			      hdmi_level_shift);
 		info->hdmi_level_shift = hdmi_level_shift;
+		info->hdmi_level_shift_set = true;
 	}
 
 	if (bdb_version >= 204) {
@@ -1692,8 +1693,6 @@ parse_general_definitions(struct drm_i915_private *dev_priv,
 static void
 init_vbt_defaults(struct drm_i915_private *dev_priv)
 {
-	enum port port;
-
 	dev_priv->vbt.crt_ddc_pin = GMBUS_PIN_VGADDC;
 
 	/* Default to having backlight */
@@ -1721,13 +1720,6 @@ init_vbt_defaults(struct drm_i915_private *dev_priv)
 	dev_priv->vbt.lvds_ssc_freq = intel_bios_ssc_frequency(dev_priv,
 			!HAS_PCH_SPLIT(dev_priv));
 	DRM_DEBUG_KMS("Set default to SSC at %d kHz\n", dev_priv->vbt.lvds_ssc_freq);
-
-	for_each_port(port) {
-		struct ddi_vbt_port_info *info =
-			&dev_priv->vbt.ddi_port_info[port];
-
-		info->hdmi_level_shift = HDMI_LEVEL_SHIFT_UNKNOWN;
-	}
 }
 
 /* Defaults to initialize only if there is no VBT. */
drivers/gpu/drm/i915/display/intel_ddi.c +7 -6
index 398c6f054a6e..4018c2e2a6fc 100644
@@ -888,11 +888,10 @@ icl_get_combo_buf_trans(struct drm_i915_private *dev_priv, int type, int rate,
 
 static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port port)
 {
+	struct ddi_vbt_port_info *port_info = &dev_priv->vbt.ddi_port_info[port];
 	int n_entries, level, default_entry;
 	enum phy phy = intel_port_to_phy(dev_priv, port);
 
-	level = dev_priv->vbt.ddi_port_info[port].hdmi_level_shift;
-
 	if (INTEL_GEN(dev_priv) >= 12) {
 		if (intel_phy_is_combo(dev_priv, phy))
 			icl_get_combo_buf_trans(dev_priv, INTEL_OUTPUT_HDMI,
@@ -927,12 +926,14 @@ static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port por
 		return 0;
 	}
 
-	/* Choose a good default if VBT is badly populated */
-	if (level == HDMI_LEVEL_SHIFT_UNKNOWN || level >= n_entries)
-		level = default_entry;
-
 	if (WARN_ON_ONCE(n_entries == 0))
 		return 0;
+
+	if (port_info->hdmi_level_shift_set)
+		level = port_info->hdmi_level_shift;
+	else
+		level = default_entry;
+
 	if (WARN_ON_ONCE(level >= n_entries))
 		level = n_entries - 1;
 
drivers/gpu/drm/i915/i915_drv.h +2 -6
index 7e0f67babe20..67bdfe6de3fa 100644
@@ -627,13 +627,9 @@ struct ddi_vbt_port_info {
 
 	int max_tmds_clock;
 
-	/*
-	 * This is an index in the HDMI/DVI DDI buffer translation table.
-	 * The special value HDMI_LEVEL_SHIFT_UNKNOWN means the VBT didn't
-	 * populate this field.
-	 */
-#define HDMI_LEVEL_SHIFT_UNKNOWN	0xff
+	/* This is an index in the HDMI/DVI DDI buffer translation table. */
 	u8 hdmi_level_shift;
+	u8 hdmi_level_shift_set:1;
 
 	u8 supports_dvi:1;
 	u8 supports_hdmi:1;
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Jani Nikula

The pre-initialized magic value is a bit silly, switch to a flag instead.

v2: Reduce paranoia to a single sanity check (Ville)

Cc Ville Syrjälä <[email protected]>

stands

Quoted 99 lines
---
 drivers/gpu/drm/i915/display/intel_bios.c | 10 +---------
 drivers/gpu/drm/i915/display/intel_ddi.c  | 13 +++++++------
 drivers/gpu/drm/i915/i915_drv.h           |  8 ++------
 3 files changed, 10 insertions(+), 21 deletions(-)
drivers/gpu/drm/i915/display/intel_bios.c +1 -9
index a03f56b7b4ef..c19b234bebe6 100644
@@ -1509,6 +1509,7 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv,
 			      port_name(port),
 			      hdmi_level_shift);
 		info->hdmi_level_shift = hdmi_level_shift;
+		info->hdmi_level_shift_set = true;
 	}
 
 	if (bdb_version >= 204) {
@@ -1692,8 +1693,6 @@ parse_general_definitions(struct drm_i915_private *dev_priv,
 static void
 init_vbt_defaults(struct drm_i915_private *dev_priv)
 {
-	enum port port;
-
 	dev_priv->vbt.crt_ddc_pin = GMBUS_PIN_VGADDC;
 
 	/* Default to having backlight */
@@ -1721,13 +1720,6 @@ init_vbt_defaults(struct drm_i915_private *dev_priv)
 	dev_priv->vbt.lvds_ssc_freq = intel_bios_ssc_frequency(dev_priv,
 			!HAS_PCH_SPLIT(dev_priv));
 	DRM_DEBUG_KMS("Set default to SSC at %d kHz\n", dev_priv->vbt.lvds_ssc_freq);
-
-	for_each_port(port) {
-		struct ddi_vbt_port_info *info =
-			&dev_priv->vbt.ddi_port_info[port];
-
-		info->hdmi_level_shift = HDMI_LEVEL_SHIFT_UNKNOWN;
-	}
 }
 
 /* Defaults to initialize only if there is no VBT. */
drivers/gpu/drm/i915/display/intel_ddi.c +7 -6
index 398c6f054a6e..4018c2e2a6fc 100644
@@ -888,11 +888,10 @@ icl_get_combo_buf_trans(struct drm_i915_private *dev_priv, int type, int rate,
 
 static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port port)
 {
+	struct ddi_vbt_port_info *port_info = &dev_priv->vbt.ddi_port_info[port];
 	int n_entries, level, default_entry;
 	enum phy phy = intel_port_to_phy(dev_priv, port);
 
-	level = dev_priv->vbt.ddi_port_info[port].hdmi_level_shift;
-
 	if (INTEL_GEN(dev_priv) >= 12) {
 		if (intel_phy_is_combo(dev_priv, phy))
 			icl_get_combo_buf_trans(dev_priv, INTEL_OUTPUT_HDMI,
@@ -927,12 +926,14 @@ static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port por
 		return 0;
 	}
 
-	/* Choose a good default if VBT is badly populated */
-	if (level == HDMI_LEVEL_SHIFT_UNKNOWN || level >= n_entries)
-		level = default_entry;
-
 	if (WARN_ON_ONCE(n_entries == 0))
 		return 0;
+
+	if (port_info->hdmi_level_shift_set)
+		level = port_info->hdmi_level_shift;
+	else
+		level = default_entry;
+
 	if (WARN_ON_ONCE(level >= n_entries))
 		level = n_entries - 1;
 
drivers/gpu/drm/i915/i915_drv.h +2 -6
index 7e0f67babe20..67bdfe6de3fa 100644
@@ -627,13 +627,9 @@ struct ddi_vbt_port_info {
 
 	int max_tmds_clock;
 
-	/*
-	 * This is an index in the HDMI/DVI DDI buffer translation table.
-	 * The special value HDMI_LEVEL_SHIFT_UNKNOWN means the VBT didn't
-	 * populate this field.
-	 */
-#define HDMI_LEVEL_SHIFT_UNKNOWN	0xff
+	/* This is an index in the HDMI/DVI DDI buffer translation table. */
 	u8 hdmi_level_shift;
+	u8 hdmi_level_shift_set:1;
 
 	u8 supports_dvi:1;
 	u8 supports_hdmi:1;
Signature · 1 line
2.20.1
Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

✓ Fi.CI.BAT: success for drm/i915/bios: use a flag for vbt hdmi level shift presence (rev2)

In reply to Jani Nikula
== Series Details ==

== Series Details ==

Series: drm/i915/bios: use a flag for vbt hdmi level shift presence (rev2)
URL : https://patchwork.freedesktop.org/series/68998/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7282 -> Patchwork_15171
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/index.html

Known issues
------------

Here are the changes found in Patchwork_15171 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live_gem_contexts:
- fi-bsw-n3050: [PASS][1] -> [INCOMPLETE][2] ([fdo# 111542])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html

* igt@i915_selftest@live_hangcheck:
- fi-icl-y: [PASS][3] -> [INCOMPLETE][4] ([fdo#107713] / [fdo#108569])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/fi-icl-y/igt@i915_selftest@live_hangcheck.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/fi-icl-y/igt@i915_selftest@live_hangcheck.html

#### Possible fixes ####

* igt@i915_selftest@live_gem_contexts:
- fi-bsw-kefka: [INCOMPLETE][5] ([fdo# 111542]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html

[fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569

Participating hosts (49 -> 45)
------------------------------

Additional (2): fi-tgl-u fi-cfl-guc
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_7282 -> Patchwork_15171

CI-20190529: 20190529
CI_DRM_7282: de0aae8761dadbe7b5fb02cafe92aa7be099d95e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5265: 99f04b14e224998abbb4ca60340fd97c9c5f33e8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15171: a25ec1245235f8cd7254dead9780e86a0fdd46e7 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

a25ec1245235 drm/i915/bios: use a flag for vbt hdmi level shift presence

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

✗ Fi.CI.IGT: failure for drm/i915/bios: use a flag for vbt hdmi level shift presence (rev2)

In reply to Jani Nikula
== Series Details ==

== Series Details ==

Series: drm/i915/bios: use a flag for vbt hdmi level shift presence (rev2)
URL : https://patchwork.freedesktop.org/series/68998/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7282_full -> Patchwork_15171_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_15171_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_15171_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_15171_full:

### Piglit changes ###

#### Possible regressions ####

* spec@!opengl 1.1@max-texture-size:
- pig-snb-2600: NOTRUN -> [INCOMPLETE][1]
[1]: None

Known issues
------------

Here are the changes found in Patchwork_15171_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_persistence@vcs1-mixed:
- shard-iclb: [PASS][2] -> [SKIP][3] ([fdo#109276] / [fdo#112080]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb2/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb5/igt@[email protected]

* igt@gem_exec_reuse@single:
- shard-hsw: [PASS][4] -> [INCOMPLETE][5] ([fdo#103540])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-hsw4/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-hsw5/igt@[email protected]

* igt@gem_exec_schedule@preempt-contexts-bsd2:
- shard-iclb: [PASS][6] -> [SKIP][7] ([fdo#109276]) +6 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb1/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb6/igt@[email protected]

* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [PASS][8] -> [SKIP][9] ([fdo#112146]) +4 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb7/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb4/igt@[email protected]

* igt@gem_exec_suspend@basic-s0:
- shard-tglb: [PASS][10] -> [INCOMPLETE][11] ([fdo#111832]) +2 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb7/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb3/igt@[email protected]

* igt@gem_softpin@noreloc-s3:
- shard-skl: [PASS][12] -> [INCOMPLETE][13] ([fdo#104108])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-skl9/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-skl4/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-snb: [PASS][14] -> [DMESG-WARN][15] ([fdo#111870]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-snb1/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-snb5/igt@[email protected]

* igt@i915_pm_rpm@system-suspend:
- shard-tglb: [PASS][16] -> [INCOMPLETE][17] ([fdo#111747] / [fdo#111850])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb9/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb5/igt@[email protected]

* igt@kms_color@pipe-b-ctm-0-75:
- shard-skl: [PASS][18] -> [DMESG-WARN][19] ([fdo#106107])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-skl4/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-skl2/igt@[email protected]

* igt@kms_color@pipe-b-legacy-gamma:
- shard-skl: [PASS][20] -> [FAIL][21] ([fdo#104782])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-skl3/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-skl5/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][22] -> [DMESG-WARN][23] ([fdo#108566]) +7 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-kbl6/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-kbl2/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [PASS][24] -> [FAIL][25] ([fdo#105363])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-skl7/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-skl1/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [PASS][26] -> [DMESG-WARN][27] ([fdo#108566]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-apl3/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-apl1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [PASS][28] -> [FAIL][29] ([fdo#103167]) +8 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-onoff:
- shard-tglb: [PASS][30] -> [FAIL][31] ([fdo#103167]) +3 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb8/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb6/igt@[email protected]

* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][32] -> [SKIP][33] ([fdo#109642] / [fdo#111068])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb2/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb5/igt@[email protected]

* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [PASS][34] -> [SKIP][35] ([fdo#109441])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb1/igt@kms_psr@psr2_sprite_blt.html

* igt@kms_psr@suspend:
- shard-tglb: [PASS][36] -> [INCOMPLETE][37] ([fdo#111832] / [fdo#111850])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb1/igt@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb2/igt@[email protected]

* igt@kms_setmode@basic:
- shard-hsw: [PASS][38] -> [FAIL][39] ([fdo#99912])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-hsw1/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-hsw1/igt@[email protected]

* igt@perf_pmu@busy-start-vcs1:
- shard-iclb: [PASS][40] -> [SKIP][41] ([fdo#112080]) +2 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb1/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb3/igt@[email protected]

#### Possible fixes ####

* igt@gem_busy@extended-parallel-vcs1:
- shard-iclb: [SKIP][42] ([fdo#112080]) -> [PASS][43] +7 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb5/igt@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb2/igt@[email protected]

* igt@gem_ctx_isolation@vcs1-s3:
- shard-tglb: [INCOMPLETE][44] ([fdo#111832]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb7/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb7/igt@[email protected]

* igt@gem_ctx_persistence@vcs1-mixed-process:
- shard-iclb: [SKIP][46] ([fdo#109276] / [fdo#112080]) -> [PASS][47] +1 similar issue
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb7/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb4/igt@[email protected]

* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][48] ([fdo#110841]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb1/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb6/igt@[email protected]

* igt@gem_exec_create@basic:
- shard-tglb: [INCOMPLETE][50] ([fdo#111736]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb6/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb4/igt@[email protected]

* igt@gem_exec_schedule@preempt-queue-contexts-bsd2:
- shard-iclb: [SKIP][52] ([fdo#109276]) -> [PASS][53] +7 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb6/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb2/igt@[email protected]

* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [SKIP][54] ([fdo#112146]) -> [PASS][55] +3 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb1/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb3/igt@[email protected]

* igt@gem_mmap_gtt@cpuset-medium-copy-odd:
- shard-kbl: [FAIL][56] -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-kbl6/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-kbl6/igt@[email protected]

* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-iclb: [TIMEOUT][58] ([fdo#112068 ]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb5/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb8/igt@[email protected]

* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-tglb: [FAIL][60] ([fdo#112037]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb6/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb7/igt@[email protected]
- shard-kbl: [FAIL][62] ([fdo#112037]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-kbl4/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-kbl1/igt@[email protected]

* igt@gem_sync@basic-all:
- shard-tglb: [INCOMPLETE][64] ([fdo#111647]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb6/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb7/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-snb: [DMESG-WARN][66] ([fdo#111870]) -> [PASS][67] +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-snb1/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-snb7/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-hsw: [DMESG-WARN][68] ([fdo#110789] / [fdo#111870]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-hsw6/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-hsw4/igt@[email protected]

* igt@gem_wait@busy-vcs0:
- shard-skl: [DMESG-WARN][70] -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-skl10/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-skl2/igt@[email protected]

* igt@gem_workarounds@suspend-resume:
- shard-tglb: [INCOMPLETE][72] ([fdo#111832] / [fdo#111850]) -> [PASS][73] +2 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb1/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb6/igt@[email protected]

* igt@kms_color@pipe-a-ctm-green-to-red:
- shard-skl: [DMESG-WARN][74] ([fdo#106107]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-skl3/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-skl6/igt@[email protected]

* igt@kms_cursor_legacy@cursor-vs-flip-legacy:
- shard-hsw: [FAIL][76] ([fdo#103355]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-hsw1/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-hsw1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][78] ([fdo#103167]) -> [PASS][79] +2 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

* igt@kms_frontbuffer_tracking@fbcpsr-suspend:
- shard-tglb: [INCOMPLETE][80] ([fdo#111832] / [fdo#111850] / [fdo#111884]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb4/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb9/igt@[email protected]

* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][82] ([fdo#109642] / [fdo#111068]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb1/igt@kms_psr2_su@page_flip.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb2/igt@kms_psr2_su@page_flip.html

* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][84] ([fdo#109441]) -> [PASS][85] +2 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb5/igt@kms_psr@psr2_cursor_render.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb2/igt@kms_psr@psr2_cursor_render.html

* igt@kms_setmode@basic:
- shard-kbl: [FAIL][86] ([fdo#99912]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-kbl6/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-kbl2/igt@[email protected]

* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][88] ([fdo#108566]) -> [PASS][89] +2 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-kbl4/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-kbl1/igt@[email protected]

* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-tglb: [INCOMPLETE][90] ([fdo#111850]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb8/igt@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb6/igt@[email protected]

#### Warnings ####

* igt@gem_ctx_isolation@vcs2-s3:
- shard-tglb: [SKIP][92] ([fdo#111912] / [fdo#112080]) -> [SKIP][93] ([fdo#112080])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb4/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb9/igt@[email protected]

* igt@kms_atomic_transition@6x-modeset-transitions:
- shard-tglb: [SKIP][94] ([fdo#112016 ] / [fdo#112021 ]) -> [SKIP][95] ([fdo#112021 ])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb8/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb9/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-tglb: [INCOMPLETE][96] ([fdo#111832] / [fdo#111850]) -> [FAIL][97] ([fdo#111703]) +1 similar issue
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb1/igt@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb2/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-tglb: [FAIL][98] ([fdo#111703]) -> [INCOMPLETE][99] ([fdo#111832] / [fdo#111850])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb9/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb3/igt@[email protected]

[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111647]: https://bugs.freedesktop.org/show_bug.cgi?id=111647
[fdo#111703]: https://bugs.freedesktop.org/show_bug.cgi?id=111703
[fdo#111736]: https://bugs.f

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

✗ Fi.CI.BAT: failure for drm/i915/bios: use a flag for vbt hdmi level shift presence (rev3)

In reply to Jani Nikula
== Series Details ==

== Series Details ==

Series: drm/i915/bios: use a flag for vbt hdmi level shift presence (rev3)
URL : https://patchwork.freedesktop.org/series/68998/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7314 -> Patchwork_15232
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_15232 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_15232, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_15232:

### IGT changes ###

#### Possible regressions ####

* igt@i915_pm_rpm@module-reload:
- fi-skl-lmem: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7314/fi-skl-lmem/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/fi-skl-lmem/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_15232 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live_gem_contexts:
- fi-bsw-nick: [PASS][3] -> [INCOMPLETE][4] ([fdo# 111542])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7314/fi-bsw-nick/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/fi-bsw-nick/igt@i915_selftest@live_gem_contexts.html

* igt@kms_busy@basic-flip-pipe-b:
- fi-skl-6770hq: [PASS][5] -> [DMESG-WARN][6] ([fdo#105541])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7314/fi-skl-6770hq/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/fi-skl-6770hq/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][7] -> [FAIL][8] ([fdo#111407])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7314/fi-kbl-7500u/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/fi-kbl-7500u/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live_gem_contexts:
- fi-bsw-kefka: [INCOMPLETE][9] ([fdo# 111542]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7314/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html

* igt@kms_flip@basic-flip-vs-wf_vblank:
- fi-bsw-n3050: [FAIL][11] ([fdo#100368]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7314/fi-bsw-n3050/igt@kms_flip@basic-flip-vs-wf_vblank.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/fi-bsw-n3050/igt@kms_flip@basic-flip-vs-wf_vblank.html

* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [DMESG-WARN][13] ([fdo#102614]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7314/fi-hsw-peppy/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/fi-hsw-peppy/igt@[email protected]

[fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542 [fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407

Participating hosts (49 -> 45)
------------------------------

Missing (4): fi-byt-clapper fi-byt-squawks fi-bsw-cyan fi-hsw-4200u

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_7314 -> Patchwork_15232

CI-20190529: 20190529
CI_DRM_7314: 443bcbddaac9f2667bc1cecd29086d739a42c6f9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5272: 5997df31db10f190fe8b70d920b6a6b8d3b24126 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15232: 460c9296c42da16ed7ef3a51d826214a0f75eb7f @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

460c9296c42d drm/i915/bios: use a flag for vbt hdmi level shift presence

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

✗ Fi.CI.BAT: failure for drm/i915/bios: use a flag for vbt hdmi level shift presence (rev4)

In reply to Jani Nikula
== Series Details ==

== Series Details ==

Series: drm/i915/bios: use a flag for vbt hdmi level shift presence (rev4)
URL : https://patchwork.freedesktop.org/series/68998/
State : failure

== Summary ==

Applying: drm/i915/bios: use a flag for vbt hdmi level shift presence Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/display/intel_bios.c
M drivers/gpu/drm/i915/display/intel_ddi.c
M drivers/gpu/drm/i915/i915_drv.h
Falling back to patching base and 3-way merge... Auto-merging drivers/gpu/drm/i915/i915_drv.h
Auto-merging drivers/gpu/drm/i915/display/intel_ddi.c Auto-merging drivers/gpu/drm/i915/display/intel_bios.c
No changes -- Patch already applied.

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx