Skip to contentSkip to conversation

modetest: Add support for setting mode having floating vertical refresh rate

PATCH Superseded Devarsh Thakkar 3 participants 3 messages Nov 6, 2019 – Nov 11, 2019

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 modetest: Add support for setting mode having floating vertical refresh rate

For the scenario where user may require to modeset with a mode supporting a fractional value for vertical refresh-rate, appropriate mode can be selected by searching for mode having matching fractional vertical refresh rate using below equation.

vrefresh = (1000 * pixel clock) / (htotal * vtotal) Hz.

We do this way since driver doesn't return float value of vrefresh as it use int for vrefresh in struct drm_mode_info, but we can derive the actual value using pixel clock, horizontal total size and vertical total size values.

So for e.g. if user want to select mode having 59.94 Hz as refresh rate then with this patch it be can done as shown in below command, given there is an appropriate mode is available :

modetest -M xlnx -s 39:1920x1080-59.94@BG24 -v

NOTE: Above command was tested on xilinx DRM driver with DP monitor which was supporting mode having 59.94 Hz refresh rate.

---
V2: Update commit message

---
 tests/modetest/modetest.c | 32 ++++++++++++++++++++++++--------
 1 file changed, 24 insertions(+), 8 deletions(-)
tests/modetest/modetest.c +24 -8
index e66be66..9b3e410 100644
@@ -795,7 +795,7 @@ struct pipe_arg {
        uint32_t crtc_id;
        char mode_str[64];
        char format_str[5];
-       unsigned int vrefresh;
+       float vrefresh;
        unsigned int fourcc;
        drmModeModeInfo *mode;
        struct crtc *crtc;
@@ -822,11 +822,12 @@ struct plane_arg {
 
 static drmModeModeInfo *
 connector_find_mode(struct device *dev, uint32_t con_id, const char *mode_str,
-        const unsigned int vrefresh)
+       const float vrefresh)
 {
        drmModeConnector *connector;
        drmModeModeInfo *mode;
        int i;
+       float mode_vrefresh;
 
        connector = get_connector_by_id(dev, con_id);
        if (!connector || !connector->count_modes)
@@ -839,9 +840,19 @@ connector_find_mode(struct device *dev, uint32_t con_id, const char *mode_str,
                         * first mode that match with the name. Else, return the mode that match
                         * the name and the specified vertical refresh frequency.
                         */
+                       float temp;
+
+                       mode_vrefresh = ((float)(mode->clock) * 1000.00)
+                                        / ((float)(mode->htotal)
+                                        * (float)mode->vtotal);
+                       /* Round off to 2 decimal places to match with user
+                        * provided value
+                        */
+                       temp = (int) (mode_vrefresh * 100 + 0.5);
+                       mode_vrefresh = (float) temp / 100;
                        if (vrefresh == 0)
                                return mode;
-                       else if (mode->vrefresh == vrefresh)
+                       else if (mode_vrefresh == vrefresh)
                                return mode;
                }
        }
@@ -1393,8 +1404,8 @@ static void atomic_set_mode(struct device *dev, struct pipe_arg *pipes, unsigned
                if (pipe->mode == NULL)
                        continue;
 
-               printf("setting mode %s-%dHz on connectors ",
-                      pipe->mode_str, pipe->mode->vrefresh);
+               printf("setting mode %s-%.2fHz on connectors ",
+                      pipe->mode_str, pipe->vrefresh);
                for (j = 0; j < pipe->num_cons; ++j) {
                        printf("%s, ", pipe->cons[j]);
                        add_property(dev, pipe->con_ids[j], "CRTC_ID", pipe->crtc->crtc->crtc_id);
@@ -1476,8 +1487,8 @@ static void set_mode(struct device *dev, struct pipe_arg *pipes, unsigned int co
                if (pipe->mode == NULL)
                        continue;
 
-               printf("setting mode %s-%dHz@%s on connectors ",
-                      pipe->mode_str, pipe->mode->vrefresh, pipe->format_str);
+               printf("setting mode %s-%.2fHz@%s on connectors ",
+                      pipe->mode_str, pipe->vrefresh, pipe->format_str);
                for (j = 0; j < pipe->num_cons; ++j)
                        printf("%s, ", pipe->cons[j]);
                printf("crtc %d\n", pipe->crtc->crtc->crtc_id);
@@ -1713,8 +1724,13 @@ static int parse_connector(struct pipe_arg *pipe, const char *arg)
        pipe->mode_str[len] = '\0';
 
        if (*p == '-') {
-               pipe->vrefresh = strtoul(p + 1, &endp, 10);
+               float temp;
+
+               pipe->vrefresh = strtof(p + 1, &endp);
                p = endp;
+               /* Round off to 2 decimal places */
+               temp = (int) (pipe->vrefresh * 100 + 0.5);
+               pipe->vrefresh = (float) temp / 100;
        }
 
        if (*p == '@') {

--
2.7.4

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#1 lore raw
Quoted 57 lines · Devarsh Thakkar

For the scenario where user may require to modeset with a mode supporting a fractional value for vertical refresh-rate, appropriate mode can be selected by searching for mode having matching fractional vertical refresh rate using below equation.

vrefresh = (1000 * pixel clock) / (htotal * vtotal) Hz.

We do this way since driver doesn't return float value of vrefresh as it use int for vrefresh in struct drm_mode_info, but we can derive the actual value using pixel clock, horizontal total size and vertical total size values.

So for e.g. if user want to select mode having 59.94 Hz as refresh rate then with this patch it be can done as shown in below command, given there is an appropriate mode is available :

modetest -M xlnx -s 39:1920x1080-59.94@BG24 -v

NOTE: Above command was tested on xilinx DRM driver with DP monitor which was supporting mode having 59.94 Hz refresh rate.

---
V2: Update commit message

---
 tests/modetest/modetest.c | 32 ++++++++++++++++++++++++--------
 1 file changed, 24 insertions(+), 8 deletions(-)
tests/modetest/modetest.c +3 -2
index e66be66..9b3e410 100644
@@ -795,7 +795,7 @@ struct pipe_arg {
        uint32_t crtc_id;
        char mode_str[64];
        char format_str[5];
-       unsigned int vrefresh;
+       float vrefresh;
        unsigned int fourcc;
        drmModeModeInfo *mode;
        struct crtc *crtc;
@@ -822,11 +822,12 @@ struct plane_arg {
 
 static drmModeModeInfo *
 connector_find_mode(struct device *dev, uint32_t con_id, const char *mode_str,
-        const unsigned int vrefresh)
+       const float vrefresh)
 {
        drmModeConnector *connector;
        drmModeModeInfo *mode;
        int i;
+       float mode_vrefresh;
 
        connector = get_connector_by_id(dev, con_id);
        if (!connector || !connector->count_modes)

tests/modetest/modetest.c connector_find_mode(struct device *dev, uint32_t con_id, const char *mode_str, · line 847

Quoted 8 lines
tests/modetest/modetest.c +5 -0
@@ -839,9 +840,19 @@ connector_find_mode(struct device *dev, uint32_t con_id, const char *mode_str,
                         * first mode that match with the name. Else, return the mode that match
                         * the name and the specified vertical refresh frequency.
                         */
+                       float temp;
+
+                       mode_vrefresh = ((float)(mode->clock) * 1000.00)
+                                        / ((float)(mode->htotal)
+                                        * (float)mode->vtotal);

1000.00 is a double, ditto for all the 0.5 etc. later.

All the casts are pointless here. Lost of unnecessary parens too.

tests/modetest/modetest.c connector_find_mode(struct device *dev, uint32_t con_id, const char *mode_str, · line 852

Quoted 5 lines
tests/modetest/modetest.c +5 -0
+                       /* Round off to 2 decimal places to match with user
+                        * provided value
+                        */
+                       temp = (int) (mode_vrefresh * 100 + 0.5);
+                       mode_vrefresh = (float) temp / 100;

This *100/100 business feels a bit convoluted. How about just leave the floats alone and replace the == with a some epsilon check?

Or if you want to do this rounding stuff I would at least put it into some function so it doesn't hurt one's eyes all the time. The timings->vrefresh calculation could also be a neat function.

Quoted 52 lines
tests/modetest/modetest.c +11 -7
                        if (vrefresh == 0)
                                return mode;
-                       else if (mode->vrefresh == vrefresh)
+                       else if (mode_vrefresh == vrefresh)
                                return mode;
                }
        }
@@ -1393,8 +1404,8 @@ static void atomic_set_mode(struct device *dev, struct pipe_arg *pipes, unsigned
                if (pipe->mode == NULL)
                        continue;
 
-               printf("setting mode %s-%dHz on connectors ",
-                      pipe->mode_str, pipe->mode->vrefresh);
+               printf("setting mode %s-%.2fHz on connectors ",
+                      pipe->mode_str, pipe->vrefresh);
                for (j = 0; j < pipe->num_cons; ++j) {
                        printf("%s, ", pipe->cons[j]);
                        add_property(dev, pipe->con_ids[j], "CRTC_ID", pipe->crtc->crtc->crtc_id);
@@ -1476,8 +1487,8 @@ static void set_mode(struct device *dev, struct pipe_arg *pipes, unsigned int co
                if (pipe->mode == NULL)
                        continue;
 
-               printf("setting mode %s-%dHz@%s on connectors ",
-                      pipe->mode_str, pipe->mode->vrefresh, pipe->format_str);
+               printf("setting mode %s-%.2fHz@%s on connectors ",
+                      pipe->mode_str, pipe->vrefresh, pipe->format_str);
                for (j = 0; j < pipe->num_cons; ++j)
                        printf("%s, ", pipe->cons[j]);
                printf("crtc %d\n", pipe->crtc->crtc->crtc_id);
@@ -1713,8 +1724,13 @@ static int parse_connector(struct pipe_arg *pipe, const char *arg)
        pipe->mode_str[len] = '\0';
 
        if (*p == '-') {
-               pipe->vrefresh = strtoul(p + 1, &endp, 10);
+               float temp;
+
+               pipe->vrefresh = strtof(p + 1, &endp);
                p = endp;
+               /* Round off to 2 decimal places */
+               temp = (int) (pipe->vrefresh * 100 + 0.5);
+               pipe->vrefresh = (float) temp / 100;
        }
 
        if (*p == '@') {
--

2.7.4

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#2 lore raw

Hi Ville,

Thanks for the review. I have sent v3 patch addressing the review comments. Could you please review and let me know if any further changes required ?

Regards,
Devarsh

Quoted 155 lines

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: 07 November 2019 03:13
To: Devarsh Thakkar <[email protected]>
Cc: [email protected]; Ranganathan Sk <[email protected]>; vcu- team <[email protected]>; Dhaval Rajeshbhai Shah <[email protected]>; Varunkumar Allagadapa <[email protected]>; Satish Kumar Nagireddy <[email protected]>
Subject: Re: [PATCH libdrm v2] modetest: Add support for setting mode having floating vertical refresh rate

EXTERNAL EMAIL

Quoted 42 lines · Devarsh Thakkar

For the scenario where user may require to modeset with a mode supporting a fractional value for vertical refresh-rate, appropriate mode can be selected by searching for mode having matching fractional vertical refresh rate using below equation.

vrefresh = (1000 * pixel clock) / (htotal * vtotal) Hz.

We do this way since driver doesn't return float value of vrefresh as it use int for vrefresh in struct drm_mode_info, but we can derive the actual value using pixel clock, horizontal total size and vertical total size values.

So for e.g. if user want to select mode having 59.94 Hz as refresh rate then with this patch it be can done as shown in below command, given there is an appropriate mode is available :

modetest -M xlnx -s 39:1920x1080-59.94@BG24 -v

NOTE: Above command was tested on xilinx DRM driver with DP monitor which was supporting mode having 59.94 Hz refresh rate.

---
V2: Update commit message

---
 tests/modetest/modetest.c | 32 ++++++++++++++++++++++++--------
 1 file changed, 24 insertions(+), 8 deletions(-)
tests/modetest/modetest.c +1 -1
index e66be66..9b3e410 100644
@@ -795,7 +795,7 @@ struct pipe_arg {
        uint32_t crtc_id;
        char mode_str[64];
        char format_str[5];
-       unsigned int vrefresh;
+       float vrefresh;
        unsigned int fourcc;
        drmModeModeInfo *mode;
        struct crtc *crtc;

tests/modetest/modetest.c struct plane_arg { · line 824

Quoted 3 lines
tests/modetest/modetest.c +0 -0
@@ -822,11 +822,12 @@ struct plane_arg {
 
 static drmModeModeInfo *
 connector_find_mode(struct device *dev, uint32_t con_id, const char

*mode_str,

Quoted 11 lines
tests/modetest/modetest.c +2 -1
-        const unsigned int vrefresh)
+       const float vrefresh)
 {
        drmModeConnector *connector;
        drmModeModeInfo *mode;
        int i;
+       float mode_vrefresh;
 
        connector = get_connector_by_id(dev, con_id);
        if (!connector || !connector->count_modes) @@ -839,9 +840,19

@@ connector_find_mode(struct device *dev, uint32_t con_id, const char

*mode_str,

Quoted 1 line

* first mode that match with the name. Else, return the mode

that match

tests/modetest/modetest.c connector_find_mode(struct device *dev, uint32_t con_id, const char *mode_str, · line 847

Quoted 7 lines

* the name and the specified vertical refresh frequency. */

tests/modetest/modetest.c +5 -0
+                       float temp;
+
+                       mode_vrefresh = ((float)(mode->clock) * 1000.00)
+                                        / ((float)(mode->htotal)
+                                        * (float)mode->vtotal);

1000.00 is a double, ditto for all the 0.5 etc. later.

All the casts are pointless here. Lost of unnecessary parens too.

tests/modetest/modetest.c connector_find_mode(struct device *dev, uint32_t con_id, const char *mode_str, · line 852

Quoted 5 lines
tests/modetest/modetest.c +5 -0
+                       /* Round off to 2 decimal places to match with user
+                        * provided value
+                        */
+                       temp = (int) (mode_vrefresh * 100 + 0.5);
+                       mode_vrefresh = (float) temp / 100;

This *100/100 business feels a bit convoluted. How about just leave the floats alone and replace the == with a some epsilon check?

Or if you want to do this rounding stuff I would at least put it into some function so it doesn't hurt one's eyes all the time.
The timings->vrefresh calculation could also be a neat function.

tests/modetest/modetest.c static void atomic_set_mode(struct device *dev,

Quoted 8 lines
                        if (vrefresh == 0)
                                return mode;
tests/modetest/modetest.c +1 -1
-                       else if (mode->vrefresh == vrefresh)
+                       else if (mode_vrefresh == vrefresh)
                                return mode;
                }
        }
@@ -1393,8 +1404,8 @@ static void atomic_set_mode(struct device *dev,

struct pipe_arg *pipes, unsigned

Quoted 11 lines
tests/modetest/modetest.c +2 -2
                if (pipe->mode == NULL)
                        continue;
 
-               printf("setting mode %s-%dHz on connectors ",
-                      pipe->mode_str, pipe->mode->vrefresh);
+               printf("setting mode %s-%.2fHz on connectors ",
+                      pipe->mode_str, pipe->vrefresh);
                for (j = 0; j < pipe->num_cons; ++j) {
                        printf("%s, ", pipe->cons[j]);
                        add_property(dev, pipe->con_ids[j], "CRTC_ID",

pipe->crtc->crtc->crtc_id); @@ -1476,8 +1487,8 @@ static void

set_mode(struct device *dev, struct pipe_arg *pipes, unsigned int co

tests/modetest/modetest.c static void set_mode(struct device *dev, struct pipe_arg *pipes, unsigned int co

Quoted 12 lines
                if (pipe->mode == NULL)
                        continue;
tests/modetest/modetest.c +3 -3
-               printf("setting mode %s-%dHz@%s on connectors ",
-                      pipe->mode_str, pipe->mode->vrefresh, pipe->format_str);
+               printf("setting mode %s-%.2fHz@%s on connectors ",
+                      pipe->mode_str, pipe->vrefresh,
+ pipe->format_str);
                for (j = 0; j < pipe->num_cons; ++j)
                        printf("%s, ", pipe->cons[j]);
                printf("crtc %d\n", pipe->crtc->crtc->crtc_id); @@
-1713,8 +1724,13 @@ static int parse_connector(struct pipe_arg *pipe,

const char *arg)

Quoted 17 lines
        pipe->mode_str[len] = '\0';

        if (*p == '-') {
tests/modetest/modetest.c +6 -2
-               pipe->vrefresh = strtoul(p + 1, &endp, 10);
+               float temp;
+
+               pipe->vrefresh = strtof(p + 1, &endp);
                p = endp;
+               /* Round off to 2 decimal places */
+               temp = (int) (pipe->vrefresh * 100 + 0.5);
+               pipe->vrefresh = (float) temp / 100;
        }
 
        if (*p == '@') {
--

2.7.4

Quoted 1 line

This email and any attachments are intended for the sole use of the named

recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

Quoted 8 lines
Quoted 4 lines

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Ville Syrjälä
Intel

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel