Skip to contentSkip to conversation

nodejs: allow use of system nghttp2

PATCH Superseded André Draszik 1 participant 2 messages Nov 7, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nodejs: allow use of system nghttp2

We can't enable this by default, though, as nghttp2 is in the meta-networking layer, which might not be enabled.

At least this gives people a simple way to do so if they want.

---
Note that this commit depends on the nghttp2 updates being merged to meta-networking first.

---
 meta-oe/recipes-devtools/nodejs/nodejs_10.17.0.bb | 1 +
 1 file changed, 1 insertion(+)
meta-oe/recipes-devtools/nodejs/nodejs_10.17.0.bb +1 -0
index 4afe341f9..be3cbf04f 100644
@@ -54,6 +54,7 @@ ARCHFLAGS ?= ""
 PACKAGECONFIG ??= "ares icu libuv zlib"
 PACKAGECONFIG[ares] = "--shared-cares,,c-ares"
 PACKAGECONFIG[icu] = "--with-intl=system-icu,--without-intl,icu"
+PACKAGECONFIG[nghttp2] = "--shared-nghttp2,,nghttp2"
 PACKAGECONFIG[libuv] = "--shared-libuv,,libuv"
 PACKAGECONFIG[zlib] = "--shared-zlib,,zlib"
 
Signature · 1 line
2.23.0.rc1
#1 lore raw

PATCH v2 1/1 nodejs: allow use of system nghttp2

We can't enable this by default, though, as nghttp2 is in the meta-networking layer, which might not be enabled.

At least this gives people a simple way to do so if they want.

---
Note that this commit depends on the nghttp2 updates being merged to meta-networking first.

v2:
keep PACKAGECONFIG[] in alphabetical order...

---
 meta-oe/recipes-devtools/nodejs/nodejs_10.17.0.bb | 1 +
 1 file changed, 1 insertion(+)
meta-oe/recipes-devtools/nodejs/nodejs_10.17.0.bb +1 -0
index 4afe341f9..4013c6931 100644
@@ -55,6 +55,7 @@ PACKAGECONFIG ??= "ares icu libuv zlib"
 PACKAGECONFIG[ares] = "--shared-cares,,c-ares"
 PACKAGECONFIG[icu] = "--with-intl=system-icu,--without-intl,icu"
 PACKAGECONFIG[libuv] = "--shared-libuv,,libuv"
+PACKAGECONFIG[nghttp2] = "--shared-nghttp2,,nghttp2"
 PACKAGECONFIG[zlib] = "--shared-zlib,,zlib"
 
 # Node is way too cool to use proper autotools, so we install two wrappers to forcefully inject proper arch cflags to workaround gypi
Signature · 1 line
2.23.0.rc1