Skip to contentSkip to conversation

net/af_xdp: enforce an MTU of 1500

PATCH In review Ciara Loftus 2 participants 2 messages Nov 7, 2019 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/af_xdp: enforce an MTU of 1500

Packets larger than this will fail to be transmitted by AF_XDP, so limit the MTU to 1500.

---
 drivers/net/af_xdp/rte_eth_af_xdp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/af_xdp/rte_eth_af_xdp.c +3 -1
index 2b1245ee4..62c801500 100644
@@ -595,7 +595,7 @@ eth_dev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 	dev_info->max_tx_queues = internals->queue_cnt;
 
 	dev_info->min_mtu = RTE_ETHER_MIN_MTU;
-	dev_info->max_mtu = ETH_AF_XDP_FRAME_SIZE - ETH_AF_XDP_DATA_HEADROOM;
+	dev_info->max_mtu = 1500;
 
 	dev_info->default_rxportconf.nb_queues = 1;
 	dev_info->default_txportconf.nb_queues = 1;
@@ -1328,6 +1328,8 @@ rte_pmd_af_xdp_probe(struct rte_vdev_device *dev)
 		return -1;
 	}
 
+	eth_dev_mtu_set(eth_dev, 1500);
+
 	rte_eth_dev_probing_finish(eth_dev);
 
 	return 0;
Signature · 1 line
2.17.1
#1 lore raw
Quoted 13 lines · Ciara Loftus

Packets larger than this will fail to be transmitted by AF_XDP, so limit the MTU to 1500.

---
 drivers/net/af_xdp/rte_eth_af_xdp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/af_xdp/rte_eth_af_xdp.c +0 -0
index 2b1245ee4..62c801500 100644

drivers/net/af_xdp/rte_eth_af_xdp.c eth_dev_info(struct rte_eth_dev *dev, struct · line 600

Quoted 7 lines
drivers/net/af_xdp/rte_eth_af_xdp.c +1 -1
@@ -595,7 +595,7 @@ eth_dev_info(struct rte_eth_dev *dev, struct 
 rte_eth_dev_info *dev_info)
 	dev_info->max_tx_queues = internals->queue_cnt;
 
 	dev_info->min_mtu = RTE_ETHER_MIN_MTU;
-	dev_info->max_mtu = ETH_AF_XDP_FRAME_SIZE - 
 ETH_AF_XDP_DATA_HEADROOM;
+	dev_info->max_mtu = 1500;

Why is this limited to 1500 in the AF_XDP PMD? For native AF_XDP in OVS the limit is mainly by the driver/XDP page limit:
min(PAGE_SIZE, ETH_AF_XDP_FRAME_SIZE ) - ETH_XDP_DATA_HEADROOM -
XDP_PACKET_HEADROOM

Quoted 15 lines
drivers/net/af_xdp/rte_eth_af_xdp.c +0 -0
 	dev_info->default_rxportconf.nb_queues = 1;
drivers/net/af_xdp/rte_eth_af_xdp.c +2 -0
 	dev_info->default_txportconf.nb_queues = 1;
@@ -1328,6 +1328,8 @@ rte_pmd_af_xdp_probe(struct rte_vdev_device 
 *dev)
 		return -1;
 	}
 
+	eth_dev_mtu_set(eth_dev, 1500);
+
 	rte_eth_dev_probing_finish(eth_dev);
 

return 0;

Signature · 1 line
2.17.1