Skip to contentSkip to conversation

support/testing: add lxc test

PATCH New Patrick Havelange 3 participants 3 messages Nov 7, 2019 – Nov 17, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 support/testing: add lxc test

The test starts a simple container with an iperf3 server. The container is using the tini init system, with a shared rootfs. An iperf3 client is started from the host to check that the container is really up and running.

---
 .gitlab-ci.yml                                |  1 +
 support/testing/tests/package/test_lxc.py     | 58 +++++++++++++++++++
 .../tests/package/test_lxc/kernel_config_frag | 20 +++++++
 .../test_lxc_rootfs_overlay/usr/bin/iperf3.sh |  2 +
 .../usr/share/lxc/config/minimal-iperf3.conf  |  4 ++
 .../usr/share/lxc/config/minimal.conf         |  6 ++
 6 files changed, 91 insertions(+)
 create mode 100644 support/testing/tests/package/test_lxc.py
 create mode 100644 support/testing/tests/package/test_lxc/kernel_config_frag
 create mode 100755 support/testing/tests/package/test_lxc/test_lxc_rootfs_overlay/usr/bin/iperf3.sh
 create mode 100644 support/testing/tests/package/test_lxc/test_lxc_rootfs_overlay/usr/share/lxc/config/minimal-iperf3.conf
 create mode 100644 support/testing/tests/package/test_lxc/test_lxc_rootfs_overlay/usr/share/lxc/config/minimal.conf
.gitlab-ci.yml +1 -0
index 1d71257a20..9ef93130a1 100644
@@ -410,6 +410,7 @@ tests.package.test_luasocket.TestLuajitLuaSocket: { extends: .runtime_test }
 tests.package.test_luasyslog.TestLuaLuasyslog: { extends: .runtime_test }
 tests.package.test_luasyslog.TestLuajitLuasyslog: { extends: .runtime_test }
 tests.package.test_luvi.TestLuvi: { extends: .runtime_test }
+tests.package.test_lxc.TestLxc: { extends: .runtime_test }
 tests.package.test_lzlib.TestLuaLzlib: { extends: .runtime_test }
 tests.package.test_openjdk.TestOpenJdk: { extends: .runtime_test }
 tests.package.test_perl.TestPerl: { extends: .runtime_test }
support/testing/tests/package/test_lxc.py new file +58 -0

58 lines not on this page · raw message

support/testing/tests/package/test_lxc/kernel_config_frag new file +20 -0
new file mode 100644
index 0000000000..32f8bdd65e
@@ -0,0 +1,20 @@
+CONFIG_FIX_EARLYCON_MEM=y
+CONFIG_BLK_CGROUP=y
+CONFIG_CGROUP_SCHED=y
+CONFIG_CGROUP_PIDS=y
+CONFIG_CGROUP_FREEZER=y
+CONFIG_CGROUP_DEVICE=y
+CONFIG_CGROUP_CPUACCT=y
+CONFIG_CGROUP_DEBUG=y
+CONFIG_NETFILTER_XT_MATCH_CGROUP=y
+CONFIG_SOCK_CGROUP_DATA=y
+CONFIG_CGROUP_NET_PRIO=y
+CONFIG_CGROUP_NET_CLASSID=y
+CONFIG_NAMESPACES=y
+CONFIG_IPC_NS=y
+CONFIG_PID_NS=y
+CONFIG_UTS_NS=y
+CONFIG_USER_NS=y
+CONFIG_NET_NS=y
+CONFIG_BRIDGE=y
+CONFIG_VETH=y
support/testing/tests/package/test_lxc/test_lxc_rootfs_overlay/usr/bin/iperf3.sh new file +2 -0
new file mode 100755
index 0000000000..7045ca4806
@@ -0,0 +1,2 @@
+#!/bin/sh
+iperf3 -s -1 > /tmp/iperf3.serv.log 2>&1
support/testing/tests/package/test_lxc/test_lxc_rootfs_overlay/usr/share/lxc/config/minimal-iperf3.conf new file +4 -0
new file mode 100644
index 0000000000..41cc5311d6
@@ -0,0 +1,4 @@
+lxc.include = /usr/share/lxc/config/minimal.conf
+lxc.hook.version = 1
+lxc.hook.start-host = ip a add 192.168.1.1/24 dev lxc0
+lxc.init.cmd = tini -g iperf3.sh
support/testing/tests/package/test_lxc/test_lxc_rootfs_overlay/usr/share/lxc/config/minimal.conf new file +6 -0
new file mode 100644
index 0000000000..7319821506
@@ -0,0 +1,6 @@
+lxc.autodev = 0
+lxc.net.0.type = veth
+lxc.net.0.veth.pair = lxc0
+lxc.net.0.name = eth0
+lxc.net.0.flags = up
+lxc.net.0.ipv4.address = 192.168.1.2/24
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 support/testing: add lxc test

Hello Patrick,

Quoted 6 lines · On Thu, 7 Nov 2019 17:48:04 +0100 Patrick Havelange…

The test starts a simple container with an iperf3 server. The container is using the tini init system, with a shared rootfs. An iperf3 client is started from the host to check that the container is really up and running.

Thanks for your contribution. I don't have a lot of very definitive feedback, more some general thoughts.

First of all, what was the idea behind the use of iperf3 ? Is it just a mean to make sure that both the container and host can communicate, and that the container runs fine ?

Another question is about the shared rootfs situation: if I understand correctly, the container runs with the same rootfs as the host. Recently, Carlos Santos (in Cc), submitted a patch "package/test-vm: a virtual machine image to test libvirt", which builds a separate rootfs image to run as a VM using libvirt. Shouldn't we standardize a bit how the test cases will test things such as lxc/libvirt, and try to use more or less the same strategy/logic to build the image executed inside the container or VM ?

Note: this comment is really to open up the discussion on this topic. Perhaps we will decide that what you did is good enough, and can possibly be improved later.

support/testing/tests/package/test_lxc.py line 30

Quoted 2 lines
support/testing/tests/package/test_lxc.py new file +2 -0
+    def run_ok(self, cmd):
+        full_cmd = "sh -c '{}'".format(cmd)

Why is running through "sh -c" necessary ?

support/testing/tests/package/test_lxc.py line 32

Quoted 2 lines
support/testing/tests/package/test_lxc.py new file +2 -0
+        out, exit_code = self.emulator.run(full_cmd, 120)
+        self.assertEqual(exit_code, 0)

This seems like a useful helper method, perhaps we should have it in the emulator class, and make use of it in other tests ?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 support/testing: add lxc test

Quoted 10 lines · Thomas Petazzoni

Hello Patrick,

Quoted 5 lines · On Thu, 7 Nov 2019 17:48:04 +0100 Patrick Havelange…

The test starts a simple container with an iperf3 server. The container is using the tini init system, with a shared rootfs. An iperf3 client is started from the host to check that the container is really up and running.

Quoted 8 lines
Quoted 1 line

Thanks for your contribution. I don't have a lot of very definitive feedback, more some general thoughts.

First of all, what was the idea behind the use of iperf3 ? Is it just a mean to make sure that both the container and host can communicate, and that the container runs fine ?

Indeed. The container running is a bit limited for a test. Having network
access to it is a way to get a bit more confidence that it is really functional.

ssh would be another option to test the network access, but is more complicated.

nc also sounds like an obvious alternative, but that turns out to be
surprisingly difficult to set up correctly (in particular, reliably detecting failure and not just timing out).

That's why Patrick choose iperf, because it is really trivial.

Quoted 8 lines

Another question is about the shared rootfs situation: if I understand correctly, the container runs with the same rootfs as the host. Recently, Carlos Santos (in Cc), submitted a patch "package/test-vm: a virtual machine image to test libvirt", which builds a separate rootfs image to run as a VM using libvirt. Shouldn't we standardize a bit how the test cases will test things such as lxc/libvirt, and try to use more or less the same strategy/logic to build the image executed inside the container or VM ?

The idea would be to add several lxc tests, for the different use cases. One of
the use cases is a shared rootfs, another is a separate rootfs. test-vm could be used for the second case. Another useful case will be with systemd inside and outisde the container and being sure that they can talk to each other properly.

Quoted 8 lines

Note: this comment is really to open up the discussion on this topic. Perhaps we will decide that what you did is good enough, and can possibly be improved later.

support/testing/tests/package/test_lxc.py line 30

Quoted 2 lines
support/testing/tests/package/test_lxc.py new file +2 -0
+    def run_ok(self, cmd):
+        full_cmd = "sh -c '{}'".format(cmd)

Why is running through "sh -c" necessary ?

Good question. Probably a leftover from when some commands were using redirection?

Quoted 5 lines

support/testing/tests/package/test_lxc.py line 32

Quoted 2 lines
support/testing/tests/package/test_lxc.py new file +2 -0
+        out, exit_code = self.emulator.run(full_cmd, 120)
+        self.assertEqual(exit_code, 0)

This seems like a useful helper method, perhaps we should have it in the emulator class, and make use of it in other tests ?

Indeed, that could be useful.

But then it should probably be called assertRunOk, similar to assertEqual. And
that again requires a noqa marking :-(

Regards,
Arnout