Skip to contentSkip to conversation

platform/x86: pmc_atom: Add Siemens SIMATIC IPC227E to critclk_systems DMI table

PATCH In review Andy Shevchenko 4 participants 4 messages Nov 7, 2019 – Nov 8, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86: pmc_atom: Add Siemens SIMATIC IPC227E to critclk_systems DMI table

From: Jan Kiszka <[email protected]>

The SIMATIC IPC227E uses the PMC clock for on-board components and gets stuck during boot if the clock is disabled. Therefore, add this device to the critical systems list.

Fixes 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")

---

- resend for stable inclusion

 drivers/platform/x86/pmc_atom.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/platform/x86/pmc_atom.c +7 -0
index aa53648a2214..9aca5e7ce6d0 100644
@@ -415,6 +415,13 @@ static const struct dmi_system_id critclk_systems[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "CB6363"),
 		},
 	},
+	{
+		.ident = "SIMATIC IPC227E",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "SIEMENS AG"),
+			DMI_MATCH(DMI_PRODUCT_VERSION, "6ES7647-8B"),
+		},
+	},
 	{ /*sentinel*/ }
 };
 
Signature · 1 line
2.24.0
#1 lore raw

Hi,

2019年11月8日(金) 2:05 Andy Shevchenko <[email protected]>:

Quoted 6 lines

From: Jan Kiszka <[email protected]>

The SIMATIC IPC227E uses the PMC clock for on-board components and gets stuck during boot if the clock is disabled. Therefore, add this device to the critical systems list.

You forgot to add original commit ID.

Best regards,
Nobuhiro

Quoted 31 lines
Fixes 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")

---

- resend for stable inclusion

 drivers/platform/x86/pmc_atom.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/platform/x86/pmc_atom.c +7 -1
index aa53648a2214..9aca5e7ce6d0 100644
@@ -415,6 +415,13 @@ static const struct dmi_system_id critclk_systems[] = {
                        DMI_MATCH(DMI_BOARD_NAME, "CB6363"),
                },
        },
+       {
+               .ident = "SIMATIC IPC227E",
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "SIEMENS AG"),
+                       DMI_MATCH(DMI_PRODUCT_VERSION, "6ES7647-8B"),
+               },
+       },
        { /*sentinel*/ }
 };
 
--
Quoted 2 lines

2.24.0

--
Nobuhiro Iwamatsu
iwamatsu at {nigauri.org / debian.org}
GPG ID: 40AD1FA6

#2 lore raw
In reply to Andy Shevchenko
Quoted 6 lines · Andy Shevchenko

From: Jan Kiszka <[email protected]>

The SIMATIC IPC227E uses the PMC clock for on-board components and gets stuck during boot if the clock is disabled. Therefore, add this device to the critical systems list.

Quoted 7 lines
Fixes 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")

---

- resend for stable inclusion

What git id is this in Linus's tree, and what tree(s) is this backport for?

thanks,

greg k-h

#3 lore raw
Quoted 13 lines · Greg Kroah-Hartman
Quoted 12 lines · Andy Shevchenko

From: Jan Kiszka <[email protected]>

The SIMATIC IPC227E uses the PMC clock for on-board components and gets stuck during boot if the clock is disabled. Therefore, add this device to the critical systems list.

Fixes 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")

---

Quoted 4 lines
Quoted 1 line

- resend for stable inclusion

What git id is this in Linus's tree, and what tree(s) is this backport for?

Upstream ID ad0d315b4d4e7138f43acf03308192ec00e9614d.

We should target down to 4.14, the last stable kernel that got bothered by 648e921888ad as far as I can see.

Jan

Signature · 2 lines
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux