Skip to contentSkip to conversation

firmware: log names of loaded firmware

PATCH In review Robin H. Johnson 2 participants 2 messages Nov 7, 2019 – Nov 13, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firmware: log names of loaded firmware

It's non-trivial to figure out names of firmware that was actually loaded, add a print statement at the end of _request_firmware that logs the name & result of each firmware.

This is esp. valuable early in boot, before logging of UEVENT is available.

---
 drivers/base/firmware_loader/main.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/base/firmware_loader/main.c +2 -0
index bf44c79beae9..f0362af16b66 100644
@@ -791,6 +791,8 @@ _request_firmware(const struct firmware **firmware_p, const char *name,
 		fw = NULL;
 	}
 
+	dev_info(device, "%s %s ret=%d\n", __func__, name, ret);
+
 	*firmware_p = fw;
 	return ret;
 }
Signature · 1 line
2.24.0
maintainer
#1 lore raw
Quoted 17 lines · Robin H. Johnson

It's non-trivial to figure out names of firmware that was actually loaded, add a print statement at the end of _request_firmware that logs the name & result of each firmware.

This is esp. valuable early in boot, before logging of UEVENT is available.

---
 drivers/base/firmware_loader/main.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/base/firmware_loader/main.c +0 -0
index bf44c79beae9..f0362af16b66 100644

drivers/base/firmware_loader/main.c _request_firmware(const struct firmware **firmware_p, const char *name, · line 795

Quoted 5 lines
drivers/base/firmware_loader/main.c +2 -0
@@ -791,6 +791,8 @@ _request_firmware(const struct firmware **firmware_p, const char *name,
 		fw = NULL;
 	}
 
+	dev_info(device, "%s %s ret=%d\n", __func__, name, ret);
+

Thanks for your patch!

Sorry but we don't want to always print this. We however can *debug* a system with dev_dbg() but there is a patch which someone is working on which will do this. I cc'd you on it.

Luis