net: Demote MTU change prints to debug
cover net: Demote MTU change prints to debug
Hi David, Jeff, Timur,
This patch series demotes several drivers that printed MTU change and could therefore spam the kernel console if one has a test that it's all about testing the values. Intel drivers were not also particularly consistent in how they printed the same message, so now they are.
Thanks
Florian Fainelli (2):
net: ethernet: intel: Demote MTU change prints to debug
net: qcom/emac: Demote MTU change print to debug
drivers/net/ethernet/intel/e1000/e1000_main.c | 4 ++-- drivers/net/ethernet/intel/e1000e/netdev.c | 3 ++- drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++-- drivers/net/ethernet/intel/igb/igb_main.c | 5 ++--- drivers/net/ethernet/intel/igbvf/netdev.c | 4 ++-- drivers/net/ethernet/intel/igc/igc_main.c | 5 ++--- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 ++- drivers/net/ethernet/qualcomm/emac/emac.c | 6 +++--- 8 files changed, 17 insertions(+), 17 deletions(-)
Signature · 1 line
2.17.1
PATCH 1/2 net: ethernet: intel: Demote MTU change prints to debug
Changing a network device MTU can be a fairly frequent operation, and failure to change the MTU is reflected to user-space properly, both by an appropriate message as well as by looking at whether the device's MTU matches the configuration.
Demote the prints to debug prints by using netdev_dbg(), making all Intel wired LAN drivers consistent, since they used a mixture of PCI device and network device prints before.
--- drivers/net/ethernet/intel/e1000/e1000_main.c | 4 ++-- drivers/net/ethernet/intel/e1000e/netdev.c | 3 ++- drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++-- drivers/net/ethernet/intel/igb/igb_main.c | 5 ++--- drivers/net/ethernet/intel/igbvf/netdev.c | 4 ++-- drivers/net/ethernet/intel/igc/igc_main.c | 5 ++--- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 ++- 7 files changed, 14 insertions(+), 14 deletions(-)
drivers/net/ethernet/intel/e1000/e1000_main.c +2 -2
@@ -3565,8 +3565,8 @@ static int e1000_change_mtu(struct net_device *netdev, int new_mtu) (max_frame == MAXIMUM_ETHERNET_VLAN_SIZE))) adapter->rx_buffer_len = MAXIMUM_ETHERNET_VLAN_SIZE; -pr_info ("%s changing MTU from %d to %d\n" , - netdev->name, netdev->mtu, new_mtu); +netdev_dbg (netdev,"changing MTU from %d to %d\n" , + netdev->mtu, new_mtu); netdev->mtu = new_mtu;if (netif_running (netdev))
drivers/net/ethernet/intel/e1000e/netdev.c +2 -1
@@ -6031,7 +6031,8 @@ static int e1000_change_mtu(struct net_device *netdev, int new_mtu)usleep_range (1000 ,1100 );/* e1000e_down -> e1000e_reset dependent on max_frame_size & mtu */ adapter->max_frame_size = max_frame; -e_info ("changing MTU from %d to %d\n" , netdev->mtu, new_mtu); +netdev_dbg (netdev,"changing MTU from %d to %d\n" , + netdev->mtu, new_mtu); netdev->mtu = new_mtu;pm_runtime_get_sync (netdev->dev.parent);
drivers/net/ethernet/intel/i40e/i40e_main.c +2 -2
@@ -2664,8 +2664,8 @@ static int i40e_change_mtu(struct net_device *netdev, int new_mtu)return -EINVAL ; } -netdev_info (netdev,"changing MTU from %d to %d\n" , - netdev->mtu, new_mtu); +netdev_dbg (netdev,"changing MTU from %d to %d\n" , + netdev->mtu, new_mtu); netdev->mtu = new_mtu;if (netif_running (netdev))i40e_vsi_reinit_locked (vsi);
drivers/net/ethernet/intel/igb/igb_main.c +2 -3
@@ -6236,7 +6236,6 @@ static void igb_get_stats64(struct net_device *netdev,static int igb_change_mtu (struct net_device *netdev,int new_mtu) {struct igb_adapter *adapter =netdev_priv (netdev); -struct pci_dev *pdev = adapter->pdev;int max_frame = new_mtu +ETH_HLEN +ETH_FCS_LEN +VLAN_HLEN ;/* adjust max frame to be at least the size of a standard frame */
@@ -6252,8 +6251,8 @@ static int igb_change_mtu(struct net_device *netdev, int new_mtu)if (netif_running (netdev))igb_down (adapter); -dev_info (&pdev->dev,"changing MTU from %d to %d\n" , - netdev->mtu, new_mtu); +netdev_dbg (netdev,"changing MTU from %d to %d\n" , + netdev->mtu, new_mtu); netdev->mtu = new_mtu;if (netif_running (netdev))
drivers/net/ethernet/intel/igbvf/netdev.c +2 -2
@@ -2437,8 +2437,8 @@ static int igbvf_change_mtu(struct net_device *netdev, int new_mtu) adapter->rx_buffer_len =ETH_FRAME_LEN +VLAN_HLEN +ETH_FCS_LEN ; -dev_info (&adapter->pdev->dev,"changing MTU from %d to %d\n" , - netdev->mtu, new_mtu); +netdev_dbg (netdev,"changing MTU from %d to %d\n" , + netdev->mtu, new_mtu); netdev->mtu = new_mtu;if (netif_running (netdev))
drivers/net/ethernet/intel/igc/igc_main.c +2 -3
@@ -2272,7 +2272,6 @@ static int igc_change_mtu(struct net_device *netdev, int new_mtu) {int max_frame = new_mtu +ETH_HLEN +ETH_FCS_LEN +VLAN_HLEN ;struct igc_adapter *adapter =netdev_priv (netdev); -struct pci_dev *pdev = adapter->pdev;/* adjust max frame to be at least the size of a standard frame */ if (max_frame < (ETH_FRAME_LEN +ETH_FCS_LEN ))
@@ -2287,8 +2286,8 @@ static int igc_change_mtu(struct net_device *netdev, int new_mtu)if (netif_running (netdev))igc_down (adapter); -dev_info (&pdev->dev,"changing MTU from %d to %d\n" , - netdev->mtu, new_mtu); +netdev_dbg (netdev,"changing MTU from %d to %d\n" , + netdev->mtu, new_mtu); netdev->mtu = new_mtu;if (netif_running (netdev))
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +2 -1
@@ -6725,7 +6725,8 @@ static int ixgbe_change_mtu(struct net_device *netdev, int new_mtu) (new_mtu > ETH_DATA_LEN))e_warn (probe,"Setting MTU > 1500 will disable legacy VFs\n" ); -e_info (probe,"changing MTU from %d to %d\n" , netdev->mtu, new_mtu); +netdev_dbg (netdev,"changing MTU from %d to %d\n" , + netdev->mtu, new_mtu);/* must set new MTU before calling down or up */ netdev->mtu = new_mtu;
Signature · 1 line
2.17.1
Re: [PATCH net-next 1/2] net: ethernet: intel: Demote MTU change prints to debug
Quoted 10 lines · Florian Fainelli
Changing a network device MTU can be a fairly frequent operation, and failure to change the MTU is reflected to user-space properly, both by an appropriate message as well as by looking at whether the device's MTU matches the configuration.
Demote the prints to debug prints by using
netdev_dbg(), making all Intel wired LAN drivers consistent, since they used a mixture of PCI device and network device prints before.Signed-off-by Florian Fainelli <[email protected]>
Quoted 9 lines
--- drivers/net/ethernet/intel/e1000/e1000_main.c | 4 ++-- drivers/net/ethernet/intel/e1000e/netdev.c | 3 ++- drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++-- drivers/net/ethernet/intel/igb/igb_main.c | 5 ++--- drivers/net/ethernet/intel/igbvf/netdev.c | 4 ++-- drivers/net/ethernet/intel/igc/igc_main.c | 5 ++--- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 ++- 7 files changed, 14 insertions(+), 14 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20191107/ff1f8d3a/attachment.asc>
PATCH 2/2 net: qcom/emac: Demote MTU change print to debug
In reply to Florian FainelliChanging the MTU can be a frequent operation and it is already clear when (or not) a MTU change is successful, demote prints to debug prints.
--- drivers/net/ethernet/qualcomm/emac/emac.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/ethernet/qualcomm/emac/emac.c +3 -3
@@ -213,9 +213,9 @@ static int emac_change_mtu(struct net_device *netdev, int new_mtu) {struct emac_adapter *adpt =netdev_priv (netdev); -netif_info (adpt, hw, adpt->netdev, -"changing MTU from %d to %d\n" , netdev->mtu, - new_mtu); +netif_dbg (adpt, hw, adpt->netdev, +"changing MTU from %d to %d\n" , netdev->mtu, + new_mtu); netdev->mtu = new_mtu;if (netif_running (netdev))
Signature · 1 line
2.17.1
Re: [PATCH net-next 2/2] net: qcom/emac: Demote MTU change print to debug
Quoted 4 lines · Florian Fainelli
Changing the MTU can be a frequent operation and it is already clear when (or not) a MTU change is successful, demote prints to debug prints.
Signed-off-by Florian Fainelli<[email protected]>
David Miller
maintainerFrom: Florian Fainelli <[email protected]>
Date: Thu, 7 Nov 2019 14:35:35 -0800
Quoted 4 lines
This patch series demotes several drivers that printed MTU change and could therefore spam the kernel console if one has a test that it's all about testing the values. Intel drivers were not also particularly consistent in how they printed the same message, so now they are.
Series applied, thanks Florian.