Skip to contentSkip to conversation

drm/i915/perf: Configure OAR controls for specific context

PATCH In review Umesh Nerlige Ramappa 3 participants 7 messages Nov 7, 2019 – Nov 11, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/perf: Configure OAR controls for specific context

It turns out that the OAR CONTROL register is not getting configured correctly in conjunction with the context save/restore bit. When measuring work for a single context, the OAR counters do not increment.

- Configure OAR format and enable OAR counters at the same time as enabling context save/restore for OAR counters.
- Make SAMPLE_OA_REPORT optional from gen12.

v2: Update commit message

---
 drivers/gpu/drm/i915/i915_perf.c | 23 +++++++++++++++--------
 1 file changed, 15 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/i915_perf.c +15 -8
index 2c380aba1ce9..527a16637689 100644
@@ -2219,26 +2219,33 @@ static int gen8_configure_context(struct i915_gem_context *ctx,
 	return err;
 }
 
-static int gen12_emit_oar_config(struct intel_context *ce, bool enable)
+static int gen12_emit_oar_config(struct i915_perf_stream *stream, bool enable)
 {
 	struct i915_request *rq;
+	struct intel_context *ce = stream->pinned_ctx;
 	u32 *cs;
+	u32 format = stream->oa_buffer.format;
 	int err = 0;
 
 	rq = i915_request_create(ce);
 	if (IS_ERR(rq))
 		return PTR_ERR(rq);
 
-	cs = intel_ring_begin(rq, 4);
+	cs = intel_ring_begin(rq, 6);
 	if (IS_ERR(cs)) {
 		err = PTR_ERR(cs);
 		goto out;
 	}
 
-	*cs++ = MI_LOAD_REGISTER_IMM(1);
+	*cs++ = MI_LOAD_REGISTER_IMM(2);
+	/* Enable context save/restore of OAR counters */
 	*cs++ = i915_mmio_reg_offset(RING_CONTEXT_CONTROL(ce->engine->mmio_base));
 	*cs++ = _MASKED_FIELD(GEN12_CTX_CTRL_OAR_CONTEXT_ENABLE,
 			      enable ? GEN12_CTX_CTRL_OAR_CONTEXT_ENABLE : 0);
+	/* Enable OAR counters */
+	*cs++ = i915_mmio_reg_offset(GEN12_OAR_OACONTROL);
+	*cs++ = (format << GEN12_OAR_OACONTROL_COUNTER_FORMAT_SHIFT) |
+		(enable ? GEN12_OAR_OACONTROL_COUNTER_ENABLE : 0);
 	*cs++ = MI_NOOP;
 
 	intel_ring_advance(rq, cs);
@@ -2474,8 +2481,7 @@ static int gen12_enable_metric_set(struct i915_perf_stream *stream)
 	 * requested this.
 	 */
 	if (stream->ctx) {
-		ret = gen12_emit_oar_config(stream->pinned_ctx,
-					    oa_config != NULL);
+		ret = gen12_emit_oar_config(stream, oa_config != NULL);
 		if (ret)
 			return ret;
 	}
@@ -2513,7 +2519,7 @@ static void gen12_disable_metric_set(struct i915_perf_stream *stream)
 
 	/* disable the context save/restore or OAR counters */
 	if (stream->ctx)
-		gen12_emit_oar_config(stream->pinned_ctx, false);
+		gen12_emit_oar_config(stream, false);
 
 	/* Make sure we disable noa to save power. */
 	intel_uncore_rmw(uncore, RPM_CONFIG1, GEN10_GT_NOA_ENABLE, 0);
@@ -2713,7 +2719,8 @@ static int i915_oa_stream_init(struct i915_perf_stream *stream,
 		return -EINVAL;
 	}
 
-	if (!(props->sample_flags & SAMPLE_OA_REPORT)) {
+	if (!(props->sample_flags & SAMPLE_OA_REPORT) &&
+	    (INTEL_GEN(perf->i915) < 12 || !stream->ctx)) {
 		DRM_DEBUG("Only OA report sampling supported\n");
 		return -EINVAL;
 	}
@@ -2745,7 +2752,7 @@ static int i915_oa_stream_init(struct i915_perf_stream *stream,
 
 	format_size = perf->oa_formats[props->oa_format].size;
 
-	stream->sample_flags |= SAMPLE_OA_REPORT;
+	stream->sample_flags = props->sample_flags;
 	stream->sample_size += format_size;
 
 	stream->oa_buffer.format_size = format_size;
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.CHECKPATCH: warning for drm/i915/perf: Configure OAR controls for specific context (rev2)

== Series Details ==

== Series Details ==

Series: drm/i915/perf: Configure OAR controls for specific context (rev2)
URL : https://patchwork.freedesktop.org/series/69165/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
351573b952cc drm/i915/perf: Configure OAR controls for specific context
-:65: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "oa_config"
#65: FILE: drivers/gpu/drm/i915/i915_perf.c:2484:
+		ret = gen12_emit_oar_config(stream, oa_config != NULL);

total: 0 errors, 0 warnings, 1 checks, 70 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

✓ Fi.CI.BAT: success for drm/i915/perf: Configure OAR controls for specific context (rev2)

In reply to Umesh Nerlige Ramappa
== Series Details ==

== Series Details ==

Series: drm/i915/perf: Configure OAR controls for specific context (rev2)
URL : https://patchwork.freedesktop.org/series/69165/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7290 -> Patchwork_15189
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/index.html

Known issues
------------

Here are the changes found in Patchwork_15189 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live_execlists:
- fi-glk-dsi: [PASS][1] -> [INCOMPLETE][2] ([fdo#103359] / [k.org#198133])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/fi-glk-dsi/igt@i915_selftest@live_execlists.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/fi-glk-dsi/igt@i915_selftest@live_execlists.html

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][3] -> [FAIL][4] ([fdo#111407])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/fi-kbl-7500u/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/fi-kbl-7500u/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u4: [PASS][5] -> [FAIL][6] ([fdo#103167])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/fi-icl-u4/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/fi-icl-u4/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_create@basic:
- {fi-tgl-u}: [INCOMPLETE][7] ([fdo#111736]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/fi-tgl-u/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/fi-tgl-u/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [FAIL][9] ([fdo#108511]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/fi-skl-6770hq/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/fi-skl-6770hq/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111736]: https://bugs.freedesktop.org/show_bug.cgi?id=111736
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133

Participating hosts (50 -> 46)
------------------------------

Additional (1): fi-hsw-4770r
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_7290 -> Patchwork_15189

CI-20190529: 20190529
CI_DRM_7290: 869abae66a356231cfa6645cf491adde3590cba8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5266: 60a67653613c87a69ebecf12cf00aa362ac87597 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15189: 351573b952cc6c29d4acfabf6ece5438464490f7 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

351573b952cc drm/i915/perf: Configure OAR controls for specific context

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
In reply to Umesh Nerlige Ramappa
Quoted 44 lines · Umesh Nerlige Ramappa

It turns out that the OAR CONTROL register is not getting configured correctly in conjunction with the context save/restore bit. When measuring work for a single context, the OAR counters do not increment.

- Configure OAR format and enable OAR counters at the same time as enabling context save/restore for OAR counters.
- Make SAMPLE_OA_REPORT optional from gen12.

v2: Update commit message

---
  drivers/gpu/drm/i915/i915_perf.c | 23 +++++++++++++++--------
  1 file changed, 15 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/i915_perf.c +4 -3
index 2c380aba1ce9..527a16637689 100644
@@ -2219,26 +2219,33 @@ static int gen8_configure_context(struct i915_gem_context *ctx,
  	return err;
  }
 
-static int gen12_emit_oar_config(struct intel_context *ce, bool enable)
+static int gen12_emit_oar_config(struct i915_perf_stream *stream, bool enable)
  {
  	struct i915_request *rq;
+	struct intel_context *ce = stream->pinned_ctx;
  	u32 *cs;
+	u32 format = stream->oa_buffer.format;
  	int err = 0;
 
  	rq = i915_request_create(ce);
  	if (IS_ERR(rq))
  		return PTR_ERR(rq);
 
-	cs = intel_ring_begin(rq, 4);
+	cs = intel_ring_begin(rq, 6);
  	if (IS_ERR(cs)) {
  		err = PTR_ERR(cs);
  		goto out;
  	}
 
-	*cs++ = MI_LOAD_REGISTER_IMM(1);

drivers/gpu/drm/i915/i915_perf.c static int gen8_configure_context(struct i915_gem_context *ctx, · line 2249

Quoted 10 lines
drivers/gpu/drm/i915/i915_perf.c +6 -0
+	*cs++ = MI_LOAD_REGISTER_IMM(2);
+	/* Enable context save/restore of OAR counters */
  	*cs++ = i915_mmio_reg_offset(RING_CONTEXT_CONTROL(ce->engine->mmio_base));
  	*cs++ = _MASKED_FIELD(GEN12_CTX_CTRL_OAR_CONTEXT_ENABLE,
  			      enable ? GEN12_CTX_CTRL_OAR_CONTEXT_ENABLE : 0);
+	/* Enable OAR counters */
+	*cs++ = i915_mmio_reg_offset(GEN12_OAR_OACONTROL);
+	*cs++ = (format << GEN12_OAR_OACONTROL_COUNTER_FORMAT_SHIFT) |
+		(enable ? GEN12_OAR_OACONTROL_COUNTER_ENABLE : 0);
  	*cs++ = MI_NOOP;

It's probably a good idea to configure OAR in this function indeed :)

But we're already supposed to program it through context image modification in lrc_configure_all_contexts().

So it probably means we have the wrong offset?

We should probably remove it from lrc_configure_all_contexts() then. It's probably trashing some other bit of the context image.

Quoted 22 lines
drivers/gpu/drm/i915/i915_perf.c +2 -3
  	intel_ring_advance(rq, cs);
@@ -2474,8 +2481,7 @@ static int gen12_enable_metric_set(struct i915_perf_stream *stream)
  	 * requested this.
  	 */
  	if (stream->ctx) {
-		ret = gen12_emit_oar_config(stream->pinned_ctx,
-					    oa_config != NULL);
+		ret = gen12_emit_oar_config(stream, oa_config != NULL);
  		if (ret)
  			return ret;
  	}
@@ -2513,7 +2519,7 @@ static void gen12_disable_metric_set(struct i915_perf_stream *stream)
 
  	/* disable the context save/restore or OAR counters */
  	if (stream->ctx)
-		gen12_emit_oar_config(stream->pinned_ctx, false);
+		gen12_emit_oar_config(stream, false);
 
  	/* Make sure we disable noa to save power. */
  	intel_uncore_rmw(uncore, RPM_CONFIG1, GEN10_GT_NOA_ENABLE, 0);

drivers/gpu/drm/i915/i915_perf.c static int i915_oa_stream_init(struct i915_perf_stream *stream, · line 2723

Quoted 6 lines
drivers/gpu/drm/i915/i915_perf.c +2 -1
@@ -2713,7 +2719,8 @@ static int i915_oa_stream_init(struct i915_perf_stream *stream,
  		return -EINVAL;
  	}
 
-	if (!(props->sample_flags & SAMPLE_OA_REPORT)) {
+	if (!(props->sample_flags & SAMPLE_OA_REPORT) &&
+	    (INTEL_GEN(perf->i915) < 12 || !stream->ctx)) {

Good point, but this should probably go into another patch.

Note that we could also consider not sampling the OA buffer a non privileged operation on Gen12+, since the counters are per context saved/restored.

Thanks,

-Lionel

drivers/gpu/drm/i915/i915_perf.c static int i915_oa_stream_init(struct i915_perf_stream *stream, · line 2758

Quoted 12 lines
drivers/gpu/drm/i915/i915_perf.c +1 -1
  		DRM_DEBUG("Only OA report sampling supported\n");
  		return -EINVAL;
  	}
@@ -2745,7 +2752,7 @@ static int i915_oa_stream_init(struct i915_perf_stream *stream,
 
  	format_size = perf->oa_formats[props->oa_format].size;
 
-	stream->sample_flags |= SAMPLE_OA_REPORT;
+	stream->sample_flags = props->sample_flags;
  	stream->sample_size += format_size;
 
  	stream->oa_buffer.format_size = format_size;

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
Quoted 56 lines · Lionel Landwerlin
Quoted 40 lines · Umesh Nerlige Ramappa

It turns out that the OAR CONTROL register is not getting configured correctly in conjunction with the context save/restore bit. When measuring work for a single context, the OAR counters do not increment.

- Configure OAR format and enable OAR counters at the same time as enabling context save/restore for OAR counters.
- Make SAMPLE_OA_REPORT optional from gen12.

v2: Update commit message

---
 drivers/gpu/drm/i915/i915_perf.c | 23 +++++++++++++++--------
 1 file changed, 15 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/i915_perf.c +4 -3
index 2c380aba1ce9..527a16637689 100644
@@ -2219,26 +2219,33 @@ static int gen8_configure_context(struct i915_gem_context *ctx,
 	return err;
 }
-static int gen12_emit_oar_config(struct intel_context *ce, bool enable)
+static int gen12_emit_oar_config(struct i915_perf_stream *stream, bool enable)
 {
 	struct i915_request *rq;
+	struct intel_context *ce = stream->pinned_ctx;
 	u32 *cs;
+	u32 format = stream->oa_buffer.format;
 	int err = 0;
 	rq = i915_request_create(ce);
 	if (IS_ERR(rq))
 		return PTR_ERR(rq);
-	cs = intel_ring_begin(rq, 4);
+	cs = intel_ring_begin(rq, 6);
 	if (IS_ERR(cs)) {
 		err = PTR_ERR(cs);
 		goto out;
 	}
-	*cs++ = MI_LOAD_REGISTER_IMM(1);

drivers/gpu/drm/i915/i915_perf.c static int gen8_configure_context(struct i915_gem_context *ctx, · line 2245

Quoted 10 lines
drivers/gpu/drm/i915/i915_perf.c +6 -0
+	*cs++ = MI_LOAD_REGISTER_IMM(2);
+	/* Enable context save/restore of OAR counters */
 	*cs++ = i915_mmio_reg_offset(RING_CONTEXT_CONTROL(ce->engine->mmio_base));
 	*cs++ = _MASKED_FIELD(GEN12_CTX_CTRL_OAR_CONTEXT_ENABLE,
 			      enable ? GEN12_CTX_CTRL_OAR_CONTEXT_ENABLE : 0);
+	/* Enable OAR counters */
+	*cs++ = i915_mmio_reg_offset(GEN12_OAR_OACONTROL);
+	*cs++ = (format << GEN12_OAR_OACONTROL_COUNTER_FORMAT_SHIFT) |
+		(enable ? GEN12_OAR_OACONTROL_COUNTER_ENABLE : 0);
 	*cs++ = MI_NOOP;

It's probably a good idea to configure OAR in this function indeed :)

Quoted 7 lines

But we're already supposed to program it through context image modification in lrc_configure_all_contexts().

So it probably means we have the wrong offset?

We should probably remove it from lrc_configure_all_contexts() then. It's probably trashing some other bit of the context image.

Offset is correct.

When I removed the configuration from lrc_configure_all_contexts(), the test broke :(

Debugging further, it looks like OAR config (OAR_OACONTROL and RING_CONTEXT_CONTROL) must be applied to pinned ctx image as well as with LRI using kernel_context

For gen12, lrc_configure_all_contexts only needs to configure the stable power state.

Posting rev2, verified with test as posted here - https://patchwork.freedesktop.org/patch/339514/?series=69164&rev=1

The expectation is that oar counters are saved and restored only for the context passed in perf open ioctl. Also, if some other context issues MI_RPC, it should get valid timestamps, context id etc.., but zeroed counter reports. Let me know if this is not the right understanding.

Quoted 30 lines
Quoted 21 lines
drivers/gpu/drm/i915/i915_perf.c +2 -3
 	intel_ring_advance(rq, cs);
@@ -2474,8 +2481,7 @@ static int gen12_enable_metric_set(struct i915_perf_stream *stream)
 	 * requested this.
 	 */
 	if (stream->ctx) {
-		ret = gen12_emit_oar_config(stream->pinned_ctx,
-					    oa_config != NULL);
+		ret = gen12_emit_oar_config(stream, oa_config != NULL);
 		if (ret)
 			return ret;
 	}
@@ -2513,7 +2519,7 @@ static void gen12_disable_metric_set(struct i915_perf_stream *stream)
 	/* disable the context save/restore or OAR counters */
 	if (stream->ctx)
-		gen12_emit_oar_config(stream->pinned_ctx, false);
+		gen12_emit_oar_config(stream, false);
 	/* Make sure we disable noa to save power. */
 	intel_uncore_rmw(uncore, RPM_CONFIG1, GEN10_GT_NOA_ENABLE, 0);

drivers/gpu/drm/i915/i915_perf.c static int i915_oa_stream_init(struct i915_perf_stream *stream, · line 2722

Quoted 5 lines
drivers/gpu/drm/i915/i915_perf.c +2 -1
@@ -2713,7 +2719,8 @@ static int i915_oa_stream_init(struct i915_perf_stream *stream,
 		return -EINVAL;
 	}
-	if (!(props->sample_flags & SAMPLE_OA_REPORT)) {
+	if (!(props->sample_flags & SAMPLE_OA_REPORT) &&
+	    (INTEL_GEN(perf->i915) < 12 || !stream->ctx)) {

Good point, but this should probably go into another patch.

Quoted 2 lines

Note that we could also consider not sampling the OA buffer a non privileged operation on Gen12+, since the counters are per context saved/restored.

The TGL support patch already makes 'not sampling the OA buffer' non-privileged. These changes are only clearing the path. I have moved them to a separate patch in v2.

Thanks,
Umesh

Quoted 6 lines

Thanks,

-Lionel

Quoted 11 lines

drivers/gpu/drm/i915/i915_perf.c static int i915_oa_stream_init(struct i915_perf_stream *stream, · line 2755

Quoted 9 lines
drivers/gpu/drm/i915/i915_perf.c +1 -1
 		DRM_DEBUG("Only OA report sampling supported\n");
 		return -EINVAL;
 	}
@@ -2745,7 +2752,7 @@ static int i915_oa_stream_init(struct i915_perf_stream *stream,
 	format_size = perf->oa_formats[props->oa_format].size;
-	stream->sample_flags |= SAMPLE_OA_REPORT;
+	stream->sample_flags = props->sample_flags;
 	stream->sample_size += format_size;
 	stream->oa_buffer.format_size = format_size;

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw
Quoted 65 lines · Umesh Nerlige Ramappa
Quoted 64 lines · Lionel Landwerlin
Quoted 43 lines · Umesh Nerlige Ramappa

It turns out that the OAR CONTROL register is not getting configured correctly in conjunction with the context save/restore bit. When measuring work for a single context, the OAR counters do not increment.

- Configure OAR format and enable OAR counters at the same time as enabling context save/restore for OAR counters.
- Make SAMPLE_OA_REPORT optional from gen12.

v2: Update commit message

---
 drivers/gpu/drm/i915/i915_perf.c | 23 +++++++++++++++--------

 1 file changed, 15 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/i915_perf.c +4 -3
index 2c380aba1ce9..527a16637689 100644
@@ -2219,26 +2219,33 @@ static int gen8_configure_context(struct 
 i915_gem_context *ctx,
      return err;
  }
-static int gen12_emit_oar_config(struct intel_context *ce, bool 
 enable)
+static int gen12_emit_oar_config(struct i915_perf_stream *stream, 
 bool enable)
  {
      struct i915_request *rq;
+    struct intel_context *ce = stream->pinned_ctx;
      u32 *cs;
+    u32 format = stream->oa_buffer.format;
      int err = 0;
      rq = i915_request_create(ce);
      if (IS_ERR(rq))
          return PTR_ERR(rq);
-    cs = intel_ring_begin(rq, 4);
+    cs = intel_ring_begin(rq, 6);
      if (IS_ERR(cs)) {
          err = PTR_ERR(cs);
          goto out;
      }
-    *cs++ = MI_LOAD_REGISTER_IMM(1);

drivers/gpu/drm/i915/i915_perf.c static int gen8_configure_context(struct · line 2248

Quoted 10 lines
drivers/gpu/drm/i915/i915_perf.c +6 -0
+    *cs++ = MI_LOAD_REGISTER_IMM(2);
+    /* Enable context save/restore of OAR counters */
      *cs++ = i915_mmio_reg_offset(RING_CONTEXT_CONTROL(ce->engine->mmio_base));
      *cs++ = _MASKED_FIELD(GEN12_CTX_CTRL_OAR_CONTEXT_ENABLE,
                    enable ? GEN12_CTX_CTRL_OAR_CONTEXT_ENABLE : 0);
+    /* Enable OAR counters */
+    *cs++ = i915_mmio_reg_offset(GEN12_OAR_OACONTROL);
+    *cs++ = (format << GEN12_OAR_OACONTROL_COUNTER_FORMAT_SHIFT) |
+        (enable ? GEN12_OAR_OACONTROL_COUNTER_ENABLE : 0);
      *cs++ = MI_NOOP;

It's probably a good idea to configure OAR in this function indeed :)

But we're already supposed to program it through context image modification in lrc_configure_all_contexts().

So it probably means we have the wrong offset?

Quoted 7 lines
Quoted 2 lines

We should probably remove it from lrc_configure_all_contexts() then. It's probably trashing some other bit of the context image.

Offset is correct.

When I removed the configuration from lrc_configure_all_contexts(), the test broke :(
Debugging further, it looks like OAR config (OAR_OACONTROL and RING_CONTEXT_CONTROL) must be applied to pinned ctx image as well as with LRI using kernel_context

We must be missing something, because that doesn't make sense. OAR_OACONTROL ought to be needed only for pinned_ctx.

If we program it through gen12_emit_oar_config() there is no need to do it in lrc_configure_all_contexts() as well.

Quoted 5 lines

For gen12, lrc_configure_all_contexts only needs to configure the stable power state.

Posting rev2, verified with test as posted here - https://patchwork.freedesktop.org/patch/339514/?series=69164&rev=1
The expectation is that oar counters are saved and restored only for the context passed in perf open ioctl. Also, if some other context issues MI_RPC, it should get valid timestamps, context id etc.., but zeroed counter reports. Let me know if this is not the right understanding.

If I remember correctly, the documentation says MI_RPC results are undefined if OAR is not enabled.

So I wouldn't even expect timestamps/context-id to be valid.

Quoted 33 lines
Quoted 33 lines
Quoted 23 lines
drivers/gpu/drm/i915/i915_perf.c +1 -2
      intel_ring_advance(rq, cs);
@@ -2474,8 +2481,7 @@ static int gen12_enable_metric_set(struct 
 i915_perf_stream *stream)
       * requested this.
       */
      if (stream->ctx) {
-        ret = gen12_emit_oar_config(stream->pinned_ctx,
-                        oa_config != NULL);
+        ret = gen12_emit_oar_config(stream, oa_config != NULL);
          if (ret)
              return ret;

     }

drivers/gpu/drm/i915/i915_perf.c +1 -1
@@ -2513,7 +2519,7 @@ static void gen12_disable_metric_set(struct 
 i915_perf_stream *stream)
      /* disable the context save/restore or OAR counters */
      if (stream->ctx)
-        gen12_emit_oar_config(stream->pinned_ctx, false);
+        gen12_emit_oar_config(stream, false);
      /* Make sure we disable noa to save power. */
      intel_uncore_rmw(uncore, RPM_CONFIG1, GEN10_GT_NOA_ENABLE, 0);

drivers/gpu/drm/i915/i915_perf.c static int i915_oa_stream_init(struct · line 2723

Quoted 6 lines
drivers/gpu/drm/i915/i915_perf.c +2 -1
@@ -2713,7 +2719,8 @@ static int i915_oa_stream_init(struct 
 i915_perf_stream *stream,
          return -EINVAL;
      }
-    if (!(props->sample_flags & SAMPLE_OA_REPORT)) {
+    if (!(props->sample_flags & SAMPLE_OA_REPORT) &&
+        (INTEL_GEN(perf->i915) < 12 || !stream->ctx)) {

Good point, but this should probably go into another patch.

Quoted 4 lines
Quoted 2 lines

Note that we could also consider not sampling the OA buffer a non privileged operation on Gen12+, since the counters are per context saved/restored.

The TGL support patch already makes 'not sampling the OA buffer' non-privileged. These changes are only clearing the path. I have moved them to a separate patch in v2.

Oh... Thanks I didn't remember that.

Quoted 22 lines

Thanks,
Umesh

Quoted 18 lines

Thanks,

-Lionel

Quoted 10 lines
drivers/gpu/drm/i915/i915_perf.c +1 -1
          DRM_DEBUG("Only OA report sampling supported\n");
          return -EINVAL;
      }
@@ -2745,7 +2752,7 @@ static int i915_oa_stream_init(struct 
 i915_perf_stream *stream,
      format_size = perf->oa_formats[props->oa_format].size;
-    stream->sample_flags |= SAMPLE_OA_REPORT;
+    stream->sample_flags = props->sample_flags;
      stream->sample_size += format_size;
      stream->oa_buffer.format_size = format_size;

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

✓ Fi.CI.IGT: success for drm/i915/perf: Configure OAR controls for specific context (rev2)

In reply to Umesh Nerlige Ramappa
== Series Details ==

== Series Details ==

Series: drm/i915/perf: Configure OAR controls for specific context (rev2)
URL : https://patchwork.freedesktop.org/series/69165/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7290_full -> Patchwork_15189_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_15189_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_exec@basic-invalid-context-vcs1:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#112080]) +10 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-iclb3/igt@[email protected]

* igt@gem_ctx_isolation@vcs1-dirty-create:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-iclb5/igt@[email protected]

* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#110841])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb8/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-iclb4/igt@[email protected]

* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#109276]) +18 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb4/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-iclb7/igt@[email protected]

* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112146]) +8 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb7/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-iclb1/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-hsw: [PASS][11] -> [DMESG-WARN][12] ([fdo#111870]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-hsw6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-hsw2/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-snb: [PASS][13] -> [DMESG-WARN][14] ([fdo#111870])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-snb1/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-snb5/igt@[email protected]

* igt@i915_selftest@live_gt_timelines:
- shard-tglb: [PASS][15] -> [INCOMPLETE][16] ([fdo#111831])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb1/igt@i915_selftest@live_gt_timelines.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-tglb4/igt@i915_selftest@live_gt_timelines.html

* igt@i915_suspend@debugfs-reader:
- shard-tglb: [PASS][17] -> [INCOMPLETE][18] ([fdo#111832] / [fdo#111850])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb3/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-tglb2/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-apl: [PASS][19] -> [DMESG-WARN][20] ([fdo#108566])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-apl4/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-apl6/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-render-untiled:
- shard-skl: [PASS][21] -> [FAIL][22] ([fdo#103184] / [fdo#103232])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-skl5/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-skl4/igt@[email protected]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-tglb: [PASS][23] -> [INCOMPLETE][24] ([fdo#111747] / [fdo#111832] / [fdo#111850])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb9/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-tglb4/igt@[email protected]

* igt@kms_flip@2x-flip-vs-suspend-interruptible:
- shard-hsw: [PASS][25] -> [INCOMPLETE][26] ([fdo#103540])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-hsw6/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-hsw1/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-kbl: [PASS][27] -> [DMESG-WARN][28] ([fdo#108566]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-kbl6/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-kbl7/igt@[email protected]

* igt@kms_flip@plain-flip-fb-recreate:
- shard-skl: [PASS][29] -> [FAIL][30] ([fdo#100368])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-skl3/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-skl2/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- shard-iclb: [PASS][31] -> [FAIL][32] ([fdo#103167]) +3 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb1/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-iclb8/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-tglb: [PASS][33] -> [FAIL][34] ([fdo#103167]) +6 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb3/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-tglb2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-tglb: [PASS][35] -> [DMESG-FAIL][36] ([fdo#111600])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb7/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-tglb3/igt@[email protected]

* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][37] -> [FAIL][38] ([fdo#103166])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb2/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-iclb8/igt@[email protected]

* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#109441]) +4 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-iclb8/igt@kms_psr@psr2_cursor_mmap_cpu.html

* igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend:
- shard-tglb: [PASS][41] -> [INCOMPLETE][42] ([fdo#111850])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb7/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-tglb1/igt@[email protected]

#### Possible fixes ####

* igt@gem_busy@busy-vcs1:
- shard-iclb: [SKIP][43] ([fdo#112080]) -> [PASS][44] +16 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb6/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-iclb2/igt@[email protected]

* igt@gem_ctx_isolation@vcs1-none:
- shard-iclb: [SKIP][45] ([fdo#109276] / [fdo#112080]) -> [PASS][46] +4 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb7/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-iclb4/igt@[email protected]

* igt@gem_eio@in-flight-suspend:
- shard-tglb: [INCOMPLETE][47] ([fdo#111832] / [fdo#111850] / [fdo#112081]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb7/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-tglb6/igt@[email protected]

* igt@gem_exec_schedule@in-order-bsd:
- shard-iclb: [SKIP][49] ([fdo#112146]) -> [PASS][50] +4 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb1/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-iclb3/igt@[email protected]

* igt@gem_exec_schedule@smoketest-blt:
- shard-tglb: [INCOMPLETE][51] ([fdo#111867]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb6/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-tglb4/igt@[email protected]

* igt@gem_mmap_gtt@hang:
- shard-snb: [INCOMPLETE][53] ([fdo#105411]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-snb2/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-snb7/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-snb: [DMESG-WARN][55] ([fdo#111870]) -> [PASS][56] +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-snb1/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-snb7/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-hsw: [DMESG-WARN][57] ([fdo#110789] / [fdo#111870]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-hsw8/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-hsw2/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][59] ([fdo#110548]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb4/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-iclb1/igt@[email protected]

* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-tglb: [INCOMPLETE][61] ([fdo#111832] / [fdo#111850]) -> [PASS][62] +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb8/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-tglb3/igt@[email protected]

* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [DMESG-WARN][63] ([fdo#108566]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-apl4/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-apl4/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][65] ([fdo#108566]) -> [PASS][66] +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-kbl4/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-kbl2/igt@[email protected]
- shard-skl: [INCOMPLETE][67] ([fdo#110741]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-skl6/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-skl7/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-untiled:
- shard-skl: [FAIL][69] ([fdo#103184] / [fdo#103232]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-skl5/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-skl4/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [FAIL][71] ([fdo#105363]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-skl2/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-skl10/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-tglb: [INCOMPLETE][73] ([fdo#111832] / [fdo#111850] / [fdo#112031]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb4/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-tglb6/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
- shard-iclb: [FAIL][75] ([fdo#103167]) -> [PASS][76] +5 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- shard-iclb: [FAIL][77] ([fdo#103167] / [fdo#110378]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb6/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-iclb2/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-gtt:
- shard-tglb: [FAIL][79] ([fdo#103167]) -> [PASS][80] +2 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb7/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-tglb9/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][81] ([fdo#108145] / [fdo#110403]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-skl6/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-skl10/igt@[email protected]

* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [SKIP][83] ([fdo#109441]) -> [PASS][84] +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb6/igt@kms_psr@psr2_primary_page_flip.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html

* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [SKIP][85] ([fdo#109276]) -> [PASS][86] +14 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb7/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-iclb4/igt@[email protected]

#### Warnings ####

* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][87] ([fdo#109276] / [fdo#112080]) -> [FAIL][88] ([fdo#111329])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb6/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-iclb2/igt@[email protected]

* igt@gem_ctx_isolation@vcs2-s3:
- shard-tglb: [SKIP][89] ([fdo#111912] / [fdo#112080]) -> [SKIP][90] ([fdo#112080])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb6/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-tglb9/igt@[email protected]

* igt@gem_eio@kms:
- shard-snb: [DMESG-WARN][91] ([fdo# 112000 ] / [fdo#111781]) -> [DMESG-WARN][92] ([fdo# 112000 ] / [fdo#111780 ] / [fdo#111781])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-snb1/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-snb5/igt@[email protected]

* igt@gem_mocs_settings@mocs-reset-bsd2:
- shard-iclb: [FAIL][93] ([fdo#111330]) -> [SKIP][94] ([fdo#109276])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb4/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-iclb7/igt@[email protected]

* igt@gem_userptr_blits@sync-unmap-after-close:
- shard-hsw: [DMESG-WARN][95] ([fdo#111870]) -> [DMESG-WARN][96] ([fdo#110789] / [fdo#111870])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-hsw6/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-hsw1/igt@[email protected]

* igt@i915_pm_dc@dc6-dpms:
- shard-tglb: [FAIL][97] ([fdo#111830 ]) -> [SKIP][98] ([fdo#111865])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb4/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-tglb6/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-tglb: [FAIL][99] ([fdo#111703]) -> [INCOMPLETE][100] ([fdo#111832] / [fdo#111850])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb9/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-tglb5/igt@[email protected]

* igt@kms_psr@psr2_suspend:
- shard-iclb: [SKIP][101] ([fdo#109441]) -> [DMESG-WARN][102] ([fdo#107724])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb6/igt@kms_psr@psr2_suspend.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/shard-iclb2/igt@kms_psr@psr2_suspend.html

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo# 112000 ]: https://bugs.freedesktop.org/show_bug.cgi?id= 112000 [fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15189/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx