Skip to contentSkip to conversation

dmaengine: dma-jz4780: add missed clk_disable_unprepare in remove

PATCH Applied Chuhong Yuan 3 participants 3 messages Nov 4, 2019 – Nov 8, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dmaengine: dma-jz4780: add missed clk_disable_unprepare in remove

The remove misses to disable and unprepare jzdma->clk. Add a call to clk_disable_unprepare to fix it.

---
 drivers/dma/dma-jz4780.c | 1 +
 1 file changed, 1 insertion(+)
drivers/dma/dma-jz4780.c +1 -0
index cafb1cc065bb..66ab76b9520f 100644
@@ -987,6 +987,7 @@ static int jz4780_dma_remove(struct platform_device *pdev)
 
 	of_dma_controller_free(pdev->dev.of_node);
 
+	clk_disable_unprepare(jzdma->clk);
 	free_irq(jzdma->irq, jzdma);
 
 	for (i = 0; i < jzdma->soc_data->nb_channels; i++)
Signature · 1 line
2.23.0
maintainer Acked-by on v1 1/1
#1 lore raw

Hi,

Quoted 4 lines · Chuhong Yuan

The remove misses to disable and unprepare jzdma->clk. Add a call to clk_disable_unprepare to fix it.

Thanks.

Quoted 20 lines
---
 drivers/dma/dma-jz4780.c | 1 +
 1 file changed, 1 insertion(+)
drivers/dma/dma-jz4780.c +1 -0
index cafb1cc065bb..66ab76b9520f 100644
@@ -987,6 +987,7 @@ static int jz4780_dma_remove(struct 
 platform_device *pdev)
 
 	of_dma_controller_free(pdev->dev.of_node);
 
+	clk_disable_unprepare(jzdma->clk);
 	free_irq(jzdma->irq, jzdma);
 

for (i = 0; i < jzdma->soc_data->nb_channels; i++)
--
2.23.0

maintainer Applied
#2 lore raw
In reply to Chuhong Yuan
Quoted 2 lines · Chuhong Yuan

The remove misses to disable and unprepare jzdma->clk. Add a call to clk_disable_unprepare to fix it.

Applied, thanks

Signature · 1 line
~Vinod