Skip to contentSkip to conversation

xfs: remove a stray tab in xfs_remount_rw()

PATCH In review Dan Carpenter 4 participants 4 messages Nov 8, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs: remove a stray tab in xfs_remount_rw()

The extra tab makes the code slightly confusing.

---
 fs/xfs/xfs_super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_super.c +1 -1
index b3188ea49413..ede6fac47c56 100644
@@ -1599,7 +1599,7 @@ xfs_remount_rw(
 	if (error) {
 		xfs_err(mp,
 			"Error %d recovering leftover CoW allocations.", error);
-			xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE);
+		xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE);
 		return error;
 	}
 	xfs_start_block_reaping(mp);
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#2 lore raw
In reply to Dan Carpenter
Quoted 12 lines · Dan Carpenter

The extra tab makes the code slightly confusing.

---
 fs/xfs/xfs_super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_super.c +0 -0
index b3188ea49413..ede6fac47c56 100644

fs/xfs/xfs_super.c xfs_remount_rw( · line 1605

Quoted 8 lines
fs/xfs/xfs_super.c +1 -1
@@ -1599,7 +1599,7 @@ xfs_remount_rw(
 	if (error) {
 		xfs_err(mp,
 			"Error %d recovering leftover CoW allocations.", error);
-			xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE);
+		xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE);
 		return error;
 	}
 	xfs_start_block_reaping(mp);

Indeed, my bad.

Reviewed-by on v1 1/1
#3 lore raw
In reply to Dan Carpenter
Quoted 3 lines · Dan Carpenter

The extra tab makes the code slightly confusing.

Looks ok,

--D

Quoted 20 lines
---
 fs/xfs/xfs_super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_super.c +1 -1
index b3188ea49413..ede6fac47c56 100644
@@ -1599,7 +1599,7 @@ xfs_remount_rw(
 	if (error) {
 		xfs_err(mp,
 			"Error %d recovering leftover CoW allocations.", error);
-			xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE);
+		xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE);
 		return error;
 	}
 	xfs_start_block_reaping(mp);
Signature · 1 line
2.20.1