Skip to contentSkip to conversation

ath10k: fix get invalid tx rate for Mesh metric

PATCH In review Miaoqing Pan 2 participants 3 messages Oct 29, 2019 – Nov 8, 2019 Qualcomm Atheros ATH10K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath10k: fix get invalid tx rate for Mesh metric

ath10k does not provide transmit rate info per MSDU in tx completion, mark that as -1 so mac80211 will ignore the rates. This fixes mac80211 update Mesh link metric with invalid transmit rate info.

Tested HW: QCA9984
Tested FW: 10.4-3.9.0.2-00035

---
 drivers/net/wireless/ath/ath10k/txrx.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/wireless/ath/ath10k/txrx.c +2 -0
index 4102df0..39abf8b 100644
@@ -95,6 +95,8 @@ int ath10k_txrx_tx_unref(struct ath10k_htt *htt,
 
 	info = IEEE80211_SKB_CB(msdu);
 	memset(&info->status, 0, sizeof(info->status));
+	info->status.rates[0].idx = -1;
+
 	trace_ath10k_txrx_tx_unref(ar, tx_done->msdu_id);
 
 	if (!(info->flags & IEEE80211_TX_CTL_NO_ACK))
Signature · 1 line
1.9.1
#1 lore raw
Quoted 5 lines · Miaoqing Pan

ath10k does not provide transmit rate info per MSDU in tx completion, mark that as -1 so mac80211 will ignore the rates. This fixes mac80211 update Mesh link metric with invalid transmit rate info.

Quoted 7 lines

Tested HW: QCA9984
Tested FW: 10.4-3.9.0.2-00035

Patch applied to ath-next branch of ath.git, thanks.

05a11003a565 ath10k: fix get invalid tx rate for Mesh metric

Signature · 9 lines
https://patchwork.kernel.org/patch/11217003/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#2 lore raw
In reply to Miaoqing Pan
Quoted 5 lines · Miaoqing Pan

ath10k does not provide transmit rate info per MSDU in tx completion, mark that as -1 so mac80211 will ignore the rates. This fixes mac80211 update Mesh link metric with invalid transmit rate info.

Quoted 7 lines

Tested HW: QCA9984
Tested FW: 10.4-3.9.0.2-00035

Patch applied to ath-next branch of ath.git, thanks.

05a11003a565 ath10k: fix get invalid tx rate for Mesh metric

Signature · 3 lines
https://patchwork.kernel.org/patch/11217003/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches