powerpc: add const qual to local_read() parameter
PATCH 1/1 powerpc: add const qual to local_read() parameter
A patch in net-next triggered a compile error on powerpc.
This seems reasonable to relax powerpc local_read() requirements.
Fixes 316580b69d0a ("u64_stats: provide u64_stats_t type")
Signed-off-by Eric Dumazet <[email protected]>
Reported-by kbuild test robot <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Michael Ellerman <[email protected]>
--- arch/powerpc/include/asm/local.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/include/asm/local.h +1 -1
@@ -17,7 +17,7 @@ typedef struct#define LOCAL_INIT (i) { (i) } -static __inline__long local_read (local_t *l) +static __inline__long local_read (const local_t *l) {return READ_ONCE (l->v); }
Signature · 1 line
2.24.0.432.g9d3f5f5b63-goog
Quoted 1 line · Eric Dumazet
A patch in net-next triggered a compile error on powerpc.
Would be nice to mention the compiler error, I haven't seen the report.
Quoted 1 line
This seems reasonable to relax powerpc
local_read()requirements.
Seems fine.
Acked-by Michael Ellerman <[email protected]>
Dave can you please put this in net-next to limit the window of breakage.
cheers
Quoted 7 lines
Fixes 316580b69d0a ("u64_stats: provide u64_stats_t type")Signed-off-by Eric Dumazet <[email protected]>Reported-by kbuild test robot <[email protected]>Cc Benjamin Herrenschmidt <[email protected]>Cc Paul Mackerras <[email protected]>Cc Michael Ellerman <[email protected]>
Seems it didn't actually get cc'ed to linuxppc-dev for some reason.
Quoted 19 lines
--- arch/powerpc/include/asm/local.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/powerpc/include/asm/local.h +1
-1@@ -17,7 +17,7 @@ typedef struct#define LOCAL_INIT (i) { (i) } -static __inline__long local_read (local_t *l) +static __inline__long local_read (const local_t *l) {return READ_ONCE (l->v); }Signature · 1 line
2.24.0.432.g9d3f5f5b63-goog