Skip to contentSkip to conversation

powerpc: add const qual to local_read() parameter

PATCH In review Eric Dumazet 2 participants 2 messages Nov 8, 2019 – Nov 11, 2019 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: add const qual to local_read() parameter

A patch in net-next triggered a compile error on powerpc.

This seems reasonable to relax powerpc local_read() requirements.

Fixes 316580b69d0a ("u64_stats: provide u64_stats_t type")
Cc Benjamin Herrenschmidt <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Michael Ellerman <[email protected]>
---
 arch/powerpc/include/asm/local.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/include/asm/local.h +1 -1
index fdd00939270bf08113b537a090d6a6e34a048361..bc4bd19b7fc235b80ec1132f44409b6fe1057975 100644
@@ -17,7 +17,7 @@ typedef struct
 
 #define LOCAL_INIT(i)	{ (i) }
 
-static __inline__ long local_read(local_t *l)
+static __inline__ long local_read(const local_t *l)
 {
 	return READ_ONCE(l->v);
 }
Signature · 1 line
2.24.0.432.g9d3f5f5b63-goog
reviewer Acked-by on v1 1/1
#1 lore raw
Quoted 1 line · Eric Dumazet

A patch in net-next triggered a compile error on powerpc.

Would be nice to mention the compiler error, I haven't seen the report.

Quoted 1 line

This seems reasonable to relax powerpc local_read() requirements.

Seems fine.

Dave can you please put this in net-next to limit the window of breakage.

cheers

Quoted 7 lines
Fixes 316580b69d0a ("u64_stats: provide u64_stats_t type")
Cc Benjamin Herrenschmidt <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Michael Ellerman <[email protected]>

Seems it didn't actually get cc'ed to linuxppc-dev for some reason.

Quoted 19 lines
---
 arch/powerpc/include/asm/local.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/include/asm/local.h +1 -1
index fdd00939270bf08113b537a090d6a6e34a048361..bc4bd19b7fc235b80ec1132f44409b6fe1057975 100644
@@ -17,7 +17,7 @@ typedef struct
 
 #define LOCAL_INIT(i)	{ (i) }
 
-static __inline__ long local_read(local_t *l)
+static __inline__ long local_read(const local_t *l)
 {
 	return READ_ONCE(l->v);
 }
Signature · 1 line
2.24.0.432.g9d3f5f5b63-goog