Skip to contentSkip to conversation

cmd: move down CONFIG_CMD_BOOTEFI after CONFIG_BOOTM_VXWORKS

PATCH New AKASHI Takahiro 3 participants 4 messages Nov 8, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cmd: move down CONFIG_CMD_BOOTEFI after CONFIG_BOOTM_VXWORKS

Due to the commit 4b0bcfa7c4ec ("Kconfig: Migrate CONFIG_BOOTM_* options") BOOTEFI and BOOTEFI_HELLO_COMPILE (and other BOOTEFI configs) are displayed in a long distance. This will make it difficult for us to understand that those configurations are closely related.

---
 cmd/Kconfig | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
cmd/Kconfig +7 -7
index 395dedd34d00..d9bc1eb8bd2b 100644
@@ -263,13 +263,6 @@ config CMD_BOOTI
 	help
 	  Boot an AArch64 Linux Kernel image from memory.
 
-config CMD_BOOTEFI
-	bool "bootefi"
-	depends on EFI_LOADER
-	default y
-	help
-	  Boot an EFI image from memory.
-
 config BOOTM_LINUX
 	bool "Support booting Linux OS images"
 	depends on CMD_BOOTM || CMD_BOOTZ || CMD_BOOTI
@@ -318,6 +311,13 @@ config BOOTM_VXWORKS
 	help
 	  Support booting VxWorks images via the bootm command.
 
+config CMD_BOOTEFI
+	bool "bootefi"
+	depends on EFI_LOADER
+	default y
+	help
+	  Boot an EFI image from memory.
+
 config CMD_BOOTEFI_HELLO_COMPILE
 	bool "Compile a standard EFI hello world binary for testing"
 	depends on CMD_BOOTEFI && !CPU_V7M && !SANDBOX
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/1 cmd: move down CONFIG_CMD_BOOTEFI after CONFIG_BOOTM_VXWORKS

Quoted 6 lines · AKASHI Takahiro

Due to the commit 4b0bcfa7c4ec ("Kconfig: Migrate CONFIG_BOOTM_* options") BOOTEFI and BOOTEFI_HELLO_COMPILE (and other BOOTEFI configs) are displayed in a long distance. This will make it difficult for us to understand that those configurations are closely related.

This is what the change looks like:

== BEFORE ==

[*] bootm
[ ] bootz
-*- booti
[*] bootefi
[*] Support booting Linux OS images
[*] Support booting NetBSD (non-EFI) loader images [ ] Support booting OPENRTOS / FreeRTOS images
[ ] Support booting Enea OSE images
[*] Support booting Plan9 OS images
[*] Support booting RTEMS OS images
[*] Support booting VxWorks OS images
[*] Compile a standard EFI hello world binary for testing
[ ] Allow booting a standard EFI hello world for testing
[*] UEFI unit tests
[ ] bootmenu

== AFTER ==

[*] bootm
[ ] bootz
-*- booti
[*] Support booting Linux OS images
[*] Support booting NetBSD (non-EFI) loader images [ ] Support booting OPENRTOS / FreeRTOS images [ ] Support booting Enea OSE images
[*] Support booting Plan9 OS images
[*] Support booting RTEMS OS images
[*] Support booting VxWorks OS images
[*] bootefi
[*] Compile a standard EFI hello world binary for testing
[ ] Allow booting a standard EFI hello world for testing
[*] UEFI unit tests
[ ] bootmenu

Quoted 37 lines
---
  cmd/Kconfig | 14 +++++++-------
  1 file changed, 7 insertions(+), 7 deletions(-)
cmd/Kconfig +7 -7
index 395dedd34d00..d9bc1eb8bd2b 100644
@@ -263,13 +263,6 @@ config CMD_BOOTI
  	help
  	  Boot an AArch64 Linux Kernel image from memory.
 
-config CMD_BOOTEFI
-	bool "bootefi"
-	depends on EFI_LOADER
-	default y
-	help
-	  Boot an EFI image from memory.
-
  config BOOTM_LINUX
  	bool "Support booting Linux OS images"
  	depends on CMD_BOOTM || CMD_BOOTZ || CMD_BOOTI
@@ -318,6 +311,13 @@ config BOOTM_VXWORKS
  	help
  	  Support booting VxWorks images via the bootm command.
 
+config CMD_BOOTEFI
+	bool "bootefi"
+	depends on EFI_LOADER
+	default y
+	help
+	  Boot an EFI image from memory.
+
  config CMD_BOOTEFI_HELLO_COMPILE
  	bool "Compile a standard EFI hello world binary for testing"
  	depends on CMD_BOOTEFI && !CPU_V7M && !SANDBOX
#2 lore raw

PATCH 1/1 cmd: move down CONFIG_CMD_BOOTEFI after CONFIG_BOOTM_VXWORKS

Quoted 46 lines · Heinrich Schuchardt
Quoted 6 lines · AKASHI Takahiro

Due to the commit 4b0bcfa7c4ec ("Kconfig: Migrate CONFIG_BOOTM_* options") BOOTEFI and BOOTEFI_HELLO_COMPILE (and other BOOTEFI configs) are displayed in a long distance. This will make it difficult for us to understand that those configurations are closely related.

This is what the change looks like:

== BEFORE ==

[*] bootm
[ ] bootz
-*- booti
[*] bootefi
[*] Support booting Linux OS images
[*] Support booting NetBSD (non-EFI) loader images [ ] Support booting OPENRTOS / FreeRTOS images
[ ] Support booting Enea OSE images
[*] Support booting Plan9 OS images
[*] Support booting RTEMS OS images
[*] Support booting VxWorks OS images
[*] Compile a standard EFI hello world binary for testing
[ ] Allow booting a standard EFI hello world for testing
[*] UEFI unit tests
[ ] bootmenu

== AFTER ==

[*] bootm
[ ] bootz
-*- booti
[*] Support booting Linux OS images
[*] Support booting NetBSD (non-EFI) loader images [ ] Support booting OPENRTOS / FreeRTOS images [ ] Support booting Enea OSE images
[*] Support booting Plan9 OS images
[*] Support booting RTEMS OS images
[*] Support booting VxWorks OS images
[*] bootefi
[*] Compile a standard EFI hello world binary for testing
[ ] Allow booting a standard EFI hello world for testing
[*] UEFI unit tests
[ ] bootmenu

Quoted 1 line

Oops, I got things off by an entry, thanks for fixing this.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191108/02f75130/attachment.sig>
#3 lore raw

PATCH 1/1 cmd: move down CONFIG_CMD_BOOTEFI after CONFIG_BOOTM_VXWORKS

In reply to AKASHI Takahiro
Quoted 8 lines · AKASHI Takahiro

Due to the commit 4b0bcfa7c4ec ("Kconfig: Migrate CONFIG_BOOTM_* options") BOOTEFI and BOOTEFI_HELLO_COMPILE (and other BOOTEFI configs) are displayed in a long distance. This will make it difficult for us to understand that those configurations are closely related.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191108/3f78f9d9/attachment.sig>