Skip to contentSkip to conversation

arm64: tegra: Disable secondary CPUs on Tegra194

PATCH In review Thierry Reding 2 participants 2 messages Nov 8, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: tegra: Disable secondary CPUs on Tegra194

From: Thierry Reding <[email protected]>

According to ePAPR, CPUs that are quiescent should have the "status" property of the corresponding device tree node set to "disabled". Since all but the boot CPU are in a quiescent state on boot, mark all secondary CPUs as "disabled".

Note that this does not have an impact on SMP. Linux will still be able to boot these secondary CPUs like before.

---
 arch/arm64/boot/dts/nvidia/tegra194.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm64/boot/dts/nvidia/tegra194.dtsi +7 -0
index 59485976db64..ea165b2998f9 100644
@@ -1661,6 +1661,7 @@
 			compatible = "nvidia,tegra194-carmel";
 			device_type = "cpu";
 			reg = <0x001>;
+			status = "disabled";
 			enable-method = "psci";
 			i-cache-size = <131072>;
 			i-cache-line-size = <64>;
@@ -1675,6 +1676,7 @@
 			compatible = "nvidia,tegra194-carmel";
 			device_type = "cpu";
 			reg = <0x100>;
+			status = "disabled";
 			enable-method = "psci";
 			i-cache-size = <131072>;
 			i-cache-line-size = <64>;
@@ -1689,6 +1691,7 @@
 			compatible = "nvidia,tegra194-carmel";
 			device_type = "cpu";
 			reg = <0x101>;
+			status = "disabled";
 			enable-method = "psci";
 			i-cache-size = <131072>;
 			i-cache-line-size = <64>;
@@ -1703,6 +1706,7 @@
 			compatible = "nvidia,tegra194-carmel";
 			device_type = "cpu";
 			reg = <0x200>;
+			status = "disabled";
 			enable-method = "psci";
 			i-cache-size = <131072>;
 			i-cache-line-size = <64>;
@@ -1717,6 +1721,7 @@
 			compatible = "nvidia,tegra194-carmel";
 			device_type = "cpu";
 			reg = <0x201>;
+			status = "disabled";
 			enable-method = "psci";
 			i-cache-size = <131072>;
 			i-cache-line-size = <64>;
@@ -1731,6 +1736,7 @@
 			compatible = "nvidia,tegra194-carmel";
 			device_type = "cpu";
 			reg = <0x300>;
+			status = "disabled";
 			enable-method = "psci";
 			i-cache-size = <131072>;
 			i-cache-line-size = <64>;
@@ -1745,6 +1751,7 @@
 			compatible = "nvidia,tegra194-carmel";
 			device_type = "cpu";
 			reg = <0x301>;
+			status = "disabled";
 			enable-method = "psci";
 			i-cache-size = <131072>;
 			i-cache-line-size = <64>;
Signature · 1 line
2.23.0
#1 lore raw
Quoted 6 lines · Thierry Reding

From: Thierry Reding <[email protected]>

According to ePAPR, CPUs that are quiescent should have the "status" property of the corresponding device tree node set to "disabled". Since all but the boot CPU are in a quiescent state on boot, mark all secondary CPUs as "disabled".

I think it might be best to leave this as-is, as we haven't done this for other dts, and the OS doesn't actually require or consume this regardless.

Adding this to all the Dts seems like unnecessary churn, and we can fix the DT spec instead.

Thanks,
Mark.

Quoted 72 lines

Note that this does not have an impact on SMP. Linux will still be able to boot these secondary CPUs like before.

---
 arch/arm64/boot/dts/nvidia/tegra194.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm64/boot/dts/nvidia/tegra194.dtsi +7 -0
index 59485976db64..ea165b2998f9 100644
@@ -1661,6 +1661,7 @@
 			compatible = "nvidia,tegra194-carmel";
 			device_type = "cpu";
 			reg = <0x001>;
+			status = "disabled";
 			enable-method = "psci";
 			i-cache-size = <131072>;
 			i-cache-line-size = <64>;
@@ -1675,6 +1676,7 @@
 			compatible = "nvidia,tegra194-carmel";
 			device_type = "cpu";
 			reg = <0x100>;
+			status = "disabled";
 			enable-method = "psci";
 			i-cache-size = <131072>;
 			i-cache-line-size = <64>;
@@ -1689,6 +1691,7 @@
 			compatible = "nvidia,tegra194-carmel";
 			device_type = "cpu";
 			reg = <0x101>;
+			status = "disabled";
 			enable-method = "psci";
 			i-cache-size = <131072>;
 			i-cache-line-size = <64>;
@@ -1703,6 +1706,7 @@
 			compatible = "nvidia,tegra194-carmel";
 			device_type = "cpu";
 			reg = <0x200>;
+			status = "disabled";
 			enable-method = "psci";
 			i-cache-size = <131072>;
 			i-cache-line-size = <64>;
@@ -1717,6 +1721,7 @@
 			compatible = "nvidia,tegra194-carmel";
 			device_type = "cpu";
 			reg = <0x201>;
+			status = "disabled";
 			enable-method = "psci";
 			i-cache-size = <131072>;
 			i-cache-line-size = <64>;
@@ -1731,6 +1736,7 @@
 			compatible = "nvidia,tegra194-carmel";
 			device_type = "cpu";
 			reg = <0x300>;
+			status = "disabled";
 			enable-method = "psci";
 			i-cache-size = <131072>;
 			i-cache-line-size = <64>;
@@ -1745,6 +1751,7 @@
 			compatible = "nvidia,tegra194-carmel";
 			device_type = "cpu";
 			reg = <0x301>;
+			status = "disabled";
 			enable-method = "psci";
 			i-cache-size = <131072>;
 			i-cache-line-size = <64>;
Signature · 1 line
2.23.0