Skip to contentSkip to conversation

eventdev: reserve space in main structs for extension

PATCH Applied [email protected] 2 participants 2 messages Nov 8, 2019 – Nov 12, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 eventdev: reserve space in main structs for extension

From: Jerin Jacob <[email protected]>

The struct rte_eventdev and rte_eventdev_data are supposed to be used internally only, but there is a chance that increasing their size would break ABI for some applications. In order to allow smooth addition of features without breaking ABI compatibility, some space is reserved.

---
 lib/librte_eventdev/rte_eventdev.h | 5 +++++
 1 file changed, 5 insertions(+)
lib/librte_eventdev/rte_eventdev.h +5 -0
index ced6f29d9..bc8952576 100644
@@ -1282,6 +1282,8 @@ struct rte_eventdev_data {
 
 	char name[RTE_EVENTDEV_NAME_MAX_LEN];
 	/**< Unique identifier name */
+	uint64_t reserved_64s[4]; /**< Reserved for future fields */
+	void *reserved_ptrs[4]; /**< Reserved for future fields */
 } __rte_cache_aligned;
 
 /** @internal The data structure associated with each event device. */
@@ -1314,6 +1316,9 @@ struct rte_eventdev {
 	RTE_STD_C11
 	uint8_t attached : 1;
 	/**< Flag indicating the device is attached */
+
+	uint64_t reserved_64s[4]; /**< Reserved for future fields */
+	void *reserved_ptrs[4]; /**< Reserved for future fields */
 } __rte_cache_aligned;
 
 extern struct rte_eventdev *rte_eventdevs;
Signature · 1 line
2.23.0
#1 lore raw

08/11/2019 17:56, [email protected]:

Quoted 9 lines

From: Jerin Jacob <[email protected]>

The struct rte_eventdev and rte_eventdev_data are supposed to be used internally only, but there is a chance that increasing their size would break ABI for some applications. In order to allow smooth addition of features without breaking ABI compatibility, some space is reserved.

Applied, thanks