ALSA: pcm: Yet another missing check of non-cached buffer type
PATCH 1/1 ALSA: pcm: Yet another missing check of non-cached buffer type
For non-x86 architectures, SNDRV_DMA_TYPE_DEV_UC should be treated equivalent with SNDRV_DMA_TYPE_DEV, where the default mmap handler still checks only about SNDRV_DMA_TYPE_DEV. Make the check more proper.
Note that all existing users of *_UC buffer types are x86-only, so this doesn't fix any bug, but just for consistency.
Fixes 42e748a0b325 ("ALSA: memalloc: Add non-cached buffer type")
Signed-off-by Takashi Iwai <[email protected]>
--- sound/core/pcm_native.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
sound/core/pcm_native.c +2 -1
@@ -3416,7 +3416,8 @@ int snd_pcm_lib_default_mmap(struct snd_pcm_substream *substream,#endif /* CONFIG_GENERIC_ALLOCATOR */ #ifndef CONFIG_X86 /* for avoiding warnings arch/x86/mm/pat.c */ if (IS_ENABLED (CONFIG_HAS_DMA ) && !substream->ops->page && - substream->dma_buffer.dev.type ==SNDRV_DMA_TYPE_DEV ) + (substream->dma_buffer.dev.type ==SNDRV_DMA_TYPE_DEV || + substream->dma_buffer.dev.type ==SNDRV_DMA_TYPE_DEV_UC )) return dma_mmap_coherent(substream->dma_buffer.dev.dev, area, substream->runtime->dma_area,
Signature · 6 lines
2.16.4 _______________________________________________ Alsa-devel mailing list [email protected] https://mailman.alsa-project.org/mailman/listinfo/alsa-devel