gpiolib: Support 'gpio-reserved-ranges' property
PATCH 1/1 gpiolib: Support 'gpio-reserved-ranges' property
Hi Fabrizio Castro,
I find a kernel panic issue by gpio when I upgrade kernel to 4.4.182-cip34 with Freescale LS1021A (gpiochip is mpc8xxx series):
Kernel log shows ?Unable to handle kernel NULL pointer dereference at virtual address 000000b4.?
Subsequently, I find the commit baff4777cdb80256cd24dede2a3d0af761356307 (gpiolib: Support 'gpio-reserved-ranges' property) could result in kernel panic because the code ?*np= chip->dev->of_node? is executed when chip->dev is NULL:
drivers/gpio/gpiolib-of.c +0 -0
+static void of_gpiochip_init_valid_mask(struct gpio_chip *chip) +{
+ int len, i; + u32 start, count; + struct device_node *np = chip->dev->of_node;
+
+ len = of_property_count_u32_elems(np, "gpio-reserved-ranges");
+ if (len < 0 || len % 2 != 0)
+ return;
+
+ for (i = 0; i < len; i += 2) {
+ of_property_read_u32_index(np, "gpio-reserved-ranges",
+ i, &start);
+ of_property_read_u32_index(np, "gpio-reserved-ranges",
+ i + 1, &count);
+ if (start >= chip->ngpio || start + count >= chip->ngpio)
+ continue;
+
+ bitmap_clear(chip->valid_mask, start, count);
+ }
+};
+
drivers/gpio/gpiolib.c +0 -0
@@ -292,6 +292,43 @@ static unsigned long *gpiochip_allocate_mask(struct gpio_chip *chip)return p;
}
+static int gpiochip_init_valid_mask(struct gpio_chip *gpiochip) +{
+#ifdef CONFIG_OF_GPIO
+ int size;
+ struct device_node *np = gpiochip->dev->of_node;
+
+ size = of_property_count_u32_elems(np, "gpio-reserved-ranges");
+ if (size > 0 && size % 2 == 0)
+ gpiochip->need_valid_mask = true;
+#endif
+
+ if (!gpiochip->need_valid_mask)
+ return 0;
+
+ gpiochip->valid_mask = gpiochip_allocate_mask(gpiochip);
+ if (!gpiochip->valid_mask)
+ return -ENOMEM;
+
+ return 0;
+}
+
Could you help me understand why we need to replaced chip->of_node with chip->dev->of_node?
The following two items I try have no kernel panic:
1. For gpio drivers:
It?s fine and no kernel panic issue if probe(struct platform_device *pdev) in gpio drivers executes the following codes:
struct cpio_chip *gc;gc->dev = &pdev->dev; //Put platform?s dev to gpiochip?s dev, and of_node info in pdev->dev->of_node also put in gpiochip structure.
But some gpio drivers doesn?t do this, such as gpio-mpc8xxx.c (mpc8xxx series), and result in kernel panic when use this commit.
2. For gpiolib:
//set the following code in gpiolib.c and gpiolib-of.c struct device_node *np = gpiochip->of_node;
Device node of platform will put in gpio chip when of_mm_gpiochip_add() is executed:
int of_mm_gpiochip_add(struct device_node *np,
struct of_mm_gpio_chip *mm_gc)
{
int ret = -ENOMEM;
struct gpio_chip *gc = &mm_gc->gc;
?..
mm_gc->gc.of_node = np;
}It?s seems chip->of_node is good.
Thanks,
Johnson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cip-project.org/pipermail/cip-dev/attachments/20191108/02a5be16/attachment-0001.html>
PATCH 1/1 gpiolib: Support 'gpio-reserved-ranges' property
Hi Johnson,
Thank you for reporting this.
Quoted 136 lines
From: Johnson CH Chen (???) <[email protected]>
Subject: [cip-dev] [PATCH] gpiolib: Support 'gpio-reserved-ranges' propertyHi Fabrizio Castro,
I find a kernel panic issue by gpio when I upgrade kernel to 4.4.182-cip34 with Freescale LS1021A (gpiochip is mpc8xxx series):
Kernel log shows ?Unable to handle kernel NULL pointer dereference at virtual address
000000b4.?Subsequently, I find the commit
baff4777cdb80256cd24dede2a3d0af761356307(gpiolib: Support 'gpio-reserved-ranges' property) could result in kernel panic because the code ?*np=chip->dev->of_node? is executed whenchip->devis NULL:drivers/gpio/gpiolib-of.c +0
-0index
5fe34a9df3e6..ec642bf1d976100644---
a/drivers/gpio/gpiolib-of.c+++
b/drivers/gpio/gpiolib-of.cdrivers/gpio/gpiolib-of.c +22
-0+static void of_gpiochip_init_valid_mask (struct gpio_chip *chip) +{ +int len, i; +u32 start, count; +struct device_node *np = chip->dev->of_node; + + len =of_property_count_u32_elems (np,"gpio-reserved-ranges" ); +if (len <0 || len %2 !=0 ) +return ; + +for (i =0 ; i < len; i +=2 ) { +of_property_read_u32_index (np,"gpio-reserved-ranges" , + i, &start); +of_property_read_u32_index (np,"gpio-reserved-ranges" , + i +1 , &count); +if (start >= chip->ngpio || start + count >= chip->ngpio) +continue ; + +bitmap_clear (chip->valid_mask, start, count); + } +}; +drivers/gpio/gpiolib.c +0
-0index
adb474089733..487a86495163100644---
a/drivers/gpio/gpiolib.c+++
b/drivers/gpio/gpiolib.cdrivers/gpio/gpiolib.c +21
-0@@ -292,6 +292,43 @@ static unsigned long *gpiochip_allocate_mask(struct gpio_chip *chip)return p; } +static int gpiochip_init_valid_mask (struct gpio_chip *gpiochip) +{ +#ifdef CONFIG_OF_GPIO +int size; +struct device_node *np = gpiochip->dev->of_node; + + size =of_property_count_u32_elems (np,"gpio-reserved-ranges" ); +if (size >0 && size %2 ==0 ) + gpiochip->need_valid_mask = true; +#endif + +if (!gpiochip->need_valid_mask) +return 0 ; + + gpiochip->valid_mask =gpiochip_allocate_mask (gpiochip); +if (!gpiochip->valid_mask) +return -ENOMEM ; + +return 0 ; +} +
Quoted 1 line
Could you help me understand why we need to replaced
chip->of_nodewithchip->dev->of_node?
It looks like that solved the issues I was seeing, but it was short sighted as some drivers don't initialize that.
I think I need to make some adjustments to this patch, and I also think I need to backport patch:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.4-rc6&id=6ff0497402ef7269ee6a72f62eb85adaa7a4768e
I need to make a couple of experiments, and I'll send something across for you to try if you don't mind.
Thanks,
Fab
Quoted 65 lines
The following two items I try have no kernel panic:
1. For gpio drivers:
It?s fine and no kernel panic issue if
probe(struct platform_device *pdev)in gpio drivers executes the following codes:struct
cpio_chip*gc;
gc->dev=&pdev->dev; //Put platform?s dev to gpiochip?s dev, andof_nodeinfo inpdev->dev->of_nodealso put in gpiochip structure.But some gpio drivers doesn?t do this, such as
gpio-mpc8xxx.c(mpc8xxx series), and result in kernel panic when use this commit.2. For gpiolib:
//set the following code in
gpiolib.candgpiolib-of.cstruct
device_node*np =gpiochip->of_node;Device node of platform will put in gpio chip when
of_mm_gpiochip_add()is executed:int of_mm_gpiochip_add(struct
device_node*np,struct
of_mm_gpio_chip*mm_gc){
int ret = -ENOMEM; struct gpio_chip *gc = &mm_gc->gc;?..
mm_gc->gc.of_node = np;}
It?s seems
chip->of_nodeis good.Thanks,
Johnson
PATCH 1/1 gpiolib: Support 'gpio-reserved-ranges' property
Hi Fab,
Thanks your info. It seems be the same problem for of_node inconsistency of gpiolib. I am glad to test the patch and some patches you provide me later.
Thanks,
Johnson
?? iOS ? Outlook<https://aka.ms/o0ukef>
________________________________
???: Fabrizio Castro <[email protected]>
????: Friday, November 8, 2019 9:18:30 PM
???: Johnson CH Chen (???) <[email protected]>
??: cip-dev at lists.cip-project.org <[email protected]>; Biju Das <[email protected]> ??: RE: [cip-dev] [PATCH] gpiolib: Support 'gpio-reserved-ranges' property
Hi Johnson,
Thank you for reporting this.
Quoted 136 lines
From: Johnson CH Chen (???) <[email protected]>
Subject: [cip-dev] [PATCH] gpiolib: Support 'gpio-reserved-ranges' propertyHi Fabrizio Castro,
I find a kernel panic issue by gpio when I upgrade kernel to 4.4.182-cip34 with Freescale LS1021A (gpiochip is mpc8xxx series):
Kernel log shows ?Unable to handle kernel NULL pointer dereference at virtual address
000000b4.?Subsequently, I find the commit
baff4777cdb80256cd24dede2a3d0af761356307(gpiolib: Support 'gpio-reserved-ranges' property) could result in kernel panic because the code ?*np=chip->dev->of_node? is executed whenchip->devis NULL:drivers/gpio/gpiolib-of.c +0
-0index
5fe34a9df3e6..ec642bf1d976100644---
a/drivers/gpio/gpiolib-of.c+++
b/drivers/gpio/gpiolib-of.cdrivers/gpio/gpiolib-of.c +22
-0+static void of_gpiochip_init_valid_mask (struct gpio_chip *chip) +{ +int len, i; +u32 start, count; +struct device_node *np = chip->dev->of_node; + + len =of_property_count_u32_elems (np,"gpio-reserved-ranges" ); +if (len <0 || len %2 !=0 ) +return ; + +for (i =0 ; i < len; i +=2 ) { +of_property_read_u32_index (np,"gpio-reserved-ranges" , + i, &start); +of_property_read_u32_index (np,"gpio-reserved-ranges" , + i +1 , &count); +if (start >= chip->ngpio || start + count >= chip->ngpio) +continue ; + +bitmap_clear (chip->valid_mask, start, count); + } +}; +drivers/gpio/gpiolib.c +0
-0index
adb474089733..487a86495163100644---
a/drivers/gpio/gpiolib.c+++
b/drivers/gpio/gpiolib.cdrivers/gpio/gpiolib.c +21
-0@@ -292,6 +292,43 @@ static unsigned long *gpiochip_allocate_mask(struct gpio_chip *chip)return p; } +static int gpiochip_init_valid_mask (struct gpio_chip *gpiochip) +{ +#ifdef CONFIG_OF_GPIO +int size; +struct device_node *np = gpiochip->dev->of_node; + + size =of_property_count_u32_elems (np,"gpio-reserved-ranges" ); +if (size >0 && size %2 ==0 ) + gpiochip->need_valid_mask = true; +#endif + +if (!gpiochip->need_valid_mask) +return 0 ; + + gpiochip->valid_mask =gpiochip_allocate_mask (gpiochip); +if (!gpiochip->valid_mask) +return -ENOMEM ; + +return 0 ; +} +
Quoted 1 line
Could you help me understand why we need to replaced
chip->of_nodewithchip->dev->of_node?
It looks like that solved the issues I was seeing, but it was short sighted as some drivers don't initialize that.
I think I need to make some adjustments to this patch, and I also think I need to backport patch:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.4-rc6&id=6ff0497402ef7269ee6a72f62eb85adaa7a4768e
I need to make a couple of experiments, and I'll send something across for you to try if you don't mind.
Thanks,
Fab
Quoted 58 lines
The following two items I try have no kernel panic:
1. For gpio drivers:
It?s fine and no kernel panic issue if
probe(struct platform_device *pdev)in gpio drivers executes the following codes:struct
cpio_chip*gc;
gc->dev=&pdev->dev; //Put platform?s dev to gpiochip?s dev, andof_nodeinfo inpdev->dev->of_nodealso put in gpiochip structure.But some gpio drivers doesn?t do this, such as
gpio-mpc8xxx.c(mpc8xxx series), and result in kernel panic when use this commit.2. For gpiolib:
//set the following code in
gpiolib.candgpiolib-of.cstruct
device_node*np =gpiochip->of_node;Device node of platform will put in gpio chip when
of_mm_gpiochip_add()is executed:int of_mm_gpiochip_add(struct
device_node*np,struct
of_mm_gpio_chip*mm_gc){
int ret = -ENOMEM; struct gpio_chip *gc = &mm_gc->gc;?..
mm_gc->gc.of_node = np;}
Quoted 7 lines
It?s seems
chip->of_nodeis good.Thanks,
Johnson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cip-project.org/pipermail/cip-dev/attachments/20191108/24940fb1/attachment-0001.html>
PATCH 1/1 gpiolib: Support 'gpio-reserved-ranges' property
In reply to Fabrizio CastroHi!
Quoted 1 line
Thank you for reporting this.
Is it -cip problem, or -stable problem?
Best regards,
Pavel
Signature · 9 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 195 bytes Desc: not available URL: <http://lists.cip-project.org/pipermail/cip-dev/attachments/20191108/19a5cab4/attachment.sig>
PATCH 1/1 gpiolib: Support 'gpio-reserved-ranges' property
Hi,
I try stable kernel (Linux 4.4.194) with my system. It's good and without gpio's kernel panic phenomena. Just for your reference.
Thanks,
Johnson
-----Original Message-----
From: Pavel Machek <[email protected]>
Sent: Saturday, November 9, 2019 5:27 AM
To: Fabrizio Castro <[email protected]>
Cc: Johnson CH Chen (???) <[email protected]>; cip-dev at lists.cip-project.org; Biju Das <[email protected]>
Subject: Re: [cip-dev] [PATCH] gpiolib: Support 'gpio-reserved-ranges' property
Hi!
Quoted 1 line
Thank you for reporting this.
Is it -cip problem, or -stable problem?
Best regards,
Pavel
Signature · 2 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany