Skip to contentSkip to conversation

i2c: ismt: Add missed pci_release_region

PATCH In review Chuhong Yuan 2 participants 2 messages Nov 9, 2019 – Mar 22, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c: ismt: Add missed pci_release_region

ismt_remove forgets to call pci_release_region when remove. Add the call to fix it.

---
 drivers/i2c/busses/i2c-ismt.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/i2c/busses/i2c-ismt.c +2 -0
index 2f95e25a10f7..c393e629cac3 100644
@@ -943,6 +943,8 @@ static void ismt_remove(struct pci_dev *pdev)
 	struct ismt_priv *priv = pci_get_drvdata(pdev);
 
 	i2c_del_adapter(&priv->adapter);
+
+	pci_release_region(pdev, SMBBAR);
 }
 
 static struct pci_driver ismt_driver = {
Signature · 1 line
2.23.0
#1 lore raw
Quoted 4 lines · Chuhong Yuan

ismt_remove forgets to call pci_release_region when remove. Add the call to fix it.

Chuhong Yuan, your To-Header is broken, so you never got a response.

Adding the maintainers to CC.

Quoted 20 lines
---
 drivers/i2c/busses/i2c-ismt.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/i2c/busses/i2c-ismt.c +2 -0
index 2f95e25a10f7..c393e629cac3 100644
@@ -943,6 +943,8 @@ static void ismt_remove(struct pci_dev *pdev)
 	struct ismt_priv *priv = pci_get_drvdata(pdev);
 
 	i2c_del_adapter(&priv->adapter);
+
+	pci_release_region(pdev, SMBBAR);
 }
 
 static struct pci_driver ismt_driver = {
Signature · 1 line
2.23.0