Skip to contentSkip to conversation

spi: nxp-fspi: Use devm API to fix missed unregistration of controller

PATCH In review Chuhong Yuan 2 participants 2 messages Nov 9, 2019 – Nov 11, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: nxp-fspi: Use devm API to fix missed unregistration of controller

This driver forgets to unregister controller when remove. Use devm API to unregister it automatically to fix it.

---
 drivers/spi/spi-nxp-fspi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-nxp-fspi.c +1 -1
index 501b923f2c27..c36bb1bb464e 100644
@@ -1027,7 +1027,7 @@ static int nxp_fspi_probe(struct platform_device *pdev)
 
 	ctlr->dev.of_node = np;
 
-	ret = spi_register_controller(ctlr);
+	ret = devm_spi_register_controller(&pdev->dev, ctlr);
 	if (ret)
 		goto err_destroy_mutex;
 
Signature · 1 line
2.23.0
maintainer
#1 lore raw

Applied "spi: nxp-fspi: Use devm API to fix missed unregistration of controller" to the spi tree

The patch

spi: nxp-fspi: Use devm API to fix missed unregistration of controller

has been applied to the spi tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.5

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 69c23dbf5f695c219008257b3bd86cff63edbe0b Mon Sep 17 00:00:00 2001

From: Chuhong Yuan <[email protected]>
Date: Sat, 9 Nov 2019 15:55:17 +0800
Subject: [PATCH] spi: nxp-fspi: Use devm API to fix missed unregistration of
controller

This driver forgets to unregister controller when remove. Use devm API to unregister it automatically to fix it.

---
 drivers/spi/spi-nxp-fspi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-nxp-fspi.c +1 -1
index 501b923f2c27..c36bb1bb464e 100644
@@ -1027,7 +1027,7 @@ static int nxp_fspi_probe(struct platform_device *pdev)
 
 	ctlr->dev.of_node = np;
 
-	ret = spi_register_controller(ctlr);
+	ret = devm_spi_register_controller(&pdev->dev, ctlr);
 	if (ret)
 		goto err_destroy_mutex;
 
Signature · 1 line
2.20.1