Skip to contentSkip to conversation

iio: adc: aspeed: use devm_platform_ioremap_resource

PATCH In review [email protected] 2 participants 3 messages Oct 13, 2019 – Nov 9, 2019

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 1/1 iio: adc: aspeed: use devm_platform_ioremap_resource

From: Jonathan Cameron <[email protected]>

Reduces boilerplate.

Identified by: Coccinelle / coccicheck

CHECK drivers/iio/adc/aspeed_adc.c
drivers/iio/adc/aspeed_adc.c:189:1-11: WARNING: Use devm_platform_ioremap_resource for data -> base

---
 drivers/iio/adc/aspeed_adc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/aspeed_adc.c +1 -3
index d3fc39df535d..1e5375235cfe 100644
@@ -173,7 +173,6 @@ static int aspeed_adc_probe(struct platform_device *pdev)
 	struct iio_dev *indio_dev;
 	struct aspeed_adc_data *data;
 	const struct aspeed_adc_model_data *model_data;
-	struct resource *res;
 	const char *clk_parent_name;
 	int ret;
 	u32 adc_engine_control_reg_val;
@@ -185,8 +184,7 @@ static int aspeed_adc_probe(struct platform_device *pdev)
 	data = iio_priv(indio_dev);
 	data->dev = &pdev->dev;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	data->base = devm_ioremap_resource(&pdev->dev, res);
+	data->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(data->base))
 		return PTR_ERR(data->base);
 
Signature · 1 line
2.23.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · On Sun, 2019-10-13 at 12:37 +0100, [email protected] wrote:

From: Jonathan Cameron <[email protected]>

Reduces boilerplate.

Identified by: Coccinelle / coccicheck

CHECK drivers/iio/adc/aspeed_adc.c
drivers/iio/adc/aspeed_adc.c:189:1-11: WARNING: Use devm_platform_ioremap_resource for data -> base

Quoted 30 lines
---
 drivers/iio/adc/aspeed_adc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/aspeed_adc.c +0 -1
index d3fc39df535d..1e5375235cfe 100644
@@ -173,7 +173,6 @@ static int aspeed_adc_probe(struct platform_device
 *pdev)
 	struct iio_dev *indio_dev;
 	struct aspeed_adc_data *data;
 	const struct aspeed_adc_model_data *model_data;
-	struct resource *res;
 	const char *clk_parent_name;
 	int ret;
drivers/iio/adc/aspeed_adc.c +1 -2
 	u32 adc_engine_control_reg_val;
@@ -185,8 +184,7 @@ static int aspeed_adc_probe(struct platform_device
 *pdev)
 	data = iio_priv(indio_dev);
 	data->dev = &pdev->dev;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	data->base = devm_ioremap_resource(&pdev->dev, res);
+	data->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(data->base))
 		return PTR_ERR(data->base);
author maintainer Applied
#2 lore raw
Quoted 5 lines · Alexandru
Quoted 4 lines · On Sun, 2019-10-13 at 12:37 +0100, [email protected] wrote:

From: Jonathan Cameron <[email protected]>

Reduces boilerplate.

Quoted 8 lines
Quoted 6 lines

Identified by: Coccinelle / coccicheck

CHECK drivers/iio/adc/aspeed_adc.c
drivers/iio/adc/aspeed_adc.c:189:1-11: WARNING: Use devm_platform_ioremap_resource for data -> base

Applied. Thanks,

Jonathan

Quoted 31 lines
Quoted 31 lines
---
 drivers/iio/adc/aspeed_adc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/aspeed_adc.c +0 -1
index d3fc39df535d..1e5375235cfe 100644
@@ -173,7 +173,6 @@ static int aspeed_adc_probe(struct platform_device
 *pdev)
 	struct iio_dev *indio_dev;
 	struct aspeed_adc_data *data;
 	const struct aspeed_adc_model_data *model_data;
-	struct resource *res;
 	const char *clk_parent_name;
 	int ret;
drivers/iio/adc/aspeed_adc.c +1 -2
 	u32 adc_engine_control_reg_val;
@@ -185,8 +184,7 @@ static int aspeed_adc_probe(struct platform_device
 *pdev)
 	data = iio_priv(indio_dev);
 	data->dev = &pdev->dev;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	data->base = devm_ioremap_resource(&pdev->dev, res);
+	data->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(data->base))
 		return PTR_ERR(data->base);