Skip to contentSkip to conversation

iio: adc: lpc18xx: use devm_platform_ioremap_resource

PATCH In review [email protected] 2 participants 3 messages Oct 13, 2019 – Nov 9, 2019

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 1/1 iio: adc: lpc18xx: use devm_platform_ioremap_resource

From: Jonathan Cameron <[email protected]>

Avoid local boilerplate.
Identified by coccinelle

CHECK drivers/iio/adc/lpc18xx_adc.c
drivers/iio/adc/lpc18xx_adc.c:137:1-10: WARNING: Use devm_platform_ioremap_resource for adc -> base

---
 drivers/iio/adc/lpc18xx_adc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/lpc18xx_adc.c +1 -3
index e400a95f553d..4c6ac6644dc0 100644
@@ -119,7 +119,6 @@ static int lpc18xx_adc_probe(struct platform_device *pdev)
 {
 	struct iio_dev *indio_dev;
 	struct lpc18xx_adc *adc;
-	struct resource *res;
 	unsigned int clkdiv;
 	unsigned long rate;
 	int ret;
@@ -133,8 +132,7 @@ static int lpc18xx_adc_probe(struct platform_device *pdev)
 	adc->dev = &pdev->dev;
 	mutex_init(&adc->lock);
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	adc->base = devm_ioremap_resource(&pdev->dev, res);
+	adc->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(adc->base))
 		return PTR_ERR(adc->base);
 
Signature · 1 line
2.23.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · On Sun, 2019-10-13 at 16:32 +0100, [email protected] wrote:

From: Jonathan Cameron <[email protected]>

Avoid local boilerplate.
Identified by coccinelle

CHECK drivers/iio/adc/lpc18xx_adc.c
drivers/iio/adc/lpc18xx_adc.c:137:1-10: WARNING: Use devm_platform_ioremap_resource for adc -> base

Quoted 32 lines
---
 drivers/iio/adc/lpc18xx_adc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/lpc18xx_adc.c +0 -1
index e400a95f553d..4c6ac6644dc0 100644
@@ -119,7 +119,6 @@ static int lpc18xx_adc_probe(struct platform_device
 *pdev)
 {
 	struct iio_dev *indio_dev;
 	struct lpc18xx_adc *adc;
-	struct resource *res;
 	unsigned int clkdiv;
 	unsigned long rate;
drivers/iio/adc/lpc18xx_adc.c +1 -2
 	int ret;
@@ -133,8 +132,7 @@ static int lpc18xx_adc_probe(struct platform_device
 *pdev)
 	adc->dev = &pdev->dev;
 	mutex_init(&adc->lock);
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	adc->base = devm_ioremap_resource(&pdev->dev, res);
+	adc->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(adc->base))
 		return PTR_ERR(adc->base);
author maintainer Applied
#2 lore raw
Quoted 11 lines · Alexandru
Quoted 8 lines · On Sun, 2019-10-13 at 16:32 +0100, [email protected] wrote:

From: Jonathan Cameron <[email protected]>

Avoid local boilerplate.
Identified by coccinelle

CHECK drivers/iio/adc/lpc18xx_adc.c
drivers/iio/adc/lpc18xx_adc.c:137:1-10: WARNING: Use devm_platform_ioremap_resource for adc -> base

Applied,

Thanks,

Jonathan

Quoted 33 lines
Quoted 33 lines
---
 drivers/iio/adc/lpc18xx_adc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/lpc18xx_adc.c +0 -1
index e400a95f553d..4c6ac6644dc0 100644
@@ -119,7 +119,6 @@ static int lpc18xx_adc_probe(struct platform_device
 *pdev)
 {
 	struct iio_dev *indio_dev;
 	struct lpc18xx_adc *adc;
-	struct resource *res;
 	unsigned int clkdiv;
 	unsigned long rate;
drivers/iio/adc/lpc18xx_adc.c +1 -2
 	int ret;
@@ -133,8 +132,7 @@ static int lpc18xx_adc_probe(struct platform_device
 *pdev)
 	adc->dev = &pdev->dev;
 	mutex_init(&adc->lock);
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	adc->base = devm_ioremap_resource(&pdev->dev, res);
+	adc->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(adc->base))
 		return PTR_ERR(adc->base);